public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Intel graphics driver community testing & development
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [CI i-g-t] tests: Drop gem_bad_length as redundant
Date: Thu, 12 Oct 2017 11:37:42 +0300	[thread overview]
Message-ID: <1507797462.5138.21.camel@linux.intel.com> (raw)
In-Reply-To: <20171010122856.10504-1-joonas.lahtinen@linux.intel.com>

On Tue, 2017-10-10 at 15:28 +0300, Joonas Lahtinen wrote:
> From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> 
> Most of the gem_bad_length code is compiled out because creating
> a zero-length object is not allowed anymore by i915 and thus it is
> not possible to execute it. The remaining part checks that creation of
> a zero-length object does indeed fail, which is also checked by
> gem_create/create-invalid-size.
> The only difference between the 2 tests is that gem_bad_length checks
> specifically for EINVAL while create-invalid-size only looks for
> failure, so after adding the EINVAL check to create-invalid-size it is
> safe to drop gem_bad_length.
> 
> v2 (Joonas):
> - Clarify header line, split the patch, fix Meson build and add Cc:
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Merged the patch.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2017-10-12  8:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 12:28 [CI i-g-t] tests: Drop gem_bad_length as redundant Joonas Lahtinen
2017-10-10 18:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-11  1:24 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-10-12  8:37 ` Joonas Lahtinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507797462.5138.21.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox