From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH v13 19/21] drm/i915/guc: Fix enable/disable of GuC GGTT invalidate functions Date: Thu, 12 Oct 2017 12:08:50 +0300 Message-ID: <1507799330.5138.29.camel@linux.intel.com> References: <1507712056-25030-1-git-send-email-sagar.a.kamble@intel.com> <1507712056-25030-20-git-send-email-sagar.a.kamble@intel.com> <8b97cb9f-8a24-be97-2987-47fe9068088b@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C4A66E7D1 for ; Thu, 12 Oct 2017 09:08:54 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org, Sagar Arun Kamble List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE3LTEwLTExIGF0IDIwOjIwICswMjAwLCBNaWNoYWwgV2FqZGVjemtvIHdyb3Rl Ogo+IE9uIFdlZCwgMTEgT2N0IDIwMTcgMjA6MDk6MTAgKzAyMDAsIFNhZ2FyIEFydW4gS2FtYmxl ICAKPiA8c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPiB3cm90ZToKPiAKPiA+IAo+ID4gCj4gPiBP biAxMC8xMS8yMDE3IDExOjI4IFBNLCBNaWNoYWwgV2FqZGVjemtvIHdyb3RlOgo+ID4gPiBPbiBX ZWQsIDExIE9jdCAyMDE3IDE5OjQ0OjMxICswMjAwLCBTYWdhciBBcnVuIEthbWJsZSAgCj4gPiA+ IDxzYWdhci5hLmthbWJsZUBpbnRlbC5jb20+IHdyb3RlOgo+ID4gPiAKPiA+ID4gPiAKPiA+ID4g PiAKPiA+ID4gPiBPbiAxMC8xMS8yMDE3IDExOjA1IFBNLCBNaWNoYWwgV2FqZGVjemtvIHdyb3Rl Ogo+ID4gPiA+ID4gT24gV2VkLCAxMSBPY3QgMjAxNyAxMDo1NDoxNCArMDIwMCwgU2FnYXIgQXJ1 biBLYW1ibGUgIAo+ID4gPiA+ID4gPHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4gd3JvdGU6Cj4g PiA+ID4gPiAKPiA+ID4gPiA+ID4gaTkxNV9nZ3R0X2VuYWJsZV9ndWMgaGFzIHRvIGhhcHBlbiBm aXJzdCBkdXJpbmcgaTkxNV9nZW1fcmVzdW1lCj4gPiA+ID4gPiA+IGlmIEd1QyBsb2FkaW5nIGlz IGVuYWJsZWQgYmVmb3JlIEdUVCByZXN0b3JlLiBJbiBjYXNlIEd1QyBpcyBub3QKPiA+ID4gPiA+ ID4gbG9hZGVkIHRoaXMgZW5hYmxpbmcgaGFwcGVuaW5nIGR1cmluZyBpbnRlbF91Y19pbml0X2h3 IG5lZWQgdG8KPiA+ID4gPiA+ID4gc2tpcHBlZC4gKGF2b2lkIHRoZSBHRU1fQlVHX09OKQo+ID4g PiA+ID4gPiBpOTE1X2dndHRfZGlzYWJsZV9ndWMgYXQgdGhlIGVuZCBvZiByZXNldC9zdXNwZW5k L3VubG9hZCBpcyBuZWVkZWQKPiA+ID4gPiA+ID4gcG9zdCBHR1RUIHN1c3BlbmQgb3BlcmF0aW9u cy4gQ2FsbGluZyBpdCBkdXJpbmcgdWNfc2FuaXRpemUgY292ZXJzCj4gPiA+ID4gPiA+IGFsbCBz Y2VuYXJpb3MuIEhlbmNlLCBpdCBpcyByZW1vdmVkIGZyb20gaW50ZWxfdWNfZmluaV9ody4gQWxz byB0aGVzZQo+ID4gPiA+ID4gPiBuZWVkdG8gYmUgcHJvdGVjdGVkIGJ5IHN0cnVjdF9tdXRleC4g SGVuY2Ugc3RydWN0X211dGV4IGxvY2tpbmcgaXMKPiA+ID4gPiA+ID4gYWRkZWQgaW4gaTkxNV9n ZW1fc2FuaXRpemUgd2hpbGUgc2FuaXRpemluZyB1Qy4gc3RydWN0X211dGV4IGlzICAKPiA+ID4g PiA+ID4gYWxyZWFkeQo+ID4gPiA+ID4gPiBoZWxkIGR1cmluZyBpOTE1X2dlbV9yZXNldF9wcmVw YXJlLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogU2FnYXIgQXJ1biBL YW1ibGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4KPiA+ID4gPiA+ID4gQ2M6IE1pY2hhbCBX YWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+ID4gPiA+ID4gPiBDYzogTWlj aGHFgiBXaW5pYXJza2kgPG1pY2hhbC53aW5pYXJza2lAaW50ZWwuY29tPgo+ID4gPiA+ID4gPiBD YzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiA+ID4gPiA+IENj OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8 ICA0ICsrKysKPiA+ID4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMgfCAx NiArKysrKysrKysrKy0tLS0tCj4gPiA+ID4gPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2Vy dGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgCj4gPiA+ID4gPiA+IGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ID4gPiA+ID4gPiBpbmRleCBhNGJiZjZjLi43 N2EwNzQ2IDEwMDY0NAo+ID4gPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4gPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMK PiA+ID4gPiA+ID4gQEAgLTQ3NTksNiArNDc1OSwxMCBAQCB2b2lkIGk5MTVfZ2VtX3Jlc3VtZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAgCj4gPiA+ID4gPiA+ICpkZXZfcHJpdikKPiA+ID4gPiA+ ID4gICAgICBXQVJOX09OKGRldl9wcml2LT5ndC5hd2FrZSk7Cj4gPiA+ID4gPiA+ICAgICBtdXRl eF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gPiA+ID4gPiA+ICsgICAgLyogV2UgbmVlZCB0 byBub3RpZnkgdGhlIGd1YyB3aGVuZXZlciB3ZSBjaGFuZ2UgdGhlIEdHVFQgKi8KPiA+ID4gPiA+ ID4gKyAgICBpZiAoaTkxNV9tb2RwYXJhbXMuZW5hYmxlX2d1Y19sb2FkaW5nKQo+ID4gPiA+ID4g PiArICAgICAgICBpOTE1X2dndHRfZW5hYmxlX2d1YyhkZXZfcHJpdik7Cj4gPiA+ID4gPiA+ICsK PiA+ID4gPiA+ID4gICAgICBpOTE1X2dlbV9yZXN0b3JlX2d0dF9tYXBwaW5ncyhkZXZfcHJpdik7 Cj4gPiA+ID4gPiA+ICAgICAgaTkxNV9nZW1fcmVzdG9yZV9mZW5jZXMoZGV2X3ByaXYpOwo+ID4g PiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyAgCj4g PiA+ID4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+ID4gPiA+ID4gPiBp bmRleCA5MDEwYWI1Li4wYjc5OWZlIDEwMDY0NAo+ID4gPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4gPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3VjLmMKPiA+ID4gPiA+ID4gQEAgLTE4NCw4ICsxODQsMTQgQEAgaW50IGludGVs X3VjX2luaXRfaHcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgIAo+ID4gPiA+ID4gPiAqZGV2X3By aXYpCj4gPiA+ID4gPiA+ICAgICAgZ3VjX2Rpc2FibGVfY29tbXVuaWNhdGlvbihndWMpOwo+ID4g PiA+ID4gPiAgICAgIGdlbjlfcmVzZXRfZ3VjX2ludGVycnVwdHMoZGV2X3ByaXYpOwo+ID4gPiA+ ID4gPiAtICAgIC8qIFdlIG5lZWQgdG8gbm90aWZ5IHRoZSBndWMgd2hlbmV2ZXIgd2UgY2hhbmdl IHRoZSBHR1RUICovCj4gPiA+ID4gPiA+IC0gICAgaTkxNV9nZ3R0X2VuYWJsZV9ndWMoZGV2X3By aXYpOwo+ID4gPiA+ID4gPiArICAgIC8qCj4gPiA+ID4gPiA+ICsgICAgICogV2UgbmVlZCB0byBu b3RpZnkgdGhlIGd1YyB3aGVuZXZlciB3ZSBjaGFuZ2UgdGhlIEdHVFQuCj4gPiA+ID4gPiA+ICsg ICAgICogRHVyaW5nIHJlc3VtZSBmcm9tIHNsZWVwIHdlIHdvdWxkIGhhdmUgYWxyZWFkeSB1cGRh dGVkIHRoZQo+ID4gPiA+ID4gPiArICAgICAqIEdHVFQgaW52YWxpZGF0ZSBmdW5jdGlvbiBmb3Ig R3VDIGR1cmluZyBpOTE1X2dlbV9yZXN1bWUgc28KPiA+ID4gPiA+ID4gKyAgICAgKiB3ZSBuZWVk IHRvIHNraXAgaGVyZS4gV2lsbCBlbmFibGUgaGVyZSBvbiBkcml2ZXIgbG9hZC9yZXNldC4KPiA+ ID4gPiA+ID4gKyAgICAgKi8KPiA+ID4gPiA+ID4gKyAgICBpZiAoIWd1Yy0+c3VzcGVuZGVkKQo+ ID4gPiA+ID4gPiArICAgICAgICBpOTE1X2dndHRfZW5hYmxlX2d1YyhkZXZfcHJpdik7Cj4gPiA+ ID4gPiA+ICAgICBpZiAoaTkxNV9tb2RwYXJhbXMuZW5hYmxlX2d1Y19zdWJtaXNzaW9uKSB7Cj4g PiA+ID4gPiA+ICAgICAgICAgIC8qCj4gPiA+ID4gPiA+IEBAIC0zMDksOSArMzE1LDYgQEAgdm9p ZCBpbnRlbF91Y19jbGVhbnVwKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICAKPiA+ID4gPiA+ID4g KmRldl9wcml2KQo+ID4gPiA+ID4gPiAgICAgIGd1Y19mcmVlX2xvYWRfZXJyX2xvZyhndWMpOwo+ ID4gPiA+ID4gPiAgICAgaTkxNV9ndWNfc3VibWlzc2lvbl9jbGVhbnVwKGRldl9wcml2KTsKPiA+ ID4gPiA+ID4gLQo+ID4gPiA+ID4gPiAtICAgIGlmIChpOTE1X21vZHBhcmFtcy5lbmFibGVfZ3Vj X2xvYWRpbmcpCj4gPiA+ID4gPiA+IC0gICAgICAgIGk5MTVfZ2d0dF9kaXNhYmxlX2d1YyhkZXZf cHJpdik7Cj4gPiA+ID4gPiA+ICB9Cj4gPiA+ID4gPiA+IC8qKgo+ID4gPiA+ID4gPiBAQCAtNDUy LDYgKzQ1NSw5IEBAIHZvaWQgaW50ZWxfdWNfc2FuaXRpemUoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgIAo+ID4gPiA+ID4gPiAqZGV2X3ByaXYpCj4gPiA+ID4gPiA+ICAgICAgc3RydWN0IGludGVs X3VjX2Z3ICpodWNfZncgPSAmZGV2X3ByaXYtPmh1Yy5mdzsKPiA+ID4gPiA+ID4gICAgIGlmIChp OTE1X21vZHBhcmFtcy5lbmFibGVfZ3VjX2xvYWRpbmcpIHsKPiA+ID4gPiA+ID4gKyAgICAgICAg aWYgKGd1Y19mdy0+bG9hZF9zdGF0dXMgPT0gSU5URUxfVUNfRklSTVdBUkVfU1VDQ0VTUykKPiA+ ID4gPiA+IAo+ID4gPiA+ID4gSG1tLCBpc24ndCB0aGF0IGNoZWNrIHJlZHVuZGFudCA/Cj4gPiA+ ID4gCj4gPiA+ID4gdWNfc2FuaXRpemUgY2FuIGhhcHBlbiB3aXRob3V0IGZpcm13YXJlIGxvYWRl ZCB0b28gaW4gd2hpY2ggY2FzZSB3ZQo+ID4gPiAKPiA+ID4gSWYgdWNfc2FuaXRpemUgY2FuIGJl IGxvYWRlZCB3aXRob3V0IGZpcm13YXJlIGxvYWRlZCwgdGhlbiBJIGFzc3VtZQo+ID4gPiBpOTE1 X21vZHBhcmFtcy5lbmFibGVfZ3VjX2xvYWRpbmcgd2lsbCBiZSBjbGVhcmVkIHRvbywgcmlnaHQg Pwo+ID4gPiAKPiA+ID4gSSdtIGp1c3Qgd29uZGVyaW5nIGlmIHdlIG5lZWQgdG8gY2hlY2sgYm90 aCBtb2RwYXJhbSBhbmQgZncgc3RhdHVzLgo+ID4gCj4gPiBhY3R1YWxseSBsb2FkIHRpbWUgdWNf c2FuaXRpemUgaXMgaGFwcGVuaW5nIGJlZm9yZSB1Y19zYW5pdGl6ZV9vcHRpb25zCj4gCj4gSG1t LCBzbyBtYXliZSB3ZSBzaG91bGQgY2FsbCBpbnRlbF9zYW5pdGl6ZV9vcHRpb25zKCkgZnJvbSBv ciByaWdodCBhZnRlcgo+IGk5MTVfZHJpdmVyX2luaXRfZWFybHkoKSA/IEl0IGxvb2tzIHRoYXQg YWxsICdzYW5pdGl6ZS1vcHRpb25zJyBhcmUgdXNpbmcKPiBvbmx5IGRldmljZSBpbmZvIGZsYWdz LCB0aGVyZSBpcyBubyBNTUlPIGFjY2Vzcy4gQ2hyaXMvSm9vbmFzPwoKV2lsbCBiZSBoYXJkIHRv IGFuc3dlciBhbnkgcXVlc3Rpb24gb24gcGF0Y2ggMTkvMjEsIHdoZW4gdGhlIHByZWNlZGluZwpw YXRjaGVzIGFyZSBzdGlsbCB1bmRlciBkZWJhdGUuCgpXaGF0IEkgbWVhbnQgd2l0aCBmb2N1c2lu ZyBvbiBzaW5nbGUgc2VyaWVzIGF0IGEgdGltZSBpcyB0aGF0IHdlIGZpcnN0CmRpc2N1c3Mgb24g YW55IGNoYW5nZXMgdG8gZ2V0IHRoZSBmaXJzdCBwYXRjaGVzIG1lcmdlZCBpbiByZWFzb25hYmxl CnNpemVkIGNodW5rcyBvZiBmZXcgcGF0Y2hlcyBwZXIgbWVyZ2UuIER1cmluZyB0aGF0IGRpc2N1 c3Npb24sIGxldHMKaG9sZCB0aGUgZGVwZW5kZW50IHNlcmllcyBmcm9tIHRoZSBtYWlsaW5nIGxp c3QgZm9yIGEgd2hpbGUsIGJlY2F1c2UKdGhlIGV4aXN0aW5nIHBhdGNoZXMgd2lsbCBjYXVzZSBj aGFuZ2VzIGFuZCBpbnZhbGlkYXRlIHRoZSByZXZpZXdzLgoKTm93IEkgaGF2ZSBtdWx0aXBsZSBk b3plbnMgb2YgZS1tYWlscyBpbiBteSBpbmJveCwgYW5kIHdlJ3JlIG5vdCBnb2luZwp0byBtYWtl IHByb2dyZXNzIHRoYXQgd2F5LiBNeSB1bmRlcnN0YW5kaW5nIGlzIHRoYXQgTWljaGFsJ3MgcGF0 Y2hlcyBvbgpiZXR0ZXIgb3JnYW5pemluZyB0aGUgR3VDIGNvZGUgYXJlIHRoZSBmaXJzdCBvbmVz LCBzbyBsZXRzIGZvY3VzIG9uCnRob3NlIGZpcnN0LiBTbyBsZXRzIGdldCBiYWNrIHRvIHRoaXMg c2VyaWVzIGFmdGVyIHdlJ3JlIGRvbmUgd2l0aCB0aGUKY29kZSBvcmdhbml6YXRpb24gc2FuaXRp emF0aW9uLgoKUmVnYXJkcywgSm9vbmFzCi0tIApKb29uYXMgTGFodGluZW4KT3BlbiBTb3VyY2Ug VGVjaG5vbG9neSBDZW50ZXIKSW50ZWwgQ29ycG9yYXRpb24KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==