From: Oscar Mateo <oscar.mateo@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v3 00/22] Refactor HW workaround code
Date: Fri, 13 Oct 2017 13:53:54 -0700 [thread overview]
Message-ID: <1507928056-6966-1-git-send-email-oscar.mateo@intel.com> (raw)
Main difference with v2 is the split into GT and Display workarounds (suggested
by Ville). Because that makes review even more important (which WA goes where?)
I have split the movement of WAs from init_clock_gating into separate patches
(one per GEN).
Currently, deciding how/where to apply new workarounds is challenging. Often,
workarounds end up applied incorrectly and get lost under certain circumstances
(e.g. a context switch or a GPU reset). This is a proposal to attempt to
eliminate some of this pain, by clarifying the current classification of
workarounds (context saved/restored, global registers, whitelisting, BB),
putting them together on the same file, and improving the existing validation
infrastructure (debugfs/i-g-t).
Oscar Mateo (22):
drm/i915: Use a mask when applying WaProgramL3SqcReg1Default
drm/i915: No need for RING_MAX_NONPRIV_SLOTS space
drm/i915: Move a bunch of workaround-related code to its own file
drm/i915: Split out functions for different kinds of workarounds
drm/i915: Rename saved workarounds to make it explicit that they are
context WAs
drm/i915: Save all GT WAs and apply them at a later time
drm/i915: Save all Whitelist WAs and apply them at a later time
drm/i915: Create a new category of display WAs
drm/i915: Print all workaround types correctly in debugfs
drm/i915: Move WA BB stuff to the workarounds file as well
drm/i915/cnl: Move GT and Display workarounds from init_clock_gating
drm/i915/gen9: Move GT and Display workarounds from init_clock_gating
drm/i915/gen9: Remove Gen9 WAs with no effect
drm/i915/cfl: Move GT and Display workarounds from init_clock_gating
drm/i915/glk: Move GT and Display workarounds from init_clock_gating
drm/i915/kbl: Move GT and Display workarounds from init_clock_gating
drm/i915/bxt: Move GT and Display workarounds from init_clock_gating
drm/i915/skl: Move GT and Display workarounds from init_clock_gating
drm/i915/chv: Move GT and Display workarounds from init_clock_gating
drm/i915/bdw: Move GT and Display workarounds from init_clock_gating
drm/i915: Move WaProgramL3SqcReg1Default to the workarounds file
drm/i915: Document the i915_workarounds file
drivers/gpu/drm/i915/Makefile | 3 +-
drivers/gpu/drm/i915/i915_debugfs.c | 57 +-
drivers/gpu/drm/i915/i915_drv.c | 5 +
drivers/gpu/drm/i915/i915_drv.h | 23 +-
drivers/gpu/drm/i915/i915_gem.c | 3 +
drivers/gpu/drm/i915/i915_gem_context.c | 5 +
drivers/gpu/drm/i915/i915_reg.h | 4 +-
drivers/gpu/drm/i915/intel_engine_cs.c | 679 -------------
drivers/gpu/drm/i915/intel_lrc.c | 266 +----
drivers/gpu/drm/i915/intel_pm.c | 309 +-----
drivers/gpu/drm/i915/intel_ringbuffer.c | 5 +-
drivers/gpu/drm/i915/intel_ringbuffer.h | 3 -
drivers/gpu/drm/i915/intel_workarounds.c | 1603 ++++++++++++++++++++++++++++++
drivers/gpu/drm/i915/intel_workarounds.h | 41 +
14 files changed, 1737 insertions(+), 1269 deletions(-)
create mode 100644 drivers/gpu/drm/i915/intel_workarounds.c
create mode 100644 drivers/gpu/drm/i915/intel_workarounds.h
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2017-10-13 20:54 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 20:53 Oscar Mateo [this message]
2017-10-13 20:53 ` [PATCH v3 01/22] drm/i915: Use a mask when applying WaProgramL3SqcReg1Default Oscar Mateo
2017-10-13 21:28 ` Chris Wilson
2017-10-14 0:26 ` Michel Thierry
2017-10-13 20:53 ` [PATCH v3 02/22] drm/i915: No need for RING_MAX_NONPRIV_SLOTS space Oscar Mateo
2017-10-13 20:53 ` [PATCH v3 03/22] drm/i915: Move a bunch of workaround-related code to its own file Oscar Mateo
2017-10-13 20:53 ` [PATCH v3 04/22] drm/i915: Split out functions for different kinds of workarounds Oscar Mateo
2017-10-13 20:53 ` [PATCH v3 05/22] drm/i915: Rename saved workarounds to make it explicit that they are context WAs Oscar Mateo
2017-10-13 20:54 ` [PATCH v3 06/22] drm/i915: Save all GT WAs and apply them at a later time Oscar Mateo
2017-10-17 12:37 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 07/22] drm/i915: Save all Whitelist " Oscar Mateo
2017-10-17 12:38 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 08/22] drm/i915: Create a new category of display WAs Oscar Mateo
2017-10-17 12:42 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 09/22] drm/i915: Print all workaround types correctly in debugfs Oscar Mateo
2017-10-17 12:45 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 10/22] drm/i915: Move WA BB stuff to the workarounds file as well Oscar Mateo
2017-10-17 12:49 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 11/22] drm/i915/cnl: Move GT and Display workarounds from init_clock_gating Oscar Mateo
2017-10-17 12:52 ` Chris Wilson
2017-10-17 21:22 ` Oscar Mateo
2017-10-18 12:44 ` Ville Syrjälä
2017-10-30 20:05 ` Oscar Mateo
2017-10-13 20:54 ` [PATCH v3 12/22] drm/i915/gen9: " Oscar Mateo
2017-10-17 12:53 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 13/22] drm/i915/gen9: Remove Gen9 WAs with no effect Oscar Mateo
2017-10-13 20:54 ` [PATCH v3 14/22] drm/i915/cfl: Move GT and Display workarounds from init_clock_gating Oscar Mateo
2017-10-17 12:54 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 15/22] drm/i915/glk: " Oscar Mateo
2017-10-17 12:57 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 16/22] drm/i915/kbl: " Oscar Mateo
2017-10-17 12:58 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 17/22] drm/i915/bxt: " Oscar Mateo
2017-10-17 12:58 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 18/22] drm/i915/skl: " Oscar Mateo
2017-10-17 12:59 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 19/22] drm/i915/chv: " Oscar Mateo
2017-10-17 13:02 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 20/22] drm/i915/bdw: " Oscar Mateo
2017-10-17 13:03 ` Chris Wilson
2017-10-30 20:08 ` Oscar Mateo
2017-10-13 20:54 ` [PATCH v3 21/22] drm/i915: Move WaProgramL3SqcReg1Default to the workarounds file Oscar Mateo
2017-10-17 13:05 ` Chris Wilson
2017-10-13 20:54 ` [PATCH v3 22/22] drm/i915: Document the i915_workarounds file Oscar Mateo
2017-10-13 21:48 ` ✗ Fi.CI.BAT: failure for Refactor HW workaround code (rev3) Patchwork
2017-10-17 13:06 ` [PATCH v3 00/22] Refactor HW workaround code Chris Wilson
2017-10-30 20:07 ` Oscar Mateo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507928056-6966-1-git-send-email-oscar.mateo@intel.com \
--to=oscar.mateo@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox