From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Tomi Sarvela <tomi.p.sarvela@intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Add -Wall -Wextra to our build, set warnings to full
Date: Mon, 16 Oct 2017 13:13:28 +0300 [thread overview]
Message-ID: <1508148808.5300.10.camel@linux.intel.com> (raw)
In-Reply-To: <20171014101250.10367-1-chris@chris-wilson.co.uk>
On Sat, 2017-10-14 at 11:12 +0100, Chris Wilson wrote:
> Recently W=1 on gcc-7.2 (-Wunused-const-variable) caught a regression
> that had been lurking for 6 months, so lets try enabling the full set of
> warnings for CI builds. This means more patches will be rejected early
> that contain trivial and sometimes not so trivial bugs. However, our
> code does not yet compile cleanly with W=1, so we have to apply a filter
> to the set of warnings until we can eliminate the mistakes. It also
> means that developers will have to be running the full gamut of gcc to
> ensure that as warnings come and go with gcc updates, we have the CI
> build prepared.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> Cc: Micahal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
The first portion (this patch) I can easily agree on. I'm not so sure
about the #pragma stuff to move the information to source files. It
sounds like making better use of the compiler warnings, but would we
maybe want to isolate at file level the ones that have the exemption?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-10-16 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 10:12 [PATCH 1/2] drm/i915: Add -Wall -Wextra to our build, set warnings to full Chris Wilson
2017-10-14 10:12 ` [PATCH 2/2] drm/i915: Remove -Wno-override-init Chris Wilson
2017-10-14 20:02 ` Michal Wajdeczko
2017-10-15 20:53 ` Chris Wilson
2017-10-14 10:35 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Add -Wall -Wextra to our build, set warnings to full Patchwork
2017-10-14 11:39 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-10-16 10:13 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508148808.5300.10.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=tomi.p.sarvela@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox