From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Report -EFAULT before pwrite fast path into shmemfs
Date: Tue, 17 Oct 2017 10:03:57 +0300 [thread overview]
Message-ID: <1508223837.4313.5.camel@linux.intel.com> (raw)
In-Reply-To: <20171016202732.25459-1-chris@chris-wilson.co.uk>
On Mon, 2017-10-16 at 21:27 +0100, Chris Wilson wrote:
> When pwriting into shmemfs, the fast path pagecache_write does not
> notice when it is writing to beyond the end of the truncated shmemfs
> inode. Report -EFAULT directly when we try to use pwrite into the
> !I915_MADV_WILLNEED object.
>
> Fixes: 7c55e2c5772d ("drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl")
> Testcase: igt/gem_madvise/dontneed-before-pwrite
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.william.auld@gmail.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-17 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 20:27 [PATCH] drm/i915: Report -EFAULT before pwrite fast path into shmemfs Chris Wilson
2017-10-16 20:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-17 7:03 ` Joonas Lahtinen [this message]
2017-10-17 13:08 ` [PATCH] " Chris Wilson
2017-10-17 12:47 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508223837.4313.5.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox