* [PATCH] drm/i915: Mention which driver is taking over the VGA console
@ 2017-10-27 21:33 Chris Wilson
2017-10-27 22:30 ` ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2017-10-27 21:33 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
Currently there is a rather bland,
[ 4.987589] [drm] Replacing VGA console driver
for when we take over the console. Let's put a (device) name on that.
If we opt for DRM_DEV_INFO we get
[ 5.071879] i915 0000:00:02.0: [drm:i915_kick_out_vgacon] Replacing VGA console driver
which is a little ugly side for a user message. So just use a plain
dev_info() instead:
[ 4.948501] i915 0000:00:02.0: Replacing VGA console driver
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index af745749509c..c194dfa11125 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -751,7 +751,7 @@ static int i915_kick_out_vgacon(struct drm_i915_private *dev_priv)
{
int ret = 0;
- DRM_INFO("Replacing VGA console driver\n");
+ dev_info(dev_priv->drm.dev, "Replacing VGA console driver\n");
console_lock();
if (con_is_bound(&vga_con))
--
2.15.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Mention which driver is taking over the VGA console
2017-10-27 21:33 [PATCH] drm/i915: Mention which driver is taking over the VGA console Chris Wilson
@ 2017-10-27 22:30 ` Patchwork
2017-10-27 23:39 ` ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-27 22:30 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Mention which driver is taking over the VGA console
URL : https://patchwork.freedesktop.org/series/32791/
State : success
== Summary ==
Series 32791v1 drm/i915: Mention which driver is taking over the VGA console
https://patchwork.freedesktop.org/api/1.0/series/32791/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:447s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:454s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:379s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:534s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:266s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:498s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:494s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:492s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:481s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:601s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:423s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:248s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:578s
fi-glk-dsi total:289 pass:258 dwarn:0 dfail:0 fail:1 skip:30 time:495s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:424s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:434s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:423s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:500s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:463s
fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:479s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:578s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:479s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:587s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:541s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:454s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:591s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:644s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:522s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:498s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:456s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:559s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:423s
d0582552491e17f5e386747f82147c1f2d9158c9 drm-tip: 2017y-10m-27d-19h-16m-21s UTC integration manifest
b43ff55309e4 drm/i915: Mention which driver is taking over the VGA console
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6253/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Mention which driver is taking over the VGA console
2017-10-27 21:33 [PATCH] drm/i915: Mention which driver is taking over the VGA console Chris Wilson
2017-10-27 22:30 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-27 23:39 ` Patchwork
2017-10-30 8:39 ` [PATCH] " Tvrtko Ursulin
2017-10-30 12:40 ` Joonas Lahtinen
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-27 23:39 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Mention which driver is taking over the VGA console
URL : https://patchwork.freedesktop.org/series/32791/
State : success
== Summary ==
Test perf:
Subgroup oa-exponents:
fail -> PASS (shard-hsw) fdo#102254
Test kms_flip:
Subgroup rcs-wf_vblank-vs-modeset-interruptible:
pass -> DMESG-WARN (shard-hsw) fdo#102614
Subgroup modeset-vs-vblank-race-interruptible:
fail -> PASS (shard-hsw) fdo#103060
Test kms_busy:
Subgroup extended-modeset-hang-newfb-with-reset-render-C:
pass -> DMESG-WARN (shard-hsw) fdo#102249
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
shard-hsw total:2539 pass:1431 dwarn:2 dfail:0 fail:8 skip:1098 time:9202s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6253/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Mention which driver is taking over the VGA console
2017-10-27 21:33 [PATCH] drm/i915: Mention which driver is taking over the VGA console Chris Wilson
2017-10-27 22:30 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-27 23:39 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-10-30 8:39 ` Tvrtko Ursulin
2017-10-30 12:40 ` Joonas Lahtinen
3 siblings, 0 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2017-10-30 8:39 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Daniel Vetter
On 27/10/2017 22:33, Chris Wilson wrote:
> Currently there is a rather bland,
>
> [ 4.987589] [drm] Replacing VGA console driver
I had some patches which replaced this with [i915], but then Robert
Bragg had some even better patches to improve the DRM logging in
general. It might be best to resurrect those rather than use different
logging APIs throughput the code depending on the desired output?
Regards,
Tvrtko
> for when we take over the console. Let's put a (device) name on that.
> If we opt for DRM_DEV_INFO we get
>
> [ 5.071879] i915 0000:00:02.0: [drm:i915_kick_out_vgacon] Replacing VGA console driver
>
> which is a little ugly side for a user message. So just use a plain
> dev_info() instead:
>
> [ 4.948501] i915 0000:00:02.0: Replacing VGA console driver
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index af745749509c..c194dfa11125 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -751,7 +751,7 @@ static int i915_kick_out_vgacon(struct drm_i915_private *dev_priv)
> {
> int ret = 0;
>
> - DRM_INFO("Replacing VGA console driver\n");
> + dev_info(dev_priv->drm.dev, "Replacing VGA console driver\n");
>
> console_lock();
> if (con_is_bound(&vga_con))
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Mention which driver is taking over the VGA console
2017-10-27 21:33 [PATCH] drm/i915: Mention which driver is taking over the VGA console Chris Wilson
` (2 preceding siblings ...)
2017-10-30 8:39 ` [PATCH] " Tvrtko Ursulin
@ 2017-10-30 12:40 ` Joonas Lahtinen
3 siblings, 0 replies; 5+ messages in thread
From: Joonas Lahtinen @ 2017-10-30 12:40 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Daniel Vetter
On Fri, 2017-10-27 at 22:33 +0100, Chris Wilson wrote:
> Currently there is a rather bland,
>
> [ 4.987589] [drm] Replacing VGA console driver
>
> for when we take over the console. Let's put a (device) name on that.
> If we opt for DRM_DEV_INFO we get
>
> [ 5.071879] i915 0000:00:02.0: [drm:i915_kick_out_vgacon] Replacing VGA console driver
>
> which is a little ugly side for a user message. So just use a plain
> dev_info() instead:
>
> [ 4.948501] i915 0000:00:02.0: Replacing VGA console driver
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Makes sense to me.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-30 12:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-27 21:33 [PATCH] drm/i915: Mention which driver is taking over the VGA console Chris Wilson
2017-10-27 22:30 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-27 23:39 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-30 8:39 ` [PATCH] " Tvrtko Ursulin
2017-10-30 12:40 ` Joonas Lahtinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox