From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Remove i915.enable_execlists module parameter
Date: Mon, 30 Oct 2017 14:51:10 +0200 [thread overview]
Message-ID: <1509367870.4757.3.camel@linux.intel.com> (raw)
In-Reply-To: <20171026211711.24023-1-chris@chris-wilson.co.uk>
On Thu, 2017-10-26 at 22:17 +0100, Chris Wilson wrote:
> Execlists and legacy ringbuffer submission are no longer feature
> comparable (execlists now offer greater functionality that should
> overcome their performance hit) and obsoletes the unsafe module
> parameter, i.e. comparing the two modes of execution is no longer
> useful, so remove the debug tool.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Could use some more acks here. To me, the module parameters seem to be
facing some abuse, so dropping makes sense especially as the features
are not comparable, and code is bound to be rotting.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-30 12:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 21:17 [PATCH 1/2] drm/i915: Remove i915.enable_execlists module parameter Chris Wilson
2017-10-26 21:17 ` [PATCH 2/2] drm/i915: Remove obsolete ringbuffer emission for gen8+ Chris Wilson
2017-10-26 21:41 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Remove i915.enable_execlists module parameter Patchwork
2017-10-30 12:51 ` Joonas Lahtinen [this message]
2017-10-31 17:18 ` [PATCH 1/2] " Lionel Landwerlin
-- strict thread matches above, loose matches on Subject: below --
2017-03-24 9:42 Chris Wilson
2017-03-27 12:54 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509367870.4757.3.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox