From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Oscar Mateo <oscar.mateo@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 05/20] drm/i915: Save all GT WAs and apply them at a later time
Date: Tue, 31 Oct 2017 16:14:52 +0200 [thread overview]
Message-ID: <1509459292.7795.37.camel@linux.intel.com> (raw)
In-Reply-To: <1509394647-23209-6-git-send-email-oscar.mateo@intel.com>
On Mon, 2017-10-30 at 13:17 -0700, Oscar Mateo wrote:
> By doing this, we can dump these workarounds in debugfs for validation (which,
> at the moment, we are only able to do for the contexts WAs).
>
> v2:
> - Wrong macro used for MMIO set bit masked
> - Improved naming
> - Rebased
>
> v3:
> - GT instead of MMIO (Chris, Mika)
> - Leave L3_PRIO_CREDITS_MASK for a separate patch
> - Rebased
>
> v4: Carry the init_early nomenclature over (Chris)
>
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
This and the following patch are still a no-go and won't be merged. The
required changes for the series to be accepted (to make it more
declarative) were clearly described previously. If there are further
questions, we should discuss those instead wasting time looking at
respins that do not address the input given.
Respins that ignore review are a waste of everyone's time. So, please
react to the review instead of trying to brute force a series in as you
see fit.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-31 14:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 20:17 [PATCH v4 00/20] Refactor HW workaround code Oscar Mateo
2017-10-30 20:17 ` [PATCH 01/20] drm/i915: Remove Gen9 WAs with no effect Oscar Mateo
2017-10-30 20:17 ` [PATCH 02/20] drm/i915: Move a bunch of workaround-related code to its own file Oscar Mateo
2017-10-30 20:17 ` [PATCH 03/20] drm/i915: Split out functions for different kinds of workarounds Oscar Mateo
2017-10-30 20:17 ` [PATCH 04/20] drm/i915: Rename saved workarounds to make it explicit that they are context WAs Oscar Mateo
2017-10-30 20:17 ` [PATCH 05/20] drm/i915: Save all GT WAs and apply them at a later time Oscar Mateo
2017-10-31 14:14 ` Joonas Lahtinen [this message]
2017-10-31 16:30 ` Oscar Mateo
2017-11-01 10:46 ` David Weinehall
2017-11-03 2:31 ` Chris Wilson
2017-10-30 20:17 ` [PATCH 06/20] drm/i915: Save all Whitelist " Oscar Mateo
2017-10-30 20:17 ` [PATCH 07/20] drm/i915: Create a new category of display WAs Oscar Mateo
2017-10-30 20:17 ` [PATCH 08/20] drm/i915: Print all workaround types correctly in debugfs Oscar Mateo
2017-10-30 20:17 ` [PATCH 09/20] drm/i915: Move WA BB stuff to the workarounds file as well Oscar Mateo
2017-10-30 20:17 ` [PATCH 10/20] drm/i915/cnl: Move GT and Display workarounds from init_clock_gating Oscar Mateo
2017-10-30 20:17 ` [PATCH 11/20] drm/i915/gen9: " Oscar Mateo
2017-10-30 20:17 ` [PATCH 12/20] drm/i915/cfl: " Oscar Mateo
2017-10-30 20:17 ` [PATCH 13/20] drm/i915/glk: " Oscar Mateo
2017-10-30 20:17 ` [PATCH 14/20] drm/i915/kbl: " Oscar Mateo
2017-10-30 20:17 ` [PATCH 15/20] drm/i915/bxt: " Oscar Mateo
2017-10-30 20:17 ` [PATCH 16/20] drm/i915/skl: " Oscar Mateo
2017-10-30 20:17 ` [PATCH 17/20] drm/i915/chv: " Oscar Mateo
2017-10-30 20:17 ` [PATCH 18/20] drm/i915/bdw: " Oscar Mateo
2017-10-30 20:17 ` [PATCH 19/20] drm/i915: Move WaProgramL3SqcReg1Default to the workarounds file Oscar Mateo
2017-10-30 20:17 ` [PATCH 20/20] drm/i915: Document the i915_workarounds file Oscar Mateo
2017-10-30 20:42 ` ✗ Fi.CI.BAT: warning for Refactor HW workaround code (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509459292.7795.37.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=oscar.mateo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox