From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [Intel-gfx] [PATCH] i965: Revert absolute mode for constant buffer pointers. Date: Fri, 03 Nov 2017 14:21:50 +0200 Message-ID: <1509711710.4545.55.camel@linux.intel.com> References: <20171019231820.28804-1-kenneth@whitecape.org> <1508936709.13538.20.camel@linux.intel.com> <15f53f40188.27ad.c6988b7ea6112e3e892765a0d4287e0c@jlekstrand.net> <1658792.UsjMHgzv3d@kirito> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: mesa-dev-bounces@lists.freedesktop.org Sender: "mesa-dev" To: Jason Ekstrand , Kenneth Graunke Cc: Daniel Vetter , Intel GFX , Kristian =?ISO-8859-1?Q?H=F8gsberg?= , Rodrigo Vivi , "mesa-dev@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org SGksCgpBZnRlciBzb21lIGJyYWluc3Rvcm1pbmcsIHdlIGRlY2lkZWQgdG8gZ28gYmlnIGFuZCBn cmFiIGFsbCB0aGUKaGFyZHdhcmUgcHJvdmlkZWQgZGVmYXVsdHMgZm9yIGFsbCByZWdpc3RlcnMu IFRoYXQncyBmb3IgdGhlIHNha2Ugb2YKbm90IGhhdmluZyB0byBkZWNpZGUgd2hpY2ggcmVnaXN0 ZXJzIGFyZSBpbXBvcnRhbnQuCgpUaGlzIHdpbGwgYWxzbyBhbGxvdyB1cyBub3QgdG8gYmUgY29u Y2VybmVkIG9mIGFueSBjb250ZXh0IHJlZ2lzdGVycwpwb3NzaWJseSBjb250YWluaW5nICdzZWN1 cmUnIGluZm9ybWF0aW9uIHRvIGJlIGxlYWtlZCwgd2hpY2ggd2UKY3VycmVudGx5IGRvbid0IGV4 cGVjdCBmcm9tIGFueSBrbm93biB1c2Vyc3BhY2UuIEJ1dCB5b3UgbmV2ZXIga25vdwp3aGF0IHNv bWVib2R5IGNvdWxkIGJlIGRvaW5nIHdpdGggdW51c2VkLWZvci10aGVtIHJlZ2lzdGVycyA6KQoK VGhlIGZpeCBpcyBub3QgcXVpdGUgc3RhYmxlIG1hdGVyaWFsLCBjb250YWluaW5nIGNoYW5nZXMg dG8gdGhlCmhhcmR3YXJlIGluaXRpYWxpemF0aW9uIG9yZGVyaW5nIGFuZCBiZWluZyByYXRoZXIg aW52YXNpdmUgaW4gbmF0dXJlLgoKV2UncmUgY3VycmVudGx5IGRpc2N1c3NpbmcgdGhlIHVBUEkg dG8gZXhwb3NlIHRvIHVzZXJzcGFjZSwgcGxlYXNlIHN0YXkKdHVuZWQuIEl0J2xsIGxpa2VseSBi ZSBhIGJpdG1hc2sgb2YgZW5naW5lIGNsYXNzZXMsIHdoaWNoIHdpbGwgc2hvcnRseQpiZSBpbnRy b2R1Y2VkIGZyb20gdGhlIFBNVSB3b3JrLgoKUmVnYXJkcywgSm9vbmFzCgpPbiBXZWQsIDIwMTct MTAtMjUgYXQgMTA6NTMgLTA3MDAsIEphc29uIEVrc3RyYW5kIHdyb3RlOgo+IE9uIFdlZCwgT2N0 IDI1LCAyMDE3IGF0IDEwOjMxIEFNLCBLZW5uZXRoIEdyYXVua2UgPGtlbm5ldGhAd2hpdGVjYXBl Lm9yZz4gd3JvdGU6Cj4gPiBPbiBXZWRuZXNkYXksIE9jdG9iZXIgMjUsIDIwMTcgNzozMzo0MSBB TSBQRFQgSmFzb24gRWtzdHJhbmQgd3JvdGU6Cj4gPiA+IE9uIE9jdG9iZXIgMjUsIDIwMTcgMDY6 MDU6MTYgSm9vbmFzIExhaHRpbmVuIHdyb3RlOgo+ID4gW3NuaXBdCj4gPiA+ID4gVGhlcmUgaW5k ZWVkIHNlZW1zIHRvIGJlIHF1aXRlIGEgbG90IG9mIG1pc3NpbmcgcmVnaXN0ZXJzIGZyb20gdGhl IGk5MTUKPiA+ID4gPiBkcml2ZXIgd2hlcmUgdGhlIGNvbnRleHQgaXMgaW5pdGlhbGl6ZWQuIChQ c3N0LiBZb3UgY2FuIHJlYWQgdGhhdCBhczoKPiA+ID4gPiAiYWxsIHRoZSAzMyBub24tcHJpdmls ZWdlZCByZWdpc3RlcnMgd2UgY291bGQgcXVpY2tseSBsaXN0LCBhcmUKPiA+ID4gPiBtaXNzaW5n IikuCj4gPiA+Cj4gPiA+IFdlIHByb2JhYmx5IGRvbid0IG5lZWQgKmFsbCogb2YgdGhlbSBpbml0 aWFsaXplZC4gIEZvciBpbnN0YW5jZSwgdGhlCj4gPiA+IGluaXRpYWwgdmFsdWVzIG9mIHRoZSBB TFUgcmVnaXN0ZXJzIG9yIHRoZSBpbmRpcmVjdCBkcmF3IHBhcmFtZXRlcgo+ID4gPiByZWdpc3Rl cnMgd2lsbCBwcm9iYWJseSBuZXZlciBtYXR0ZXIuICBIb3dldmVyLCBpZiB5b3Ugd2FudCB0byBq dXN0Cj4gPiA+IGluaXRpYWxpemVkIHRoZW0gYWxsLCB0aGF0J3MgZmluZS4KPiA+IAo+ID4gSSBh Z3JlZSAtIEkgdGhpbmsgd2UgY2FuIGN1dCBkb3duIHRoZSBsaXN0IHN1YnN0YW50aWFsbHksIGlm IHlvdSBsaWtlLgo+ID4gSGVyZSdzIG15IGJyZWFrZG93biBvZiBTa3lsYWtlJ3Mgbm9uLXByaXZp bGVnZWQgcmVnaXN0ZXIgbGlzdDoKPiA+IAo+ID4gQ2FjaGVfTW9kZV8wICAgICAgICAgICAgICAg MHg3MDAwCj4gPiBDYWNoZV9Nb2RlXzEgICAgICAgICAgICAgICAweDcwMDQKPiA+IEdUX01PREUg ICAgICAgICAgICAgICAgICAgIDB4NzAwOAo+ID4gTDNfQ29uZmlnICAgICAgICAgICAgICAgICAg MHg3MDM0Cj4gPiBURF9DVEwgICAgICAgICAgICAgICAgICAgICAweEU0MDAKPiA+IFREX0NUTDIg ICAgICAgICAgICAgICAgICAgIDB4RTQwNAo+ID4gTDNTUUNSRUc0ICAgICAgICAgICAgICAgICAg MHhCMTE4Cj4gPiBOT1BJRCAgICAgICAgICAgICAgICAgICAgICAweDIwOTQKPiA+IElOU1RQTSAg ICAgICAgICAgICAgICAgICAgIDB4MjBDMAo+ID4gCj4gPiAgICBTaG91bGQgYmUgaW5pdGlhbGl6 ZWQgYnkgdGhlIGtlcm5lbC4gIFNldmVyYWwgb2YgdGhlc2UgY2FuIHNldmVyZWx5Cj4gPiAgICBi cmVhayB1bnN1c3BlY3RpbmcgdXNlcnNwYWNlLCBhbmQgd2UnZCBsaWtlIHRvIGJlIGFibGUgdG8g cmVseSBvbiBhCj4gPiAgICBkZWZhdWx0IHZhbHVlLgo+ID4gCj4gPiBJQV9WRVJUSUNFU19DT1VO VCAgICAgICAgICAweDIzMTAKPiA+IElBX1BSSU1JVElWRVNfQ09VTlQgICAgICAgIDB4MjMxOAo+ ID4gVlNfSU5WT0NBVElPTl9DT1VOVCAgICAgICAgMHgyMzIwCj4gPiBIU19JTlZPQ0FUSU9OX0NP VU5UICAgICAgICAweDIzMDAKPiA+IERTX0lOVk9DQVRJT05fQ09VTlQgICAgICAgIDB4MjMwOAo+ ID4gR1NfSU5WT0NBVElPTl9DT1VOVCAgICAgICAgMHgyMzI4Cj4gPiBHU19QUklNSVRJVkVTX0NP VU5UICAgICAgICAweDIzMzAKPiA+IFNPX05VTV9QUklNU19XUklUVEVOMCAgICAgIDB4NTIwMAo+ ID4gU09fTlVNX1BSSU1TX1dSSVRURU4xICAgICAgMHg1MjA4Cj4gPiBTT19OVU1fUFJJTVNfV1JJ VFRFTjIgICAgICAweDUyMTAKPiA+IFNPX05VTV9QUklNU19XUklUVEVOMyAgICAgIDB4NTIxOAo+ ID4gU09fUFJJTV9TVE9SQUdFX05FRURFRDAgICAgMHg1MjQwCj4gPiBTT19QUklNX1NUT1JBR0Vf TkVFREVEMSAgICAweDUyNDgKPiA+IFNPX1BSSU1fU1RPUkFHRV9ORUVERUQyICAgIDB4NTI1MAo+ ID4gU09fUFJJTV9TVE9SQUdFX05FRURFRDMgICAgMHg1MjU4Cj4gPiBDTF9JTlZPQ0FUSU9OX0NP VU5UICAgICAgICAweDIzMzgKPiA+IENMX1BSSU1JVElWRVNfQ09VTlQgICAgICAgIDB4MjM0MAo+ ID4gUFNfSU5WT0NBVElPTl9DT1VOVF8wICAgICAgMHgyMkM4Cj4gPiBQU19ERVBUSF9DT1VOVF8w ICAgICAgICAgICAweDIyRDgKPiA+IFBTX0lOVk9DQVRJT05fQ09VTlRfMSAgICAgIDB4MjJGMAo+ ID4gUFNfREVQVEhfQ09VTlRfMSAgICAgICAgICAgMHgyMkY4Cj4gPiBQU19JTlZPQ0FUSU9OX0NP VU5UXzIgICAgICAweDI0NDgKPiA+IFBTX0RFUFRIX0NPVU5UXzIgICAgICAgICAgIDB4MjQ1MAo+ ID4gR1BHUFVfVEhSRUFEU19ESVNQQVRDSEVEICAgMHgyMjkwCj4gPiAKPiA+ICAgIFRoZSBrZXJu ZWwgY2FuIHNraXAgdGhlc2UgaWYgeW91IGxpa2UuICBTdGF0aXN0aWNzIHJlZ2lzdGVycyBqdXN0 IGNvdW50Cj4gPiAgICB0aGluZ3MsIGFuZCB1c2Vyc3BhY2UgYWx3YXlzIGNhbGN1bGF0ZXMgKGVu ZCBjb3VudGVyIC0gc3RhcnQgY291bnRlcikKPiA+ICAgIGRlbHRhcywgc28gdGhlIGluaXRpYWwg dmFsdWUgZG9lc24ndCByZWFsbHkgbWF0dGVyLgo+ID4gCj4gPiBTT19XUklURV9PRkZTRVQwICAg ICAgICAgICAweDUyODAKPiA+IFNPX1dSSVRFX09GRlNFVDEgICAgICAgICAgIDB4NTI4NAo+ID4g U09fV1JJVEVfT0ZGU0VUMiAgICAgICAgICAgMHg1Mjg4Cj4gPiBTT19XUklURV9PRkZTRVQzICAg ICAgICAgICAweDUyOEMKPiA+IEdQVUdQVV9ESVNQQVRDSERJTVggICAgICAgIDB4MjUwMAo+ID4g R1BVR1BVX0RJU1BBVENIRElNWSAgICAgICAgMHgyNTA0Cj4gPiBHUFVHUFVfRElTUEFUQ0hESU1a ICAgICAgICAweDI1MDgKPiA+IE1JX1BSRURJQ0FURV9TUkMwICAgICAgICAgIDB4MjQwMAo+ID4g TUlfUFJFRElDQVRFX1NSQzAgICAgICAgICAgMHgyNDA0Cj4gPiBNSV9QUkVESUNBVEVfU1JDMSAg ICAgICAgICAweDI0MDgKPiA+IE1JX1BSRURJQ0FURV9TUkMxICAgICAgICAgIDB4MjQwQwo+ID4g TUlfUFJFRElDQVRFX0RBVEEgICAgICAgICAgMHgyNDEwCj4gPiBNSV9QUkVESUNBVEVfREFUQSAg ICAgICAgICAweDI0MTQKPiA+IE1JX1BSRURJQ0FURV9SRVNVTFQgICAgICAgIDB4MjQxOAo+ID4g TUlfUFJFRElDQVRFX1JFU1VMVF8xICAgICAgMHgyNDFDCj4gPiBNSV9QUkVESUNBVEVfUkVTVUxU XzIgICAgICAweDIzQkMKPiA+IDNEUFJJTV9FTkRfT0ZGU0VUICAgICAgICAgIDB4MjQyMAo+ID4g M0RQUklNX1NUQVJUX1ZFUlRFWCAgICAgICAgMHgyNDMwCj4gPiAzRFBSSU1fVkVSVEVYX0NPVU5U ICAgICAgICAweDI0MzQKPiA+IDNEUFJJTV9JTlNUQU5DRV9DT1VOVCAgICAgIDB4MjQzOAo+ID4g M0RQUklNX1NUQVJUX0lOU1RBTkNFICAgICAgMHgyNDNDCj4gPiAzRFBSSU1fQkFTRV9WRVJURVgg ICAgICAgICAweDI0NDAKPiA+IAo+ID4gICAgVGhlIGtlcm5lbCBjYW4gc2tpcCB0aGVzZSBpZiB5 b3UgbGlrZSwgSU1PLiAgVGhlc2UgcmVnaXN0ZXJzIGFyZSBvbmx5Cj4gPiAgICB1c2VkIHdoZW4g ZW5hYmxpbmcgYW4gb3B0aW9uYWwgZmVhdHVyZSAtIHN0cmVhbSBvdXQgKFNPX1dSSVRFXyopLAo+ ID4gICAgaW5kaXJlY3QgY29tcHV0ZSBkaXNwYXRjaCAoR1BHUFVfKiksIHByZWRpY2F0ZWQgZHJh d3MgKE1JX1BSRURJQ0FURV8qKSwKPiA+ICAgIGluZGlyZWN0IGRyYXdzICgzRFBSSU1fKikuICBV c2Vyc3BhY2UgaGFzIHRvIGV4cGxpY2l0bHkgb3B0IGluIHRvIGVhY2gKPiA+ICAgIG9mIHRoZXNl IGZlYXR1cmVzIGJ5IGVuYWJsaW5nIGEgZmxhZywgc28gdGhlcmUgaXNuJ3QgYSBjcm9zcy1jb250 ZXh0Cj4gPiAgICBjb250YW1pbmF0aW9uIHByb2JsZW0uICBJZiB1c2Vyc3BhY2Ugb3B0cyBpbiB0 byB0aGVzZSBmZWF0dXJlcywgaXQgY2FuCj4gPiAgICBiZSByZXNwb25zaWJsZSBmb3IgcHJvZ3Jh bW1pbmcgdGhlIHJlZ2lzdGVycyBjb3JyZWN0bHkuCj4gPiAKPiA+IENTX0dQUiAoMS0xNikgICAg ICAgICAgICAgIDB4MjYwMAo+ID4gCj4gPiAgICBUaGUga2VybmVsIGNhbiBza2lwIHRoZXNlIGlm IHlvdSBsaWtlLiAgVGhleSdyZSB0ZW1wb3Jhcnkgc3RvcmFnZSB3aGVuCj4gPiAgICB1c2luZyB0 aGUgTUlfTUFUSCBpbnN0cnVjdGlvbi4gIEV4YW1wbGUgdXNhZ2U6IGxvYWQgdmFsdWVzIGludG8g Q1NfR1BSMQo+ID4gICAgYW5kIENTX0dQUjIsIGFkZCB0aGVtLCBzdG9yZSB0aGUgcmVzdWx0IGlu IENTX0dQUjMuICBTdG9yZSB0byBtZW1vcnkuCj4gPiAKPiA+ICAgIE5vYm9keSBzaG91bGQgYmUg ZG9pbmcgbWF0aCBvbiByZWdpc3RlciB2YWx1ZXMgd2l0aG91dCBzZXR0aW5nIHRoZW0uCj4gPiAg ICBUaGF0J3MgY2xlYXJseSBhIHVzZXJzcGFjZSBidWcuCj4gPiAKPiA+IEJCX09GRlNFVCAgICAg ICAgICAgICAgICAgIDB4MjE1OAo+IAo+IFRoaXMgaXMgdXNlZCBmb3IgaW5kaXJlY3QgQkFUQ0hf QlVGRkVSX1NUQVJUIHdoaWNoIGlzIGEgdGhpbmcgb24gU0tMKyBJIGJlbGlldmUgKEkgZGlkbid0 IGxvb2sgYXQgdGhlIGRvY3MpLgo+ICAKPiA+IE9BX0NUWF9DT05UUk9MICAgICAgICAgICAgIDB4 MjM2MAo+ID4gT0FDVFhJRCAgICAgICAgICAgICAgICAgICAgMHgyMzY0Cj4gPiBPQSBDT05UUk9M ICAgICAgICAgICAgICAgICAweDJCMDAKPiA+IFBFUkZfQ05UXzFfRFcwICAgICAgICAgICAgIDB4 OTFiOAo+ID4gUEVSRl9DTlRfMV9EVzEgICAgICAgICAgICAgMHg5MWJjCj4gPiBQRVJGX0NOVF8y X0RXMCAgICAgICAgICAgICAweDkxYzAKPiA+IFBFUkZfQ05UXzJfRFcxICAgICAgICAgICAgIDB4 OTFjNAo+ID4gCj4gPiAgICBJIGRvbid0IGtub3cgYWJvdXQgdGhlc2UuCj4gCj4gCi0tIApKb29u YXMgTGFodGluZW4KT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKSW50ZWwgQ29ycG9yYXRp b24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbWVzYS1k ZXYgbWFpbGluZyBsaXN0Cm1lc2EtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL21lc2EtZGV2Cg==