* [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error
@ 2017-10-30 17:54 Gabriel Krisman Bertazi
2017-10-30 18:23 ` ✓ Fi.CI.BAT: success for tests/kms_fbcon_fbt: Report fbc_status on error (rev3) Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Gabriel Krisman Bertazi @ 2017-10-30 17:54 UTC (permalink / raw)
To: intel-gfx; +Cc: paulo.r.zanoni
knowing the assertion triggered on wait_until_enabled() is not that
useful without knowing what exactly caused the failure. It might be an
user error, like too little stolen memory by the bios, or an actual
issue in the kernel. So, let's make life easier, particularly for the
CI, by printing the status before failing out.
Case in point:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101718
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
---
tests/kms_fbcon_fbt.c | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
index d0090912694e..8371be5612f5 100644
--- a/tests/kms_fbcon_fbt.c
+++ b/tests/kms_fbcon_fbt.c
@@ -95,6 +95,14 @@ static bool connector_can_fbc(drmModeConnectorPtr connector)
return true;
}
+static void fbc_print_status(int fd)
+{
+ static char buf[128];
+
+ igt_debugfs_read(fd, "i915_fbc_status", buf);
+ igt_debug("FBC status: %s\n", buf);
+}
+
static bool fbc_is_enabled(int fd)
{
char buf[128];
@@ -105,7 +113,9 @@ static bool fbc_is_enabled(int fd)
static bool fbc_wait_until_enabled(int fd)
{
- return igt_wait(fbc_is_enabled(fd), 5000, 1);
+ bool r = igt_wait(fbc_is_enabled(fd), 5000, 1);
+ fbc_print_status(fd);
+ return r;
}
typedef bool (*connector_possible_fn)(drmModeConnectorPtr connector);
@@ -160,6 +170,14 @@ static bool connector_can_psr(drmModeConnectorPtr connector)
return (connector->connector_type == DRM_MODE_CONNECTOR_eDP);
}
+static void psr_print_status(int fd)
+{
+ static char buf[256];
+
+ igt_debugfs_read(fd, "i915_edp_psr_status", buf);
+ igt_debug("FBC status: %s\n", buf);
+}
+
static bool psr_is_enabled(int fd)
{
char buf[256];
@@ -170,7 +188,9 @@ static bool psr_is_enabled(int fd)
static bool psr_wait_until_enabled(int fd)
{
- return igt_wait(psr_is_enabled(fd), 5000, 1);
+ bool r = igt_wait(psr_is_enabled(fd), 5000, 1);
+ psr_print_status(fd);
+ return r;
}
struct feature {
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for tests/kms_fbcon_fbt: Report fbc_status on error (rev3) 2017-10-30 17:54 [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error Gabriel Krisman Bertazi @ 2017-10-30 18:23 ` Patchwork 2017-10-30 19:15 ` ✓ Fi.CI.IGT: " Patchwork 2017-11-06 16:43 ` [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error Paulo Zanoni 2 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2017-10-30 18:23 UTC (permalink / raw) To: Gabriel Krisman Bertazi; +Cc: intel-gfx == Series Details == Series: tests/kms_fbcon_fbt: Report fbc_status on error (rev3) URL : https://patchwork.freedesktop.org/series/32256/ State : success == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire up an interloper for preemption with latest DRM-Tip kernel build CI_DRM_3294 2dd14a4ad87f drm-tip: 2017y-10m-30d-13h-40m-22s UTC integration manifest No testlist changes. Test debugfs_test: Subgroup read_all_entries: dmesg-warn -> PASS (fi-cfl-s) Test drv_getparams_basic: Subgroup basic-eu-total: dmesg-warn -> PASS (fi-cfl-s) Subgroup basic-subslice-total: dmesg-warn -> PASS (fi-cfl-s) Test drv_hangman: Subgroup error-state-basic: dmesg-warn -> PASS (fi-cfl-s) Test kms_frontbuffer_tracking: Subgroup basic: pass -> DMESG-WARN (fi-bdw-5557u) fdo#102473 Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-b: pass -> DMESG-WARN (fi-byt-n2820) fdo#101705 fdo#102473 https://bugs.freedesktop.org/show_bug.cgi?id=102473 fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705 fi-bdw-5557u total:289 pass:267 dwarn:1 dfail:0 fail:0 skip:21 time:447s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:455s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:373s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:516s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:265s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:502s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:495s fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:499s fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:487s fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:554s fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:607s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:430s fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:254s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:588s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:427s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:428s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:426s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:496s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:462s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:491s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:575s fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:480s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:593s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:551s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:452s fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:596s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:650s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:524s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:504s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:464s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:564s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:423s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_446/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for tests/kms_fbcon_fbt: Report fbc_status on error (rev3) 2017-10-30 17:54 [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error Gabriel Krisman Bertazi 2017-10-30 18:23 ` ✓ Fi.CI.BAT: success for tests/kms_fbcon_fbt: Report fbc_status on error (rev3) Patchwork @ 2017-10-30 19:15 ` Patchwork 2017-11-06 16:43 ` [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error Paulo Zanoni 2 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2017-10-30 19:15 UTC (permalink / raw) To: Gabriel Krisman Bertazi; +Cc: intel-gfx == Series Details == Series: tests/kms_fbcon_fbt: Report fbc_status on error (rev3) URL : https://patchwork.freedesktop.org/series/32256/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test kms_busy: Subgroup extended-modeset-hang-oldfb-with-reset-render-B: pass -> DMESG-WARN (shard-hsw) fdo#102249 Test kms_flip: Subgroup wf_vblank-vs-dpms: dmesg-warn -> PASS (shard-hsw) fdo#102614 Test drv_module_reload: Subgroup basic-no-display: pass -> DMESG-WARN (shard-hsw) fdo#102707 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249 fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614 fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707 shard-hsw total:2466 pass:1389 dwarn:2 dfail:0 fail:9 skip:1066 time:8899s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_446/shards.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error 2017-10-30 17:54 [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error Gabriel Krisman Bertazi 2017-10-30 18:23 ` ✓ Fi.CI.BAT: success for tests/kms_fbcon_fbt: Report fbc_status on error (rev3) Patchwork 2017-10-30 19:15 ` ✓ Fi.CI.IGT: " Patchwork @ 2017-11-06 16:43 ` Paulo Zanoni 2017-11-06 18:16 ` Gabriel Krisman Bertazi 2 siblings, 1 reply; 6+ messages in thread From: Paulo Zanoni @ 2017-11-06 16:43 UTC (permalink / raw) To: Gabriel Krisman Bertazi, intel-gfx Em Seg, 2017-10-30 às 15:54 -0200, Gabriel Krisman Bertazi escreveu: > knowing the assertion triggered on wait_until_enabled() is not that > useful without knowing what exactly caused the failure. It might be > an > user error, like too little stolen memory by the bios, or an actual > issue in the kernel. So, let's make life easier, particularly for > the > CI, by printing the status before failing out. > > Case in point: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101718 > > Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> > --- > tests/kms_fbcon_fbt.c | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c > index d0090912694e..8371be5612f5 100644 > --- a/tests/kms_fbcon_fbt.c > +++ b/tests/kms_fbcon_fbt.c > @@ -95,6 +95,14 @@ static bool connector_can_fbc(drmModeConnectorPtr > connector) > return true; > } > > +static void fbc_print_status(int fd) > +{ > + static char buf[128]; > + > + igt_debugfs_read(fd, "i915_fbc_status", buf); > + igt_debug("FBC status: %s\n", buf); > +} > + > static bool fbc_is_enabled(int fd) > { > char buf[128]; > @@ -105,7 +113,9 @@ static bool fbc_is_enabled(int fd) > > static bool fbc_wait_until_enabled(int fd) > { > - return igt_wait(fbc_is_enabled(fd), 5000, 1); > + bool r = igt_wait(fbc_is_enabled(fd), 5000, 1); > + fbc_print_status(fd); > + return r; > } > > typedef bool (*connector_possible_fn)(drmModeConnectorPtr > connector); > @@ -160,6 +170,14 @@ static bool > connector_can_psr(drmModeConnectorPtr connector) > return (connector->connector_type == > DRM_MODE_CONNECTOR_eDP); > } > > +static void psr_print_status(int fd) > +{ > + static char buf[256]; > + > + igt_debugfs_read(fd, "i915_edp_psr_status", buf); > + igt_debug("FBC status: %s\n", buf); s/FBC/PSR/ With that fixed: Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > +} > + > static bool psr_is_enabled(int fd) > { > char buf[256]; > @@ -170,7 +188,9 @@ static bool psr_is_enabled(int fd) > > static bool psr_wait_until_enabled(int fd) > { > - return igt_wait(psr_is_enabled(fd), 5000, 1); > + bool r = igt_wait(psr_is_enabled(fd), 5000, 1); > + psr_print_status(fd); > + return r; > } > > struct feature { _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error 2017-11-06 16:43 ` [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error Paulo Zanoni @ 2017-11-06 18:16 ` Gabriel Krisman Bertazi 2017-11-06 20:00 ` Paulo Zanoni 0 siblings, 1 reply; 6+ messages in thread From: Gabriel Krisman Bertazi @ 2017-11-06 18:16 UTC (permalink / raw) To: Paulo Zanoni; +Cc: intel-gfx Paulo Zanoni <paulo.r.zanoni@intel.com> writes: > Em Seg, 2017-10-30 às 15:54 -0200, Gabriel Krisman Bertazi escreveu: >> knowing the assertion triggered on wait_until_enabled() is not that >> useful without knowing what exactly caused the failure. It might be >> an >> user error, like too little stolen memory by the bios, or an actual >> issue in the kernel. So, let's make life easier, particularly for >> the >> CI, by printing the status before failing out. >> >> Case in point: >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101718 >> >> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> >> --- >> tests/kms_fbcon_fbt.c | 24 ++++++++++++++++++++++-- >> 1 file changed, 22 insertions(+), 2 deletions(-) >> >> diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c >> index d0090912694e..8371be5612f5 100644 >> --- a/tests/kms_fbcon_fbt.c >> +++ b/tests/kms_fbcon_fbt.c >> @@ -95,6 +95,14 @@ static bool connector_can_fbc(drmModeConnectorPtr >> connector) >> return true; >> } >> >> +static void fbc_print_status(int fd) >> +{ >> + static char buf[128]; >> + >> + igt_debugfs_read(fd, "i915_fbc_status", buf); >> + igt_debug("FBC status: %s\n", buf); >> +} >> + >> static bool fbc_is_enabled(int fd) >> { >> char buf[128]; >> @@ -105,7 +113,9 @@ static bool fbc_is_enabled(int fd) >> >> static bool fbc_wait_until_enabled(int fd) >> { >> - return igt_wait(fbc_is_enabled(fd), 5000, 1); >> + bool r = igt_wait(fbc_is_enabled(fd), 5000, 1); >> + fbc_print_status(fd); >> + return r; >> } >> >> typedef bool (*connector_possible_fn)(drmModeConnectorPtr >> connector); >> @@ -160,6 +170,14 @@ static bool >> connector_can_psr(drmModeConnectorPtr connector) >> return (connector->connector_type == >> DRM_MODE_CONNECTOR_eDP); >> } >> >> +static void psr_print_status(int fd) >> +{ >> + static char buf[256]; >> + >> + igt_debugfs_read(fd, "i915_edp_psr_status", buf); >> + igt_debug("FBC status: %s\n", buf); > > s/FBC/PSR/ Oops! > > With that fixed: > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Hi Paulo, Thanks for your review. Can you push the version below, then? I don't have commit rights on igt. >8 Subject: [PATCH i-g-t] tests/kms_fbcon_fbt: Report fbc_status on error knowing the assertion triggered on wait_until_enabled() is not that useful without knowing what exactly caused the failure. It might be an user error, like too little stolen memory by the bios, or an actual issue in the kernel. So, let's make life easier, particularly for the CI, by printing the status before failing out. Case in point: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101718 Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> --- tests/kms_fbcon_fbt.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c index d0090912694e..51f1172839ed 100644 --- a/tests/kms_fbcon_fbt.c +++ b/tests/kms_fbcon_fbt.c @@ -95,6 +95,14 @@ static bool connector_can_fbc(drmModeConnectorPtr connector) return true; } +static void fbc_print_status(int fd) +{ + static char buf[128]; + + igt_debugfs_read(fd, "i915_fbc_status", buf); + igt_debug("FBC status: %s\n", buf); +} + static bool fbc_is_enabled(int fd) { char buf[128]; @@ -105,7 +113,9 @@ static bool fbc_is_enabled(int fd) static bool fbc_wait_until_enabled(int fd) { - return igt_wait(fbc_is_enabled(fd), 5000, 1); + bool r = igt_wait(fbc_is_enabled(fd), 5000, 1); + fbc_print_status(fd); + return r; } typedef bool (*connector_possible_fn)(drmModeConnectorPtr connector); @@ -160,6 +170,14 @@ static bool connector_can_psr(drmModeConnectorPtr connector) return (connector->connector_type == DRM_MODE_CONNECTOR_eDP); } +static void psr_print_status(int fd) +{ + static char buf[256]; + + igt_debugfs_read(fd, "i915_edp_psr_status", buf); + igt_debug("PSR status: %s\n", buf); +} + static bool psr_is_enabled(int fd) { char buf[256]; @@ -170,7 +188,9 @@ static bool psr_is_enabled(int fd) static bool psr_wait_until_enabled(int fd) { - return igt_wait(psr_is_enabled(fd), 5000, 1); + bool r = igt_wait(psr_is_enabled(fd), 5000, 1); + psr_print_status(fd); + return r; } struct feature { -- 2.11.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error 2017-11-06 18:16 ` Gabriel Krisman Bertazi @ 2017-11-06 20:00 ` Paulo Zanoni 0 siblings, 0 replies; 6+ messages in thread From: Paulo Zanoni @ 2017-11-06 20:00 UTC (permalink / raw) To: Gabriel Krisman Bertazi; +Cc: intel-gfx Em Seg, 2017-11-06 às 16:16 -0200, Gabriel Krisman Bertazi escreveu: > Paulo Zanoni <paulo.r.zanoni@intel.com> writes: > > > Em Seg, 2017-10-30 às 15:54 -0200, Gabriel Krisman Bertazi > > escreveu: > > > knowing the assertion triggered on wait_until_enabled() is not > > > that > > > useful without knowing what exactly caused the failure. It might > > > be > > > an > > > user error, like too little stolen memory by the bios, or an > > > actual > > > issue in the kernel. So, let's make life easier, particularly > > > for > > > the > > > CI, by printing the status before failing out. > > > > > > Case in point: > > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101718 > > > > > > Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> > > > --- > > > tests/kms_fbcon_fbt.c | 24 ++++++++++++++++++++++-- > > > 1 file changed, 22 insertions(+), 2 deletions(-) > > > > > > diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c > > > index d0090912694e..8371be5612f5 100644 > > > --- a/tests/kms_fbcon_fbt.c > > > +++ b/tests/kms_fbcon_fbt.c > > > @@ -95,6 +95,14 @@ static bool > > > connector_can_fbc(drmModeConnectorPtr > > > connector) > > > return true; > > > } > > > > > > +static void fbc_print_status(int fd) > > > +{ > > > + static char buf[128]; > > > + > > > + igt_debugfs_read(fd, "i915_fbc_status", buf); > > > + igt_debug("FBC status: %s\n", buf); > > > +} > > > + > > > static bool fbc_is_enabled(int fd) > > > { > > > char buf[128]; > > > @@ -105,7 +113,9 @@ static bool fbc_is_enabled(int fd) > > > > > > static bool fbc_wait_until_enabled(int fd) > > > { > > > - return igt_wait(fbc_is_enabled(fd), 5000, 1); > > > + bool r = igt_wait(fbc_is_enabled(fd), 5000, 1); > > > + fbc_print_status(fd); > > > + return r; > > > } > > > > > > typedef bool (*connector_possible_fn)(drmModeConnectorPtr > > > connector); > > > @@ -160,6 +170,14 @@ static bool > > > connector_can_psr(drmModeConnectorPtr connector) > > > return (connector->connector_type == > > > DRM_MODE_CONNECTOR_eDP); > > > } > > > > > > +static void psr_print_status(int fd) > > > +{ > > > + static char buf[256]; > > > + > > > + igt_debugfs_read(fd, "i915_edp_psr_status", buf); > > > + igt_debug("FBC status: %s\n", buf); > > > > s/FBC/PSR/ > > Oops! > > > > > With that fixed: > > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > > Hi Paulo, > > Thanks for your review. Can you push the version below, then? I > don't > have commit rights on igt. Pushed. Thanks for the patch! > > > 8 > > Subject: [PATCH i-g-t] tests/kms_fbcon_fbt: Report fbc_status on > error > > knowing the assertion triggered on wait_until_enabled() is not that > useful without knowing what exactly caused the failure. It might be > an > user error, like too little stolen memory by the bios, or an actual > issue in the kernel. So, let's make life easier, particularly for > the > CI, by printing the status before failing out. > > Case in point: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101718 > > Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > --- > tests/kms_fbcon_fbt.c | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c > index d0090912694e..51f1172839ed 100644 > --- a/tests/kms_fbcon_fbt.c > +++ b/tests/kms_fbcon_fbt.c > @@ -95,6 +95,14 @@ static bool connector_can_fbc(drmModeConnectorPtr > connector) > return true; > } > > +static void fbc_print_status(int fd) > +{ > + static char buf[128]; > + > + igt_debugfs_read(fd, "i915_fbc_status", buf); > + igt_debug("FBC status: %s\n", buf); > +} > + > static bool fbc_is_enabled(int fd) > { > char buf[128]; > @@ -105,7 +113,9 @@ static bool fbc_is_enabled(int fd) > > static bool fbc_wait_until_enabled(int fd) > { > - return igt_wait(fbc_is_enabled(fd), 5000, 1); > + bool r = igt_wait(fbc_is_enabled(fd), 5000, 1); > + fbc_print_status(fd); > + return r; > } > > typedef bool (*connector_possible_fn)(drmModeConnectorPtr > connector); > @@ -160,6 +170,14 @@ static bool > connector_can_psr(drmModeConnectorPtr connector) > return (connector->connector_type == > DRM_MODE_CONNECTOR_eDP); > } > > +static void psr_print_status(int fd) > +{ > + static char buf[256]; > + > + igt_debugfs_read(fd, "i915_edp_psr_status", buf); > + igt_debug("PSR status: %s\n", buf); > +} > + > static bool psr_is_enabled(int fd) > { > char buf[256]; > @@ -170,7 +188,9 @@ static bool psr_is_enabled(int fd) > > static bool psr_wait_until_enabled(int fd) > { > - return igt_wait(psr_is_enabled(fd), 5000, 1); > + bool r = igt_wait(psr_is_enabled(fd), 5000, 1); > + psr_print_status(fd); > + return r; > } > > struct feature { _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-06 20:00 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-10-30 17:54 [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error Gabriel Krisman Bertazi 2017-10-30 18:23 ` ✓ Fi.CI.BAT: success for tests/kms_fbcon_fbt: Report fbc_status on error (rev3) Patchwork 2017-10-30 19:15 ` ✓ Fi.CI.IGT: " Patchwork 2017-11-06 16:43 ` [PATCH i-g-t v2 RESEND] tests/kms_fbcon_fbt: Report fbc_status on error Paulo Zanoni 2017-11-06 18:16 ` Gabriel Krisman Bertazi 2017-11-06 20:00 ` Paulo Zanoni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox