From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Sagar Arun Kamble <sagar.a.kamble@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [RFC 0/3] GuC functions name/prototype update
Date: Fri, 10 Nov 2017 13:29:55 +0200 [thread overview]
Message-ID: <1510313395.4488.15.camel@linux.intel.com> (raw)
In-Reply-To: <151030828415.2124.16979934149999181871@mail.alporthouse.com>
On Fri, 2017-11-10 at 10:04 +0000, Chris Wilson wrote:
> Quoting Sagar Arun Kamble (2017-11-10 09:59:44)
> > We want to have consistent function/structure/file naming and
> > function parameter semantics. Suggestion from Michal Wajdeczko about
> > using "genx_" prefix (or better _genx" suffix for all hw related
> > structures types, offsets), "i915_" prefix for driver entry calls and
> > "intel_" in all other seems to be the good scheme to go ahead.
> > Also we need to adhere to practise of passing drm_i915_private to
> > functions with "i915_" prefix and component structure to functions
> > with "intel_" prefix. This series updates GuC submission related code
> > with these changes.
> >
> > With GuC submission being hardware interface for i915, we should name
> > those functions with prefix "intel_guc" and pass struct intel_guc as
> > parameter. Also i915_guc_client struct is kernel-hw interaction
> > structure hence rename that to intel_guc_client.
> > With these changes GuC submission source files are now named with
> > "intel_" prefix.
>
> Lgtm.
>
> Having intel_guc_client be the HW facing struct, leaves i915_guc_client
> in case we ever need something to track uabi.
Yep,
Please make sure that make htmldocs keeps working after the renames.
Under Documentation/gpu
i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/i915_guc_submission.c
i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/i915_guc_submission.c
i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_fwif.h
With that fixed, the series is;
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-10 11:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 9:59 [RFC 0/3] GuC functions name/prototype update Sagar Arun Kamble
2017-11-10 9:59 ` [RFC 1/3] drm/i915/guc: Update name and prototype of GuC submission related functions Sagar Arun Kamble
2017-11-10 9:59 ` [RFC 2/3] drm/i915/guc: Rename i915_guc_client struct to intel_guc_client Sagar Arun Kamble
2017-11-10 9:59 ` [RFC 3/3] drm/i915/guc: Rename i915_guc_submission.c|h to intel_guc_submission.c|h Sagar Arun Kamble
2017-11-10 10:04 ` [RFC 0/3] GuC functions name/prototype update Chris Wilson
2017-11-10 11:29 ` Joonas Lahtinen [this message]
2017-11-10 10:38 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-11-11 0:26 ` [RFC 0/3] " Oscar Mateo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510313395.4488.15.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sagar.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox