From: Adam Jackson <ajax@redhat.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
dri-devel@lists.freedesktop.org
Cc: Jose Abreu <Jose.Abreu@synopsys.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 08/10] drm/uapi: Deprecate nonsense kms mode types
Date: Tue, 14 Nov 2017 15:43:18 -0500 [thread overview]
Message-ID: <1510692198.22084.6.camel@redhat.com> (raw)
In-Reply-To: <20171114183258.16976-9-ville.syrjala@linux.intel.com>
On Tue, 2017-11-14 at 20:32 +0200, Ville Syrjala wrote:
> @@ -253,8 +251,11 @@ struct drm_display_mode {
> * - DRM_MODE_TYPE_USERDEF: Mode defined via kernel command line
> *
> * Plus a big list of flags which shouldn't be used at all, but are
> - * still around since these flags are also used in the userspace ABI:
> + * still around since these flags are also used in the userspace ABI.
> + * We no longer accept modes with these types though:
> *
> + * - DRM_MODE_TYPE_BUILTIN: Meant for hard-coded modes, effectively
> + * unused.
This should suggest _TYPE_DRIVER, I think. The intent with the xfree86
mode type was that "built-in" modes were known quantities of the
hardware, either because the hardware only had one mode or due to
strapping pins or the like. These should be considered "supplied by the
driver" as with EDID-derived modes.
With or without that, patches 2 3 4 and 8 are:
Reviewed-by: Adam Jackson <ajax@redhat.com>
- ajax
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-14 20:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 18:32 [PATCH 00/10] drm/uapi: Validate mode flags/type, and deprecate some of them Ville Syrjala
2017-11-14 18:32 ` [PATCH 01/10] drm/modes: Move 3D stereo flag check into drm_mode_validate_basic() Ville Syrjala
2017-11-14 19:22 ` Alex Deucher
2017-11-14 18:32 ` [PATCH 02/10] drm/uapi: Validate the mode flags/type Ville Syrjala
2017-11-14 18:42 ` [Intel-gfx] " Chris Wilson
2017-11-14 18:46 ` Ville Syrjälä
2017-11-15 15:49 ` [PATCH v2 " Ville Syrjala
2017-11-15 17:38 ` Alex Deucher
2017-11-15 18:02 ` Jose Abreu
2017-11-15 18:11 ` Ville Syrjälä
2018-03-21 20:45 ` drm-next xf86-video-vmware breakage Was [PATCH " Thomas Hellstrom
2018-03-21 20:51 ` Ville Syrjälä
2018-03-21 21:06 ` Thomas Hellstrom
2017-11-14 18:32 ` [PATCH 03/10] drm/uapi: Deprecate DRM_MODE_FLAG_PIXMUX Ville Syrjala
2017-11-14 19:12 ` Alex Deucher
2017-11-15 18:05 ` Jose Abreu
2017-11-14 18:32 ` [PATCH 04/10] drm/uapi: Deprecate DRM_MODE_FLAG_BCAST Ville Syrjala
2017-11-14 19:13 ` Alex Deucher
2017-11-15 18:05 ` Jose Abreu
2017-11-14 18:32 ` [PATCH 05/10] drm/modes: Fix description of DRM_MODE_TYPE_USERDEF Ville Syrjala
2017-11-14 19:32 ` Alex Deucher
2017-11-14 18:32 ` [PATCH 06/10] drm/modes: Kill off the oddball DRM_MODE_TYPE_CRTC_C vs. DRM_MODE_TYPE_BUILTIN handling Ville Syrjala
2017-11-14 18:43 ` Chris Wilson
2017-11-14 19:16 ` Alex Deucher
2017-11-14 18:32 ` [PATCH 07/10] drm/modes: Kill DRM_MODE_TYPE_CLOCK_CRTC_C define Ville Syrjala
2017-11-14 19:17 ` Alex Deucher
2017-11-14 18:32 ` [PATCH 08/10] drm/uapi: Deprecate nonsense kms mode types Ville Syrjala
2017-11-14 19:19 ` Alex Deucher
2017-11-14 20:43 ` Adam Jackson [this message]
[not found] ` <20171115154504.14338-1-ville.syrjala@linux.intel.com>
2017-11-15 18:04 ` [PATCH v2 " Jose Abreu
2017-11-14 18:32 ` [PATCH 09/10] drm/modes: Provide global mode_valid hook Ville Syrjala
2017-11-20 8:00 ` Daniel Vetter
2017-11-14 18:32 ` [PATCH 10/10] drm/i915: Provide a device level .mode_valid() hook Ville Syrjala
2017-11-20 8:01 ` Daniel Vetter
2017-11-20 8:02 ` Daniel Vetter
2017-11-14 19:13 ` ✓ Fi.CI.BAT: success for drm/uapi: Validate mode flags/type, and deprecate some of them Patchwork
2017-11-14 21:41 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-11-15 16:11 ` ✓ Fi.CI.BAT: success for drm/uapi: Validate mode flags/type, and deprecate some of them (rev2) Patchwork
2017-11-15 17:12 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-29 20:12 ` [PATCH 00/10] drm/uapi: Validate mode flags/type, and deprecate some of them Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510692198.22084.6.camel@redhat.com \
--to=ajax@redhat.com \
--cc=Jose.Abreu@synopsys.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox