From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Remove vma from object on destroy, not close
Date: Thu, 07 Dec 2017 15:28:27 +0200 [thread overview]
Message-ID: <1512653307.4586.32.camel@linux.intel.com> (raw)
In-Reply-To: <20171206124914.19960-1-chris@chris-wilson.co.uk>
On Wed, 2017-12-06 at 12:49 +0000, Chris Wilson wrote:
> Originally we translated from the object to the vma by walking
> obj->vma_list to find the matching vm (for user lookups). Now we process
> user lookups using the rbtree, and we only use obj->vma_list itself for
> maintaining state (e.g. ensuring that all vma are flushed or rebound).
> As such maintenance needs to go on beyond the user's awareness of the
> vma, defer removal of the vma from the obj->vma_list from i915_vma_close()
> to i915_vma_destroy()
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-12-07 13:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 12:49 [PATCH 1/2] drm/i915: Remove vma from object on destroy, not close Chris Wilson
2017-12-06 12:49 ` [PATCH 2/2] drm/i915: Track GGTT writes on the vma Chris Wilson
2017-12-07 13:42 ` Joonas Lahtinen
2017-12-07 13:51 ` Chris Wilson
2017-12-06 13:10 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Remove vma from object on destroy, not close Patchwork
2017-12-06 14:15 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-12-07 13:28 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512653307.4586.32.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).