From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Piorkowski, Piotr" Subject: Re: [PATCH] drm/i915/guc: Removed unused GuC parameters. Date: Mon, 5 Mar 2018 11:12:45 +0000 Message-ID: <1520248363.2906.10.camel@intel.com> References: <20180228184225.43722-1-piotr.piorkowski@intel.com> <844c7ffc-5ca5-39c8-5a51-8abc422bbe3c@intel.com> <151989136748.32001.14485974402867192040@mail.alporthouse.com> <9e20cda2-998f-fcc6-4322-de2880fedd48@intel.com> <1519931677.9578.6.camel@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0272137886==" Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7583A6E0AF for ; Mon, 5 Mar 2018 11:12:48 +0000 (UTC) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Spotswood, John A" , "Thierry, Michel" , "intel-gfx@lists.freedesktop.org" , "chris@chris-wilson.co.uk" , "Kamble, Sagar A" List-Id: intel-gfx@lists.freedesktop.org --===============0272137886== Content-Language: en-US Content-Type: multipart/signed; micalg=sha-1; protocol="application/x-pkcs7-signature"; boundary="=-b9qp4UxahMmDM5VREJaN" --=-b9qp4UxahMmDM5VREJaN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2018-03-02 at 12:53 +0530, Sagar Arun Kamble wrote: >=20 > On 3/2/2018 12:44 AM, John Spotswood wrote: > > On Thu, 2018-03-01 at 17:35 +0530, Sagar Arun Kamble wrote: > > > On 3/1/2018 1:32 PM, Chris Wilson wrote: > > > > Quoting Michel Thierry (2018-02-28 22:07:51) > > > > > On 28/02/18 12:26, Michel Thierry wrote: > > > > > > On 28/02/18 10:42, Piotr Pi=C3=B3rkowski wrote: > > > > > > > In the i915 driver, there is a function, > > > > > > > intel_guc_init_params(), > > > > > > > which initializes the GuC parameter block which is passed > > > > > > > into > > > > > > > the GuC. There is parameter GUC_CTL_DEVICE_INFO with > > > > > > > values > > > > > > > GfxGtType and GfxCoreFamily unused by GuC. > > > > > > >=20 > > > > > > > This patch remove GUC_CTL_DEVICE_INFO with GfxGtType and > > > > > > > GfxCoreFamily parameters and also unnecessary functions > > > > > > > get_gt_type() and get_core_family(). > > > > > > >=20 > > > > > >=20 > > > > > > Hi, > > > > > >=20 > > > > > > Looking at the fw code, you're partially right, GfxGtType > > > > > > is > > > > > > ignored... > > > > > > but GfxCoreFamily isn't. > > > > > >=20 > > > > >=20 > > > > > Unless whoever wrote the fw was smart enough to forget to > > > > > call > > > > > the > > > > > function that is reading GfxCoreFamily... I didn't count on > > > > > that. > > > >=20 > > > > Is the intention to use GfxCoreFamily documented, i.e. are they > > > > expecting it part of the interface and may re-instantiate the > > > > check > > > > "because it was always supposed to exist" in some future > > > > version? > > >=20 > > > Usage of GfxCoreFamily is only in SLPC and for platform specific > > > initialization and might be removed in future interfaces. > > > If needed, we can add as part of SLPC patches. > >=20 > > Michel and I have traced through the FW code, and both parameters > > are > > unused. GfxCoreFamily does appear to be set in the FW, and it gets > > passed into SLPC, but then it never gets used. >=20 > Hi John, >=20 > It is needed for SLPC initialization. Verified on v9 GuC firmware > that=20 > SLPC GTPERF gets disabled if i915 does not send this param. > We can add this param as part of SLPC patches for GuC versions which=20 > need them. Ok, so I think that we should remove this param from i915, and than if=20 it is needed, we can add this param as part of SLPC patches, as Sagar said. -Piotr=20 >=20 > Thanks > Sagar > > I have confirmed with > > FW developers that these parameters have been removed for future > > gens. > > > > -Chris > > > > _______________________________________________ > > > > Intel-gfx mailing list > > > > Intel-gfx@lists.freedesktop.org > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx >=20 >=20 --=-b9qp4UxahMmDM5VREJaN Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKeTCCBOsw ggPToAMCAQICEDabxALowUBS+21KC0JI8fcwDQYJKoZIhvcNAQEFBQAwbzELMAkGA1UEBhMCU0Ux FDASBgNVBAoTC0FkZFRydXN0IEFCMSYwJAYDVQQLEx1BZGRUcnVzdCBFeHRlcm5hbCBUVFAgTmV0 d29yazEiMCAGA1UEAxMZQWRkVHJ1c3QgRXh0ZXJuYWwgQ0EgUm9vdDAeFw0xMzEyMTEwMDAwMDBa Fw0yMDA1MzAxMDQ4MzhaMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIGA1UEBxMLU2Fu dGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQDEyJJbnRlbCBFeHRl cm5hbCBCYXNpYyBJc3N1aW5nIENBIDRCMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA yzuW/y/g0bznz8BD48M94luFzqHaqY9yGN9H/W0J7hOVBpl0rTQJ6kZ7z7hyDb9kf2UW4ZU25alC i+q5m6NwHg+z9pcN7bQ84SSBueaYF7cXlAg7z3XyZbzSEYP7raeuWRf5fYvYzq8/uI7VNR8o/43w PtDP10YDdO/0J5xrHxnC/9/aU+wTFSVsPqxsd7C58mnu7G4VRJ0n9PG4SfmYNC0h/5fLWuOWhxAv 6MuiK7MmvTPHLMclULgJqVSqG1MbBs0FbzoRHne4Cx0w6rtzPTrzo+bTRqhruaU18lQkzBk6OnyJ UthtaDQIlfyGy2IlZ5F6QEyjItbdKcHHdjBX8wIDAQABo4IBdzCCAXMwHwYDVR0jBBgwFoAUrb2Y ejS0Jvf6xCZU7wO94CTLVBowHQYDVR0OBBYEFNpBI5xaj3GvV4M+INPjZdsMywvbMA4GA1UdDwEB /wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMDYGA1UdJQQvMC0GCCsGAQUFBwMEBgorBgEEAYI3 CgMEBgorBgEEAYI3CgMMBgkrBgEEAYI3FQUwFwYDVR0gBBAwDjAMBgoqhkiG+E0BBQFpMEkGA1Ud HwRCMEAwPqA8oDqGOGh0dHA6Ly9jcmwudHJ1c3QtcHJvdmlkZXIuY29tL0FkZFRydXN0RXh0ZXJu YWxDQVJvb3QuY3JsMDoGCCsGAQUFBwEBBC4wLDAqBggrBgEFBQcwAYYeaHR0cDovL29jc3AudHJ1 c3QtcHJvdmlkZXIuY29tMDUGA1UdHgQuMCygKjALgQlpbnRlbC5jb20wG6AZBgorBgEEAYI3FAID oAsMCWludGVsLmNvbTANBgkqhkiG9w0BAQUFAAOCAQEAp9XGgH85hk/3IuN8F4nrFd24MAoau7Uq M/of09XtyYg2dV0TIPqtxPZw4813r78WwsGIbvtO8VQ18dNktIxaq6+ym2zebqDh0z6Bvo63jKE/ HMj8oNV3ovnuo+7rGpCppcda4iVBG2CetB3WXbUVr82EzECN+wxmC4H9Rup+gn+t+qeBTaXulQfV TYOvZ0eZPO+DyC2pVv5q5+xHljyUsVqpzsw89utuO8ZYaMsQGBRuFGOncRLEOhCtehy5B5aCI571 i4dDAv9LPODrEzm3PBfrNhlp8C0skak15VXWFzNuHd00AsxXxWSUT4TG8RiAH61Ua5GXsP1BIZwl 4WjK8DCCBYYwggRuoAMCAQICEzMAAFxPtYQ0YXrsTWoAAAAAXE8wDQYJKoZIhvcNAQEFBQAweTEL MAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQwEgYDVQQHEwtTYW50YSBDbGFyYTEaMBgGA1UEChMR SW50ZWwgQ29ycG9yYXRpb24xKzApBgNVBAMTIkludGVsIEV4dGVybmFsIEJhc2ljIElzc3Vpbmcg Q0EgNEIwHhcNMTgwMjE5MTc0NTM4WhcNMTkwMjE0MTc0NTM4WjBHMRowGAYDVQQDExFQaW9ya293 c2tpLCBQaW90cjEpMCcGCSqGSIb3DQEJARYacGlvdHIucGlvcmtvd3NraUBpbnRlbC5jb20wggEi MA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCyl4w4oeJtPZQdB+OI/PDGp6tFU6hbUMuhFu/4 skBsXLThTJ+hN5Fa//ms2CAb/CZqJ7mQkF95Zimyoqu90rR59YgsPI0npWPr+JppFw2wF5Uchgnp S+3DQV9+BwKna7tJsGDVDqaJ7G4hPPKLsLaLgs/4uJETCp4BQwh/tQfMqX6Fsr2bw+ttB+bfNB1q 0B4j1SbDJvy1FcGWcqCG3O/THg4BV7jg7LPFrCcux46Cf0P6ubsD/rTUGazbLMKCZZ/evHmwbS4+ iwe0MJtz29cIjJrZPnUPkyHtgmDMTRHi6uyykDRKQvhsenWsbKPL/C3wgNMHSb0d4n+6X/78/9zL AgMBAAGjggI3MIICMzAdBgNVHQ4EFgQUR/MOmWgueksOzHfuwXuHg93rj28wHwYDVR0jBBgwFoAU 2kEjnFqPca9Xgz4g0+Nl2wzLC9swZQYDVR0fBF4wXDBaoFigVoZUaHR0cDovL3d3dy5pbnRlbC5j b20vcmVwb3NpdG9yeS9DUkwvSW50ZWwlMjBFeHRlcm5hbCUyMEJhc2ljJTIwSXNzdWluZyUyMENB JTIwNEIuY3JsMIGfBggrBgEFBQcBAQSBkjCBjzAiBggrBgEFBQcwAYYWaHR0cDovL29jc3AuaW50 ZWwuY29tLzBpBggrBgEFBQcwAoZdaHR0cDovL3d3dy5pbnRlbC5jb20vcmVwb3NpdG9yeS9jZXJ0 aWZpY2F0ZXMvSW50ZWwlMjBFeHRlcm5hbCUyMEJhc2ljJTIwSXNzdWluZyUyMENBJTIwNEIuY3J0 MAsGA1UdDwQEAwIHgDA8BgkrBgEEAYI3FQcELzAtBiUrBgEEAYI3FQiGw4x1hJnlUYP9gSiFjp9T gpHACWeB3r05lfBDAgFkAgEJMB8GA1UdJQQYMBYGCCsGAQUFBwMEBgorBgEEAYI3CgMMMCkGCSsG AQQBgjcVCgQcMBowCgYIKwYBBQUHAwQwDAYKKwYBBAGCNwoDDDBRBgNVHREESjBIoCoGCisGAQQB gjcUAgOgHAwacGlvdHIucGlvcmtvd3NraUBpbnRlbC5jb22BGnBpb3RyLnBpb3Jrb3dza2lAaW50 ZWwuY29tMA0GCSqGSIb3DQEBBQUAA4IBAQAoJI/vcHFuPtqgAhV4hIfO3BGXYnIEvhBIVRJ2awq8 tpPArc3oGBv4ITRiwB43r4B8BBkhdFBAB8Y+xQm0NJ9itUs+QVQC6wXqJ6P1WWtAhIIl28dLNdnJ 7tMV49VHeWMhtCNQrfsCORqvD2/H6EilyN+48Vh2wuiK8MRnFx8RJ+9tP+meFn1bUDChxGuE42fB TcyJv7yyF9zAFPZl5o9oxW3MQTacr6uYIrKBHmepV0BsUCh7NZXM4m0racvjt8vcWU70hGQNopN6 PN5+9YIV2ASxcPEusoifg52AjH3HFaZqG8IgzCSVlP3n0UGj4GMkM3hPKbWq3MAkZErtPcAlMYIC FzCCAhMCAQEwgZAweTELMAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQwEgYDVQQHEwtTYW50YSBD bGFyYTEaMBgGA1UEChMRSW50ZWwgQ29ycG9yYXRpb24xKzApBgNVBAMTIkludGVsIEV4dGVybmFs IEJhc2ljIElzc3VpbmcgQ0EgNEICEzMAAFxPtYQ0YXrsTWoAAAAAXE8wCQYFKw4DAhoFAKBdMBgG CSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTE4MDMwNTExMTI0M1owIwYJ KoZIhvcNAQkEMRYEFDmvn36qhIvh2LETymKt+ryqzjPCMA0GCSqGSIb3DQEBAQUABIIBAJJiDame xsvgA4ku2KAFcs42opZfAEnN8CcaNHacOrWJTN4TA1SBFpsy9oi+0UqUksZDvZlh05SQpB6GWwG4 8eAQx+7OJk42CnjkJg7YBUHF10DKUCiSFmqvpQaOhLFxunPTdhEG0m4HqViNhxBDgyasIWp4WSQi I0bRPawSIDLyjR4hfM6ynQsWbjkAQfU4vMhZG4+XWk1jAg6/s6Aaz+Aw5DnTPnkJsg2XPODcc5+t d6QeUvfzysMIp8cbh4jw1GeDHaQ5Sl2q9WwPFZaalHR09XplPJbCb7m5txmORJQCdCDCn+qaB7g4 AsoTMLoqjhmje3AvC3Dz0uMCQltU5aoAAAAAAAA= --=-b9qp4UxahMmDM5VREJaN-- --===============0272137886== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0272137886==--