From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Pandiyan, Dhinakaran" Subject: Re: [PATCH] drm/i915: Handle changing enable_psr parameter at runtime better Date: Thu, 8 Mar 2018 17:43:15 +0000 Message-ID: <1520532425.4958.13.camel@dk-H97M-D3H> References: <20180307163939.59880-1-maarten.lankhorst@linux.intel.com> <1520462797.20396.49.camel@dk-H97M-D3H> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E5B436EAD2 for ; Thu, 8 Mar 2018 17:43:17 +0000 (UTC) In-Reply-To: Content-Language: en-US Content-ID: <6C55111B1CE64747B21900827FA2FA3C@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "maarten.lankhorst@linux.intel.com" Cc: "intel-gfx@lists.freedesktop.org" , "bberg@redhat.com" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org DQoNCg0KT24gVGh1LCAyMDE4LTAzLTA4IGF0IDA4OjA3ICswMTAwLCBNYWFydGVuIExhbmtob3Jz dCB3cm90ZToNCj4gT3AgMDctMDMtMTggb20gMjM6MjIgc2NocmVlZiBQYW5kaXlhbiwgRGhpbmFr YXJhbjoNCj4gPiBPbiBXZWQsIDIwMTgtMDMtMDcgYXQgMTc6MzkgKzAxMDAsIE1hYXJ0ZW4gTGFu a2hvcnN0IHdyb3RlOg0KPiA+PiBTaW1pbGFyIHRvIGVuYWJsZV9mYmMsIGVuYWJsZV9wc3Igd2Fz IGlnbm9yZWQgYXQgcnVudGltZSBpZiBpdCB3YXMNCj4gPj4gY2hhbmdlZC4gVGhlIGVhc2llc3Qg Zml4IGlzIHRvIHByZXRlbmQgZW5hYmxlX3BzciBpcyBpZ25vcmVkIGF0DQo+ID4+IGNvbmZpZ3Vy ZSB0aW1lLCBhbmQgbmV2ZXIgYWN0aXZhdGUgaXQgZm9yICFlbmFibGVfcHNyLCBzbyBib3RoIGNh c2VzDQo+ID4+IGFyZSBoYW5kbGVkIHdpdGhvdXQgbW9kZXNldHMuDQo+ID4gV2hhdCBhYm91dCBj YXNlcyB3aGVyZSBwc3JfZmx1c2goKSBpcyBub3QgY2FsbGVkIGFuZCBjb25zZXF1ZW50bHkgdGhl DQo+ID4gbW9kdWxlIHBhcmFtZXRlciBpcyBub3QgY2hlY2tlZD8gV2l0aCBIVyB0cmFja2luZywg UFNSIGlzDQo+ID4gZW5hYmxlZC9kaXNhYmxlZCBkdXJpbmcgbW9kZXNldCBhbmQgdGhlIGhhcmR3 YXJlIGlzIGV4cGVjdGVkIHRvIGV4aXQgYW5kDQo+ID4gYWN0aXZhdGUgUFNSIHdpdGhvdXQgZHJp dmVyIGludGVydmVudGlvbi4NCj4gSXQgbG9va3MgbGlrZSBpbnRlbF9mcm9udGJ1ZmZlcl9mbHVz aCBhbHdheXMgY2FsbHMgaW50ZWxfcHNyX2ZsdXNoLA0KPiBzbyB3ZSBhdCBsZWFzdCBnZXQgYSBQ U1IgdG9nZ2xlIGFmdGVyIGV2ZXJ5IGF0b21pYyBjb21taXQ/DQoNCkkgaGF2ZSBhIHBhdGNoIHRv IHJlbW92ZSBmbHVzaCgpIGZyb20gbGVnYWN5X2N1cnNvcl91cGRhdGUoKS4gV2UgZW5kIHVwDQp3 aXRoIGFuIGluY29uc2lzdGVudCBiZWhhdmlvciB3aGVuIHRoYXQgcGF0Y2ggZ2V0cyBtZXJnZWQs DQpjdXJzb3IgbW92ZXMgLT4gdHJpZ2dlciBwc3IgZXhpdCBidXQgZG9uJ3QgcmVhZCBtb2R1bGUg cGFyYW1ldGVyDQpjb21taXRzIC0+IHRyaWdnZXIgcHNyIGV4aXQgYnV0IHJlYWQgbW9kdWxlIHBh cmFtZXRlcg0KDQpFdmVudHVhbGx5LCB3aGVuIHdlIGdldCB0byByZW1vdmluZyBmbHVzaCgpIGZy b20gY29tbWl0cywgdGhlbiB0aGlzDQpwYXRjaCB3b24ndCByZWFsbHkgYmUgdXNlZnVsLiBBbmQg dGVzdHMgZGlzYWJsaW5nL2VuYWJsaW5nIFBTUiBhdA0KcnVudGltZSB3aWxsIHByb2JhYmx5IGZh aWwuDQoNCg0KPiANCj4gfk1hYXJ0ZW4NCj4gDQo+ID4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+DQo+ID4+IFRlc3Rl ZC1ieTogQmVuamFtaW4gQmVyZyA8YmJlcmdAcmVkaGF0LmNvbT4NCj4gPj4gQ2M6IEJlbmphbWlu IEJlcmcgPGJiZXJnQHJlZGhhdC5jb20+DQo+ID4+IC0tLQ0KPiA+PiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcHNyLmMgfCAxOSArKysrKysrKysrLS0tLS0tLS0tDQo+ID4+ICAxIGZpbGUg Y2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkNCj4gPj4NCj4gPj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcHNyLmMNCj4gPj4gaW5kZXggMjMxNzVjNWM0YTUwLi5hYzNjZTdhMWMy YTcgMTAwNjQ0DQo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jDQo+ ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jDQo+ID4+IEBAIC01MDIs MTEgKzUwMiw2IEBAIHZvaWQgaW50ZWxfcHNyX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9k cCAqaW50ZWxfZHAsDQo+ID4+ICAJaWYgKCFDQU5fUFNSKGRldl9wcml2KSkNCj4gPj4gIAkJcmV0 dXJuOw0KPiA+PiAgDQo+ID4+IC0JaWYgKCFpOTE1X21vZHBhcmFtcy5lbmFibGVfcHNyKSB7DQo+ ID4+IC0JCURSTV9ERUJVR19LTVMoIlBTUiBkaXNhYmxlIGJ5IGZsYWdcbiIpOw0KPiA+PiAtCQly ZXR1cm47DQo+ID4+IC0JfQ0KPiA+PiAtDQo+ID4+ICAJLyoNCj4gPj4gIAkgKiBIU1cgc3BlYyBl eHBsaWNpdGx5IHNheXMgUFNSIGlzIHRpZWQgdG8gcG9ydCBBLg0KPiA+PiAgCSAqIEJEVysgcGxh dGZvcm1zIHdpdGggRERJIGltcGxlbWVudGF0aW9uIG9mIFBTUiBoYXZlIGRpZmZlcmVudA0KPiA+ PiBAQCAtNTU5LDcgKzU1NCwxMCBAQCB2b2lkIGludGVsX3Bzcl9jb21wdXRlX2NvbmZpZyhzdHJ1 Y3QgaW50ZWxfZHAgKmludGVsX2RwLA0KPiA+PiAgDQo+ID4+ICAJY3J0Y19zdGF0ZS0+aGFzX3Bz ciA9IHRydWU7DQo+ID4+ICAJY3J0Y19zdGF0ZS0+aGFzX3BzcjIgPSBpbnRlbF9wc3IyX2NvbmZp Z192YWxpZChpbnRlbF9kcCwgY3J0Y19zdGF0ZSk7DQo+ID4+IC0JRFJNX0RFQlVHX0tNUygiRW5h YmxpbmcgUFNSJXNcbiIsIGNydGNfc3RhdGUtPmhhc19wc3IyID8gIjIiIDogIiIpOw0KPiA+PiAr CWlmIChpOTE1X21vZHBhcmFtcy5lbmFibGVfcHNyKQ0KPiA+PiArCQlEUk1fREVCVUdfS01TKCJF bmFibGluZyBQU1Ilc1xuIiwgY3J0Y19zdGF0ZS0+aGFzX3BzcjIgPyAiMiIgOiAiIik7DQo+ID4+ ICsJZWxzZQ0KPiA+PiArCQlEUk1fREVCVUdfS01TKCJQU1IgZGlzYWJsZSBieSBmbGFnXG4iKTsN Cj4gPj4gIH0NCj4gPj4gIA0KPiA+PiAgc3RhdGljIHZvaWQgaW50ZWxfcHNyX2FjdGl2YXRlKHN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApDQo+ID4+IEBAIC02NTIsNyArNjUwLDkgQEAgdm9pZCBp bnRlbF9wc3JfZW5hYmxlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsDQo+ID4+ICAJZGV2X3By aXYtPnBzci5lbmFibGVfc291cmNlKGludGVsX2RwLCBjcnRjX3N0YXRlKTsNCj4gPj4gIAlkZXZf cHJpdi0+cHNyLmVuYWJsZWQgPSBpbnRlbF9kcDsNCj4gPj4gIA0KPiA+PiAtCWlmIChJTlRFTF9H RU4oZGV2X3ByaXYpID49IDkpIHsNCj4gPj4gKwlpZiAoIWk5MTVfbW9kcGFyYW1zLmVuYWJsZV9w c3IpIHsNCj4gPj4gKwkJRFJNX0RFQlVHX0tNUygiUFNSIGRpc2FibGUgYnkgZmxhZ1xuIik7DQo+ ID4+ICsJfSBlbHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkpIHsNCj4gPj4gIAkJaW50 ZWxfcHNyX2FjdGl2YXRlKGludGVsX2RwKTsNCj4gPj4gIAl9IGVsc2Ugew0KPiA+PiAgCQkvKg0K PiA+PiBAQCAtODQzLDcgKzg0Myw3IEBAIHN0YXRpYyB2b2lkIGludGVsX3Bzcl93b3JrKHN0cnVj dCB3b3JrX3N0cnVjdCAqd29yaykNCj4gPj4gIAkgKiByZWNoZWNrLiBTaW5jZSBwc3JfZmx1c2gg Zmlyc3QgY2xlYXJzIHRoaXMgYW5kIHRoZW4gcmVzY2hlZHVsZXMgd2UNCj4gPj4gIAkgKiB3b24n dCBldmVyIG1pc3MgYSBmbHVzaCB3aGVuIGJhaWxpbmcgb3V0IGhlcmUuDQo+ID4+ICAJICovDQo+ ID4+IC0JaWYgKGRldl9wcml2LT5wc3IuYnVzeV9mcm9udGJ1ZmZlcl9iaXRzKQ0KPiA+PiArCWlm IChkZXZfcHJpdi0+cHNyLmJ1c3lfZnJvbnRidWZmZXJfYml0cyB8fCAhaTkxNV9tb2RwYXJhbXMu ZW5hYmxlX3BzcikNCj4gPj4gIAkJZ290byB1bmxvY2s7DQo+ID4+ICANCj4gPj4gIAlpbnRlbF9w c3JfYWN0aXZhdGUoaW50ZWxfZHApOw0KPiA+PiBAQCAtMTAxNSw3ICsxMDE1LDggQEAgdm9pZCBp bnRlbF9wc3JfZmx1c2goc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LA0KPiA+PiAg CQlyZXR1cm47DQo+ID4+ICANCj4gPj4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+cHNyLmxvY2sp Ow0KPiA+PiAtCWlmICghZGV2X3ByaXYtPnBzci5lbmFibGVkKSB7DQo+ID4+ICsJaWYgKCFkZXZf cHJpdi0+cHNyLmVuYWJsZWQgfHwgIWk5MTVfbW9kcGFyYW1zLmVuYWJsZV9wc3IpIHsNCj4gPj4g KwkJaW50ZWxfcHNyX2V4aXQoZGV2X3ByaXYpOw0KPiA+PiAgCQltdXRleF91bmxvY2soJmRldl9w cml2LT5wc3IubG9jayk7DQo+ID4+ICAJCXJldHVybjsNCj4gPj4gIAl9DQo+IA0KPiANCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=