From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Paul Subject: Re: [PATCH v3 1/5] drm/i915: Move DP modeset retry work into intel_dp Date: Tue, 13 Mar 2018 19:24:20 -0400 Message-ID: <1520983460.24712.3.camel@redhat.com> References: <20180308232421.14049-1-lyude@redhat.com> <20180309213232.19855-1-lyude@redhat.com> <20180312210102.GR5453@intel.com> Reply-To: lyude@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id C6E546E02F for ; Tue, 13 Mar 2018 23:24:22 +0000 (UTC) Received: by mail-qt0-f196.google.com with SMTP id z14so1586101qti.2 for ; Tue, 13 Mar 2018 16:24:22 -0700 (PDT) In-Reply-To: <20180312210102.GR5453@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE4LTAzLTEyIGF0IDIzOjAxICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gRnJpLCBNYXIgMDksIDIwMTggYXQgMDQ6MzI6MjdQTSAtMDUwMCwgTHl1ZGUgUGF1bCB3 cm90ZToKPiA+IFdoaWxlIGhhdmluZyB0aGUgbW9kZXNldF9yZXRyeV93b3JrIGluIGludGVsX2Nv bm5lY3RvciBtYWtlcyBzZW5zZSB3aXRoCj4gPiBTU1QsIHRoaXMgcGFyYWRpZ20gZG9lc24ndCBt YWtlIGEgd2hvbGUgdG9uIG9mIHNlbnNlIHdoZW4gaXQgY29tZXMgdG8KPiA+IE1TVCBzaW5jZSB3 ZSBoYXZlIHRvIGRlYWwgd2l0aCBtdWx0aXBsZSBjb25uZWN0b3JzLiBJbiBtb3N0IGNhc2VzLCBp dCdzCj4gPiBtb3JlIHVzZWZ1bCB0byBqdXN0IHVzZSB0aGUgaW50ZWxfZHAgc3RydWN0IHNpbmNl IGl0IGluZGljYXRlcyB3aGV0aGVyCj4gPiBvciBub3Qgd2UncmUgZGVhbGluZyB3aXRoIGFuIE1T VCBkZXZpY2UsIGFsb25nIHdpdGggYmVpbmcgYWJsZSB0byBlYXNpbHkKPiA+IHRyYWNlIHRoZSBp bnRlbF9kcCBzdHJ1Y3QgYmFjayB0byBpdCdzIHJlc3BlY3RpdmUgY29ubmVjdG9yIChpZiB0aGVy ZSBpcwo+ID4gYW55KS4gU28sIG1vdmUgdGhlIG1vZGVzZXRfcmV0cnlfd29yayBmdW5jdGlvbiBv dXQgb2YgdGhlCj4gPiBpbnRlbF9jb25uZWN0b3Igc3RydWN0IGFuZCBpbnRvIGludGVsX2RwLgo+ ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29tPgo+ID4g UmV2aWV3ZWQtYnk6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4g PiBDYzogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiA+IENjOiBW aWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gCj4gPiBW MjoKPiA+ICAtIFJlbW92ZSBhY2NpZGVudGFsIGR1cGxpY2F0ZSBtb2Rlc2V0X3JldHJ5X3dvcmsg aW4gaW50ZWxfY29ubmVjdG9yCj4gPiBWMzoKPiA+ICAtIEFsc28gY2hlY2sgYWdhaW5zdCBlRFAg aW4gaW50ZWxfaHBkX3BvbGxfZmluaSgpIC0gbWRuYXZhcmUKPiA+IFNpZ25lZC1vZmYtYnk6IEx5 dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMgICAgICAgICAgfCAyNSArKysrKysrKysrKysrKysrKysrKysr Ky0KPiA+IC0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICAgICAgICAgICAg ICAgfCAxMCArKysrLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlu a190cmFpbmluZy5jIHwgIDIgKy0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYu aCAgICAgICAgICAgICAgfCAgNiArKystLS0KPiA+ICA0IGZpbGVzIGNoYW5nZWQsIDMxIGluc2Vy dGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggZjQyNGZmZjQ3N2Y2Li4zYjdmYTQzMGE4NGEgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gQEAgLTE1Mzk0LDE2ICsx NTM5NCwzNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9ocGRfcG9sbF9maW5pKHN0cnVjdCBkcm1fZGV2 aWNlCj4gPiAqZGV2KQo+ID4gIHsKPiA+ICAJc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVj dG9yOwo+ID4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9saXN0X2l0ZXIgY29ubl9pdGVyOwo+ID4g KwlzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcms7Cj4gPiArCWludCBjb25uX3R5cGU7Cj4gPiAgCj4g PiAgCS8qIEtpbGwgYWxsIHRoZSB3b3JrIHRoYXQgbWF5IGhhdmUgYmVlbiBxdWV1ZWQgYnkgaHBk LiAqLwo+ID4gIAlkcm1fY29ubmVjdG9yX2xpc3RfaXRlcl9iZWdpbihkZXYsICZjb25uX2l0ZXIp Owo+ID4gIAlmb3JfZWFjaF9pbnRlbF9jb25uZWN0b3JfaXRlcihjb25uZWN0b3IsICZjb25uX2l0 ZXIpIHsKPiA+IC0JCWlmIChjb25uZWN0b3ItPm1vZGVzZXRfcmV0cnlfd29yay5mdW5jKQo+ID4g LQkJCWNhbmNlbF93b3JrX3N5bmMoJmNvbm5lY3Rvci0+bW9kZXNldF9yZXRyeV93b3JrKTsKPiA+ ICAJCWlmIChjb25uZWN0b3ItPmhkY3Bfc2hpbSkgewo+ID4gIAkJCWNhbmNlbF9kZWxheWVkX3dv cmtfc3luYygmY29ubmVjdG9yLQo+ID4gPmhkY3BfY2hlY2tfd29yayk7Cj4gPiAgCQkJY2FuY2Vs X3dvcmtfc3luYygmY29ubmVjdG9yLT5oZGNwX3Byb3Bfd29yayk7Cj4gPiAgCQl9Cj4gPiArCj4g PiArCQljb25uX3R5cGUgPSBjb25uZWN0b3ItPmJhc2UuY29ubmVjdG9yX3R5cGU7Cj4gPiArCQlp ZiAoY29ubl90eXBlICE9IERSTV9NT0RFX0NPTk5FQ1RPUl9lRFAgJiYKPiA+ICsJCSAgICBjb25u X3R5cGUgIT0gRFJNX01PREVfQ09OTkVDVE9SX0Rpc3BsYXlQb3J0KQo+ID4gKwkJCWNvbnRpbnVl Owo+ID4gKwo+ID4gKwkJaWYgKGNvbm5lY3Rvci0+bXN0X3BvcnQpIHsKPiA+ICsJCQl3b3JrID0g JmNvbm5lY3Rvci0+bXN0X3BvcnQtPm1vZGVzZXRfcmV0cnlfd29yazsKPiA+ICsJCX0gZWxzZSB7 Cj4gPiArCQkJc3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXIgPQo+ID4gKwkJCQlj b25uZWN0b3ItPmVuY29kZXI7Cj4gPiArCQkJc3RydWN0IGludGVsX2RwICppbnRlbF9kcDsKPiA+ ICsKPiA+ICsJCQlpZiAoIWludGVsX2VuY29kZXIpCj4gPiArCQkJCWNvbnRpbnVlOwo+ID4gKwo+ ID4gKwkJCWludGVsX2RwID0gZW5jX3RvX2ludGVsX2RwKCZpbnRlbF9lbmNvZGVyLT5iYXNlKTsK PiA+ICsJCQl3b3JrID0gJmludGVsX2RwLT5tb2Rlc2V0X3JldHJ5X3dvcms7Cj4gPiArCQl9Cj4g PiArCj4gPiArCQljYW5jZWxfd29ya19zeW5jKHdvcmspOwo+IAo+IFdoeSBhcmUgd2UgZXZlbiB3 YWxraW5nIHRoZSBjb25uZWN0b3JzIGZvciB0aGlzPyBDYW4ndCB3ZSBqdXN0Cj4gd2FsayB0aGUg ZW5jb2RlcnMgaW5zdGVhZD8KV2UgY291bGQgd2FsayB0aGUgZW5jb2RlcnMgZm9yIHRoaXMsIGJ1 dCBzZWVpbmcgYXMgd2UncmUgYWxyZWFkeSB3YWxraW5nIHRoZQpjb25uZWN0b3JzIGZvciB0aGUg SERDUCBwcm9wIGRvZXNuJ3QgaXQgbWFrZSBtb3JlIHNlbnNlIHRvIGp1c3Qgc3RpY2sgb3VyIGNv ZGUKdGhlcmU/IG9yIGlzIHRoZXJlIGEgc2ltcGxlciBzb2x1dGlvbiBmb3IgdGhpcyBJJ20gbWlz c2luZwo+IAo+ID4gIAl9Cj4gPiAgCWRybV9jb25uZWN0b3JfbGlzdF9pdGVyX2VuZCgmY29ubl9p dGVyKTsKPiA+ICB9Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHAuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBpbmRleCA0ZGQx YjIyODdkZDYuLjVhYmYwYzk1NzI1YSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMK PiA+IEBAIC02MjYxLDEyICs2MjYxLDEwIEBAIHN0YXRpYyBib29sIGludGVsX2VkcF9pbml0X2Nv bm5lY3RvcihzdHJ1Y3QgaW50ZWxfZHAKPiA+ICppbnRlbF9kcCwKPiA+ICAKPiA+ICBzdGF0aWMg dm9pZCBpbnRlbF9kcF9tb2Rlc2V0X3JldHJ5X3dvcmtfZm4oc3RydWN0IHdvcmtfc3RydWN0ICp3 b3JrKQo+ID4gIHsKPiA+IC0Jc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxfY29ubmVjdG9y Owo+ID4gLQlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ID4gKwlzdHJ1Y3QgaW50 ZWxfZHAgKmludGVsX2RwID0gY29udGFpbmVyX29mKHdvcmssIHR5cGVvZigqaW50ZWxfZHApLAo+ ID4gKwkJCQkJCSBtb2Rlc2V0X3JldHJ5X3dvcmspOwo+ID4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3Rv ciAqY29ubmVjdG9yID0gJmludGVsX2RwLT5hdHRhY2hlZF9jb25uZWN0b3ItCj4gPiA+YmFzZTsK PiA+ICAKPiA+IC0JaW50ZWxfY29ubmVjdG9yID0gY29udGFpbmVyX29mKHdvcmssIHR5cGVvZigq aW50ZWxfY29ubmVjdG9yKSwKPiA+IC0JCQkJICAgICAgIG1vZGVzZXRfcmV0cnlfd29yayk7Cj4g PiAtCWNvbm5lY3RvciA9ICZpbnRlbF9jb25uZWN0b3ItPmJhc2U7Cj4gPiAgCURSTV9ERUJVR19L TVMoIltDT05ORUNUT1I6JWQ6JXNdXG4iLCBjb25uZWN0b3ItPmJhc2UuaWQsCj4gPiAgCQkgICAg ICBjb25uZWN0b3ItPm5hbWUpOwo+ID4gIAo+ID4gQEAgLTYyOTUsNyArNjI5Myw3IEBAIGludGVs X2RwX2luaXRfY29ubmVjdG9yKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQKPiA+ICppbnRlbF9k aWdfcG9ydCwKPiA+ICAJaW50IHR5cGU7Cj4gPiAgCj4gPiAgCS8qIEluaXRpYWxpemUgdGhlIHdv cmsgZm9yIG1vZGVzZXQgaW4gY2FzZSBvZiBsaW5rIHRyYWluIGZhaWx1cmUgKi8KPiA+IC0JSU5J VF9XT1JLKCZpbnRlbF9jb25uZWN0b3ItPm1vZGVzZXRfcmV0cnlfd29yaywKPiA+ICsJSU5JVF9X T1JLKCZpbnRlbF9kcC0+bW9kZXNldF9yZXRyeV93b3JrLAo+ID4gIAkJICBpbnRlbF9kcF9tb2Rl c2V0X3JldHJ5X3dvcmtfZm4pOwo+ID4gIAo+ID4gIAlpZiAoV0FSTihpbnRlbF9kaWdfcG9ydC0+ bWF4X2xhbmVzIDwgMSwKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcF9saW5rX3RyYWluaW5nLmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBf bGlua190cmFpbmluZy5jCj4gPiBpbmRleCBmNTliNTliYjBhMjEuLjJjZmE1OGNlMWY5NSAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX2xpbmtfdHJhaW5pbmcu Ywo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5j Cj4gPiBAQCAtMzQwLDcgKzM0MCw3IEBAIGludGVsX2RwX3N0YXJ0X2xpbmtfdHJhaW4oc3RydWN0 IGludGVsX2RwICppbnRlbF9kcCkKPiA+ICAJCQkJCQkJICAgICBpbnRlbF9kcC0KPiA+ID5saW5r X3JhdGUsCj4gPiAgCQkJCQkJCSAgICAgaW50ZWxfZHAtCj4gPiA+bGFuZV9jb3VudCkpCj4gPiAg CQkJLyogU2NoZWR1bGUgYSBIb3RwbHVnIFVldmVudCB0byB1c2Vyc3BhY2UgdG8gc3RhcnQKPiA+ IG1vZGVzZXQgKi8KPiA+IC0JCQlzY2hlZHVsZV93b3JrKCZpbnRlbF9jb25uZWN0b3ItCj4gPiA+ bW9kZXNldF9yZXRyeV93b3JrKTsKPiA+ICsJCQlzY2hlZHVsZV93b3JrKCZpbnRlbF9kcC0+bW9k ZXNldF9yZXRyeV93b3JrKTsKPiA+ICAJfSBlbHNlIHsKPiA+ICAJCURSTV9FUlJPUigiW0NPTk5F Q1RPUjolZDolc10gTGluayBUcmFpbmluZyBmYWlsZWQgYXQgbGluawo+ID4gcmF0ZSA9ICVkLCBs YW5lIGNvdW50ID0gJWQiLAo+ID4gIAkJCSAgaW50ZWxfY29ubmVjdG9yLT5iYXNlLmJhc2UuaWQs Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+IGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+IGluZGV4IDgzZTVjYTg4OWQ5Yy4u M2YxOWRjODA5OTdmIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiBAQCAt NDA2LDkgKzQwNiw2IEBAIHN0cnVjdCBpbnRlbF9jb25uZWN0b3Igewo+ID4gIAo+ID4gIAlzdHJ1 Y3QgaW50ZWxfZHAgKm1zdF9wb3J0Owo+ID4gIAo+ID4gLQkvKiBXb3JrIHN0cnVjdCB0byBzY2hl ZHVsZSBhIHVldmVudCBvbiBsaW5rIHRyYWluIGZhaWx1cmUgKi8KPiA+IC0Jc3RydWN0IHdvcmtf c3RydWN0IG1vZGVzZXRfcmV0cnlfd29yazsKPiA+IC0KPiA+ICAJY29uc3Qgc3RydWN0IGludGVs X2hkY3Bfc2hpbSAqaGRjcF9zaGltOwo+ID4gIAlzdHJ1Y3QgbXV0ZXggaGRjcF9tdXRleDsKPiA+ ICAJdWludDY0X3QgaGRjcF92YWx1ZTsgLyogcHJvdGVjdGVkIGJ5IGhkY3BfbXV0ZXggKi8KPiA+ IEBAIC0xMTM1LDYgKzExMzIsOSBAQCBzdHJ1Y3QgaW50ZWxfZHAgewo+ID4gIAo+ID4gIAkvKiBE aXNwbGF5cG9ydCBjb21wbGlhbmNlIHRlc3RpbmcgKi8KPiA+ICAJc3RydWN0IGludGVsX2RwX2Nv bXBsaWFuY2UgY29tcGxpYW5jZTsKPiA+ICsKPiA+ICsJLyogV29yayBzdHJ1Y3QgdG8gc2NoZWR1 bGUgYSB1ZXZlbnQgb24gbGluayB0cmFpbiBmYWlsdXJlICovCj4gPiArCXN0cnVjdCB3b3JrX3N0 cnVjdCBtb2Rlc2V0X3JldHJ5X3dvcms7Cj4gPiAgfTsKPiA+ICAKPiA+ICBzdHJ1Y3QgaW50ZWxf bHNwY29uIHsKPiA+IC0tIAo+ID4gMi4xNC4zCj4gCj4gCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=