intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Mika Kahola <mika.kahola@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Hans de Goede <j.w.r.degoede@gmail.com>
Subject: Re: [PATCH 7/7] drm/i915: s/plane/i9xx_plane/
Date: Fri, 01 Jun 2018 13:29:12 +0300	[thread overview]
Message-ID: <1527848952.27355.11.camel@intel.com> (raw)
In-Reply-To: <20180130203807.13721-7-ville.syrjala@linux.intel.com>

On Tue, 2018-01-30 at 22:38 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Call the enum i9xx_plane_id variable i9xx_plane like we do elsewhere.
> 
> Cc: Hans de Goede <j.w.r.degoede@gmail.com>

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dsi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c
> b/drivers/gpu/drm/i915/intel_dsi.c
> index 51a1d6868b1e..9f378aa2dc5b 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -1665,16 +1665,16 @@ static int
> intel_dsi_get_panel_orientation(struct intel_connector *connector)
>  {
>  	struct drm_i915_private *dev_priv = to_i915(connector-
> >base.dev);
>  	int orientation = DRM_MODE_PANEL_ORIENTATION_NORMAL;
> -	enum i9xx_plane_id plane;
> +	enum i9xx_plane_id i9xx_plane;
>  	u32 val;
>  
>  	if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) {
>  		if (connector->encoder->crtc_mask == BIT(PIPE_B))
> -			plane = PLANE_B;
> +			i9xx_plane = PLANE_B;
>  		else
> -			plane = PLANE_A;
> +			i9xx_plane = PLANE_A;
>  
> -		val = I915_READ(DSPCNTR(plane));
> +		val = I915_READ(DSPCNTR(i9xx_plane));
>  		if (val & DISPPLANE_ROTATE_180)
>  			orientation =
> DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP;
>  	}
-- 
Mika Kahola - Intel OTC

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-06-01 10:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30 20:38 [PATCH 1/7] drm/i915: Don't set cursor pipe select bits on g4x+ Ville Syrjala
2018-01-30 20:38 ` [PATCH 2/7] drm/i915: Set the primary plane pipe select bits on gen4 Ville Syrjala
2018-02-02  9:15   ` Mika Kahola
2018-01-30 20:38 ` [PATCH 3/7] drm/i915: Have plane->get_hw_state() return the current pipe Ville Syrjala
2018-06-01  8:38   ` Mika Kahola
2018-01-30 20:38 ` [PATCH 4/7] drm/i915: Clean up cursor defines Ville Syrjala
2018-01-31 14:37   ` [PATCH v2 " Ville Syrjala
2018-06-01  8:42     ` Mika Kahola
2018-01-30 20:38 ` [PATCH 5/7] drm/i915: Disable trickle feed for SNB/IVB cursors Ville Syrjala
2018-06-01 10:25   ` Mika Kahola
2018-01-30 20:38 ` [PATCH 6/7] drm/i915: Drop WaDoubleCursorLP3Latency:ivb Ville Syrjala
2018-01-31 14:10   ` Mika Kahola
2018-02-20 19:01     ` Ville Syrjälä
2018-01-30 20:38 ` [PATCH 7/7] drm/i915: s/plane/i9xx_plane/ Ville Syrjala
2018-06-01 10:29   ` Mika Kahola [this message]
2018-06-01 15:52     ` Ville Syrjälä
2018-01-30 21:03 ` ✗ Fi.CI.BAT: failure for series starting with [1/7] drm/i915: Don't set cursor pipe select bits on g4x+ Patchwork
2018-01-31 14:55 ` ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Don't set cursor pipe select bits on g4x+ (rev2) Patchwork
2018-01-31 17:18 ` ✓ Fi.CI.IGT: " Patchwork
2018-02-01 13:32 ` [PATCH 1/7] drm/i915: Don't set cursor pipe select bits on g4x+ Mika Kahola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1527848952.27355.11.camel@intel.com \
    --to=mika.kahola@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=j.w.r.degoede@gmail.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).