From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhinakaran Pandiyan Subject: Re: [PATCH] drm/i915/psr: Enable PSR1 by default on gen9+ platforms Date: Wed, 25 Jul 2018 09:52:44 -0700 Message-ID: <1532537564.3356.73.camel@intel.com> References: <20180725072228.2469-1-dhinakaran.pandiyan@intel.com> <20180725161231.GF16907@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 31FAD89F31 for ; Wed, 25 Jul 2018 16:28:48 +0000 (UTC) In-Reply-To: <20180725161231.GF16907@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE4LTA3LTI1IGF0IDA5OjEyIC0wNzAwLCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4g T24gV2VkLCBKdWwgMjUsIDIwMTggYXQgMTI6MjI6MjhBTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiA+IAo+ID4gV2UgaGF2ZSBtZXJnZWQgc2V2ZXJhbCBmaXhlcywgcmUtd3Jp dHRlbiBzb21lIHRlc3RzIGFuZCBpbXByb3ZlZAo+ID4gZGVidWcKPiA+IGNhcGFiaWxpdHkgaW4g dGhlIHBhc3Qgc2V2ZXJhbCBtb250aHMsIHNvIHRoaXMgaXMgYSBnb29kIHRpbWUgdG8KPiA+IGdp dmUgUFNSMQo+ID4gYW5vdGhlciB0cnkuIFBTUjEgaGFzIG5vdCBiZWVuIHRlc3RlZCBvbiBIU1cg YW5kIEJEVyByZWNlbnRseSwgc28KPiA+IGxldCdzCj4gPiBlbmFibGUgb25seSBvbiBnZW45KyBu b3cuCj4gPiAKPiA+IENjOiBSb2RpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+ IENjOiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4KPiA+IFNp Z25lZC1vZmYtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50 ZWwuY29tPgo+ID4gLS0tCj4gPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIHwg MjAgKysrKysrKysrKy0tLS0tLS0tLS0KPiA+IMKgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlv bnMoKyksIDEwIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNy LmMKPiA+IGluZGV4IDRiZDU3Njg3MzFlZS4uOTQyZGI4NWRhNmExIDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3Bzci5jCj4gPiBAQCAtNDcxLDEwICs0NzEsOCBAQCB2b2lkIGludGVsX3Bz cl9jb21wdXRlX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZHAKPiA+ICppbnRlbF9kcCwKPiA+IMKgCWlm ICghQ0FOX1BTUihkZXZfcHJpdikpCj4gPiDCoAkJcmV0dXJuOwo+ID4gwqAKPiA+IC0JaWYgKCFp OTE1X21vZHBhcmFtcy5lbmFibGVfcHNyKSB7Cj4gPiAtCQlEUk1fREVCVUdfS01TKCJQU1IgZGlz YWJsZSBieSBmbGFnXG4iKTsKPiBXaHkgYXJlIHlvdSByZW1vdmluZyB0aGUgbWVzc2FnZT8KPiBJ IHRoaW5rIGl0IGlzIHN0aWxsIHVzZWZ1bC4uLiBhbmQgZW5hYmxlX3BzciA9PSAtMSBkb2Vzbid0 IHRyaWdnZXIKPiB0aGF0Lgo+IApUaGUgdGV4dCB3YXMgYSBiaXQgdmFndWUgdG8gc3RhcnQgd2l0 aCwgYW5kIGlzIGNvbmZ1c2luZyB3aGVuIGNvbWJpbmVkCndpdGggdGhpcyBwYXRjaC4gQWdyZWVk LCBpdCBpcyB1c2VmdWwgdG8gaGF2ZSBhIGRlYnVnIG1lc3NhZ2UsIEknbGwKcmVwbGFjZSBpdC4K Cj4gPiAKPiA+ICsJaWYgKCFpOTE1X21vZHBhcmFtcy5lbmFibGVfcHNyKQo+ID4gwqAJCXJldHVy bjsKPiA+IC0JfQo+ID4gwqAKPiA+IMKgCS8qCj4gPiDCoAnCoCogSFNXIHNwZWMgZXhwbGljaXRs eSBzYXlzIFBTUiBpcyB0aWVkIHRvIHBvcnQgQS4KPiA+IEBAIC01MTYsNyArNTE0LDExIEBAIHZv aWQgaW50ZWxfcHNyX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9kcAo+ID4gKmludGVsX2Rw LAo+ID4gwqAJfQo+ID4gwqAKPiA+IMKgCWNydGNfc3RhdGUtPmhhc19wc3IgPSB0cnVlOwo+ID4g LQljcnRjX3N0YXRlLT5oYXNfcHNyMiA9IGludGVsX3BzcjJfY29uZmlnX3ZhbGlkKGludGVsX2Rw LAo+ID4gY3J0Y19zdGF0ZSk7Cj4gPiArCj4gPiArCS8qIEVuYWJsZSBvbmx5IFBTUiAxIGJ5IGRl ZmF1bHQgZm9yIG5vdyAqLwo+ID4gKwljcnRjX3N0YXRlLT5oYXNfcHNyMiA9IGk5MTVfbW9kcGFy YW1zLmVuYWJsZV9wc3IgPT0gMSAmJgo+ID4gKwkJCcKgwqDCoMKgwqDCoMKgaW50ZWxfcHNyMl9j b25maWdfdmFsaWQoaW50ZWxfZHAsCj4gPiBjcnRjX3N0YXRlKTsKPiA+ICsKPiB0aGlzIG1pZ2h0 IGdldCBjb25mdXNpbmcuLi4KPiAtMSAtIGVuYWJsZSBwc3IxCj4gMCAtIGRpc2FibGUKPiAxIC0g ZW5hYmxlIHBzcjIKPiAKPiBhbmQgZmFyIGZyb20gdGhlIHZhcmlhYmxlLi4uIFdlbGwuLi4gSSB3 YW50IHRvIGtpbGwgdGhlIHBhcmFtZXRlcgo+IGFueXdheXMKPiBzbyBubyBoYXJkIGZlZWxpbmdz IG9uIGhhdmluZyB0aGlzIGhlcmUsIGJ1dCB3aGF0IGFib3V0IHNvbWUgZGVidWcKPiBtZXNzYWdl cwo+IGF0IGxlYXN0Pwo+IAo+IC8qIEVuYWJsZSBvbmx5IFBTUjEgYnkgZGVmYXVsdCBmb3Igbm93 ICovCj4gaWYgKGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9wc3IgPT0gLTEpIHsKPiAJRFJNX0RFQlVH X0tNUygiQXZvaWRpbmcgUFNSMiBieSBwbGF0Zm9ybSBkZWZhdWx0IikKPiAJY3J0Y19zdGF0ZS0+ aGFzX3BzcjIgPSAwOwo+IH0gZWxzZSB7Cj4gCWNydGNfc3RhdGUtPmhhc19wc3IyID0gaW50ZWxf cHNyMl9jb25maWdfdmFsaWQoaW50ZWxfZHAsCj4gY3J0Y19zdGF0ZSk7Cj4gfQo+IAoKVGhlIHJl YXNvbiBJIGFkZGVkIGEgY2hlY2sgZm9yIGk5MTUuZW5hYmxlX3Bzcj09MSB3YXMgdG8gZW5hYmxl IFBTUjIKb25seSB3aGVuIHRoZSB1c2VyIHBhc3NlcyB0aGUgZXhhY3QgdmFsdWUuIE90aGVyd2lz ZSwgd2Ugc2hvdWxkIGZhbGwKYmFjayB0byBkZWZhdWx0LgoKPiA+IAo+ID4gwqAJRFJNX0RFQlVH X0tNUygiRW5hYmxpbmcgUFNSJXNcbiIsIGNydGNfc3RhdGUtPmhhc19wc3IyID8KPiA+ICIyIiA6 ICIiKTsKPiA+IMKgfQo+ID4gwqAKPiA+IEBAIC05NTYsMTIgKzk1OCwxMCBAQCB2b2lkIGludGVs X3Bzcl9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlCj4gPiAqZGV2X3ByaXYpCj4gPiDCoAlp ZiAoIWRldl9wcml2LT5wc3Iuc2lua19zdXBwb3J0KQo+ID4gwqAJCXJldHVybjsKPiA+IMKgCj4g PiAtCWlmIChpOTE1X21vZHBhcmFtcy5lbmFibGVfcHNyID09IC0xKSB7Cj4gPiAtCQlpOTE1X21v ZHBhcmFtcy5lbmFibGVfcHNyID0gZGV2X3ByaXYtCj4gPiA+dmJ0LnBzci5lbmFibGU7Cj4gPiAt Cj4gPiAtCQkvKiBQZXIgcGxhdGZvcm0gZGVmYXVsdDogYWxsIGRpc2FibGVkLiAqLwo+ID4gLQkJ aTkxNV9tb2RwYXJhbXMuZW5hYmxlX3BzciA9IDA7Cj4gPiAtCX0KPiA+ICsJLyogRW5hYmxlIFBT UiAxIGRlZmF1bHQgb25seSBvbiBnZW45KyAqLwo+ID4gKwlpZiAoaTkxNV9tb2RwYXJhbXMuZW5h YmxlX3BzciA9PSAtMSkKPiA+ICsJCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDwgOSB8fCAhZGV2 X3ByaXYtCj4gPiA+dmJ0LnBzci5lbmFibGUpCj4gPiArCQkJaTkxNV9tb2RwYXJhbXMuZW5hYmxl X3BzciA9IDA7Cj4gd2UgdGFsa2VkIGFib3V0IHRoaXMgaW4gcGVyc29uLCBidXQganVzdCBmb3Ig dGhlIHJlY29yZDoKPiB3ZSBuZWVkIHRvIGNoZWNrIGNubCBhbmQgaWNsIG9uIENJIGZvciBwc3Ig Y2FzZXMgYmVmb3JlIG1ha2UgdGhpcyA+Cj4gOS4KClRoZSBmYWlsdXJlcyBvbiBJQ0wgYXJlIGR1 ZSB0byBhbiB1bnJlbGF0ZWQgZGVidWcgd2FybmluZy4gVGhlIENOTCBvbmVzCmFyZSBpbnRlcmVz dGluZywgbW9zdCBsaWtlbHkgZHVlIHRvIHVzIGVuYWJsaW5nIFBTUjIgYnkgc2V0dGluZyB0aGUK bW9kdWxlIHBhcmFtZXRlcj0xIGZyb20gdGhlIElHVHMuIEJ1dCwgaXQgc3RpbGwgc2hvdWxkIG5v dCBiZSBmYWlsaW5nLApJJ2xsIGNoZWNrLgoKCgo+IAo+ID4gCj4gPiAKPiA+IMKgCS8qIFNldCBs aW5rX3N0YW5kYnkgeCBsaW5rX29mZiBkZWZhdWx0cyAqLwo+ID4gwqAJaWYgKElTX0hBU1dFTEwo ZGV2X3ByaXYpIHx8IElTX0JST0FEV0VMTChkZXZfcHJpdikpCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=