From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH] drm/i915/icl: implement icl_digital_port_connected() Date: Wed, 25 Jul 2018 09:59:55 -0700 Message-ID: <1532537995.2522.4.camel@intel.com> References: <20180725002813.6938-1-paulo.r.zanoni@intel.com> <20180725002813.6938-2-paulo.r.zanoni@intel.com> <20180725011923.GA3771@ldmartin-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF4C46E003 for ; Wed, 25 Jul 2018 16:59:55 +0000 (UTC) In-Reply-To: <20180725011923.GA3771@ldmartin-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org RW0gVGVyLCAyMDE4LTA3LTI0IMOgcyAxODoxOSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hpIGVzY3Jl dmV1Ogo+IE9uIFR1ZSwgSnVsIDI0LCAyMDE4IGF0IDA1OjI4OjA5UE0gLTA3MDAsIFBhdWxvIFph bm9uaSB3cm90ZToKPiA+IERvIGxpa2UgdGhlIG90aGVyIGZ1bmN0aW9ucyBhbmQgY2hlY2sgZm9y IHRoZSBzdGF0dXMgYml0cy4gVGhlICJIb3QKPiA+IFBsdWcgRGV0ZWN0aW9uIiBwYWdlIGZyb20g b3VyIGRvY3VtZW50YXRpb24gc2F5cyB3ZSBjYW4ndCBqdXN0IHVzZQo+ID4gdGhlCj4gPiBJU1Ig Yml0cyBvbiB0aGUgQ1BVIHNpZGUsIHNvIHVzZSB0aGUgY29ycmVjdCByZWdpc3RlcnMuCj4gCj4g bml0OiBoZXJlIHlvdSBhcmUgc2F5aW5nIGl0J3MgZm9yIGFsbCBvZiB0aGVtIHJhdGhlciB0aGFu IGp1c3QgYQo+IHN1YnNldC4KCk5vLCBJJ20gc2F5aW5nIGl0J3MgZm9yIHRoZSBDUFUgc2lkZSwg dGhlIENQVSBzaWRlIGlzIGEgc3Vic2V0IHdoaWNoCmV4Y2x1ZGVzIHRoZSBQQ0guIFRoZXJlIGFy ZSAzIHR5cGVzOiB0aGUgbGVnYWN5IG9uZXMgKG9uIHRoZSBQQ0gsIG5vdApDUFUpLCB0aGUgVEMg b25lcyAob24gdGhlIENQVSkgYW5kIHRoZSBUQlQgb25lcyAob24gdGhlIENQVSB0b28pLiBPbgpv dXIgZHJpdmVyLCAiQ1BVIiBpbiB0aGVzZSBjb250ZXh0cyBoYXMgYmVlbiB1c2VkIGFzIGEgc3lu b255bSBmb3IKTm9ydGggRGlzcGxheSBzaW5jZSB0aGUgUENIIHdhcyBpbnRyb2R1Y2VkLgoKQnV0 IEkgY2FuIGJlIG1vcmUgZXhwbGljaXQgaWYgeW91IHdhbnQsIG5vIHByb2JsZW0uCgo+IE15IHN1 Z2dlc3Rpb24gaXM6Cj4gCj4gRG8gbGlrZSB0aGUgb3RoZXIgZnVuY3Rpb25zIGFuZCBjaGVjayBm b3IgdGhlIHN0YXR1cyBiaXRzLiBGb3IKPiBUeXBlQy9UQlQKPiBvbiBOb3J0aCBEaXNwbGF5IEVu Z2luZSB0aGUgIkhvdCBQbHVnIERldGVjdGlvbiIgcGFnZSBmcm9tIG91cgo+IGRvY3VtZW50YXRp b24gc2F5cyB3ZSBjYW4ndCBqdXN0IHVzZSB0aGUgSVNSIGJpdHMgdG8gZmluZCB0aGUgbGl2ZQo+ IHN0YXRlLCBzbyB1c2UgdGhlIGNvcnJlY3QgcmVnaXN0ZXJzOiBERkxFWERQU1AgVEMgTGl2ZSBT dGF0ZSBmaWVsZC4KPiAKPiAKPiA+IAo+ID4gdjI6IFJlYmFzZS4KPiA+IHYzOgo+ID4gICAtIFNp bXBsaWZ5IHRydWUvZmFsc2UgYXNzaWdubWVudCAoUm9kcmlnbykuCj4gPiAgIC0gUmVvcmdhbml6 ZSBpc19nZW4gaWYgbGFkZGVyIChSb2RyaWdvKS4KPiA+ICAgLSBEb24ndCB1c2UgdGhlIElTUiBm b3IgVEMvVEJUIENQVSBiaXRzLgo+ID4gCj4gPiBDYzogQW5pbWVzaCBNYW5uYSA8YW5pbWVzaC5t YW5uYUBpbnRlbC5jb20+Cj4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwu Y29tPgo+ID4gU2lnbmVkLW9mZi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwu Y29tPgo+ID4gU2lnbmVkLW9mZi1ieTogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRl bC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIHwgIDgg KysrKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgNTUKPiA+ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgNjIgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBNeSB1bmRlcnN0YW5kaW5nIGlzIHRo YXQgdGhlcmUncyBhZ3JlZW1lbnQgb24gdGhpcyBwYXRjaCBzaW5jZSBpdAo+ID4ganVzdAo+ID4g bWltaWNrcyB3aGF0IHRoZSBvdGhlciBnZW5zIGRvLiBMZXQncyBoYXZlIHRoaXMgb25lIGFncmVl ZCBvbgo+ID4gKG1lcmdlZCkKPiA+IGZpcnN0IGJlZm9yZSB3ZSBjb250aW51ZSB0aGUgZGlzY3Vz c2lvbnMsIGVzcGVjaWFsbHkgc2luY2UgdGhpcyBvbmUKPiA+IHNpZ25pZmljYW50bHkgYWZmZWN0 cyB0aGUgQ0kgc3lzdGVtLgo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9yZWcuaAo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPiBp bmRleCA3Mzk0NjA1NWFhMTUuLjNlYWZmMzJkZDc0ZSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfcmVnLmgKPiA+IEBAIC03MjEwLDYgKzcyMTAsNyBAQCBlbnVtIHsKPiA+ICAjZGVmaW5lICBH RU4xMV9UQzNfSE9UUExVRwkJCSgxIDw8IDE4KQo+ID4gICNkZWZpbmUgIEdFTjExX1RDMl9IT1RQ TFVHCQkJKDEgPDwgMTcpCj4gPiAgI2RlZmluZSAgR0VOMTFfVEMxX0hPVFBMVUcJCQkoMSA8PCAx NikKPiA+ICsjZGVmaW5lICBHRU4xMV9UQ19IT1RQTFVHKHRjX3BvcnQpCQkoMSA8PCAoKHRjX3Bv cnQpCj4gPiArIDE2KSkKPiA+ICAjZGVmaW5lICBHRU4xMV9ERV9UQ19IT1RQTFVHX01BU0sJCShH RU4xMV9UQzRfSE9UUExVCj4gPiBHIHwgXAo+ID4gIAkJCQkJCSBHRU4xMV9UQzNfSE9UUExVRwo+ ID4gfCBcCj4gPiAgCQkJCQkJIEdFTjExX1RDMl9IT1RQTFVHCj4gPiB8IFwKPiA+IEBAIC03MjE4 LDYgKzcyMTksNyBAQCBlbnVtIHsKPiA+ICAjZGVmaW5lICBHRU4xMV9UQlQzX0hPVFBMVUcJCQko MSA8PCAyKQo+ID4gICNkZWZpbmUgIEdFTjExX1RCVDJfSE9UUExVRwkJCSgxIDw8IDEpCj4gPiAg I2RlZmluZSAgR0VOMTFfVEJUMV9IT1RQTFVHCQkJKDEgPDwgMCkKPiA+ICsjZGVmaW5lICBHRU4x MV9UQlRfSE9UUExVRyh0Y19wb3J0KQkJKDEgPDwKPiA+ICh0Y19wb3J0KSkKPiA+ICAjZGVmaW5l ICBHRU4xMV9ERV9UQlRfSE9UUExVR19NQVNLCQkoR0VOMTFfVEJUNF9IT1RQCj4gPiBMVUcgfCBc Cj4gPiAgCQkJCQkJIEdFTjExX1RCVDNfSE9UUExVCj4gPiBHIHwgXAo+ID4gIAkJCQkJCSBHRU4x MV9UQlQyX0hPVFBMVQo+ID4gRyB8IFwKPiA+IEBAIC03NTkwLDYgKzc1OTIsOCBAQCBlbnVtIHsK PiA+ICAjZGVmaW5lIFNERV9HTUJVU19JQ1AJCQkoMSA8PCAyMykKPiA+ICAjZGVmaW5lIFNERV9E RElCX0hPVFBMVUdfSUNQCQkoMSA8PCAxNykKPiA+ICAjZGVmaW5lIFNERV9ERElBX0hPVFBMVUdf SUNQCQkoMSA8PCAxNikKPiA+ICsjZGVmaW5lIFNERV9UQ19IT1RQTFVHX0lDUCh0Y19wb3J0KQko MSA8PCAoKHRjX3BvcnQpICsgMjQpKQo+ID4gKyNkZWZpbmUgU0RFX0RESV9IT1RQTFVHX0lDUChw b3J0KQkoMSA8PCAoKHBvcnQpICsgMTYpKQo+ID4gICNkZWZpbmUgU0RFX0RESV9NQVNLX0lDUAkJ KFNERV9ERElCX0hPVFBMVUdfSUNQIHwJCj4gPiBcCj4gPiAgCQkJCQkgU0RFX0RESUFfSE9UUExV R19JQ1ApCj4gPiAgI2RlZmluZSBTREVfVENfTUFTS19JQ1AJCQkoU0RFX1RDNF9IT1RQTFVHX0lD Cj4gPiBQIHwJXAo+ID4gQEAgLTEwNjU0LDQgKzEwNjU4LDggQEAgZW51bSBza2xfcG93ZXJfZ2F0 ZSB7Cj4gPiAgCQkJCQkJX0lDTF9EU0MxX1JDX0JVRl9UCj4gPiBIUkVTSF8xX1VEV19QQiwgXAo+ ID4gIAkJCQkJCV9JQ0xfRFNDMV9SQ19CVUZfVAo+ID4gSFJFU0hfMV9VRFdfUEMpCj4gPiAgCj4g PiArI2RlZmluZSBQT1JUX1RYX0RGTEVYRFBTUAkJCV9NTUlPKDB4MTYzOEEwKQo+ID4gKyNkZWZp bmUgICBUQ19MSVZFX1NUQVRFX1RCVCh0Y19wb3J0KQkJKDEgPDwKPiA+ICgodGNfcG9ydCkgKiA4 ICsgNikpCj4gPiArI2RlZmluZSAgIFRDX0xJVkVfU1RBVEVfVEModGNfcG9ydCkJCSgxIDw8Cj4g PiAoKHRjX3BvcnQpICogOCArIDUpKQo+ID4gKwo+ID4gICNlbmRpZiAvKiBfSTkxNV9SRUdfSF8g Ki8KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IGluZGV4IGNkMGY2NDliNTdhNS4u OTk4ZDY5ODc4OGY5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHAuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gQEAgLTQ1 ODYsNiArNDU4Niw1NyBAQCBzdGF0aWMgYm9vbAo+ID4gYnh0X2RpZ2l0YWxfcG9ydF9jb25uZWN0 ZWQoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gPiAgCXJldHVybiBJOTE1X1JFQUQo R0VOOF9ERV9QT1JUX0lTUikgJiBiaXQ7Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRpYyBib29sIGlj bF9jb21ib19wb3J0X2Nvbm5lY3RlZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ID4gKmRldl9w cml2LAo+ID4gKwkJCQkgICAgIHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQKPiA+ICppbnRlbF9k aWdfcG9ydCkKPiA+ICt7Cj4gPiArCWVudW0gcG9ydCBwb3J0ID0gaW50ZWxfZGlnX3BvcnQtPmJh c2UucG9ydDsKPiA+ICsKPiA+ICsJcmV0dXJuIEk5MTVfUkVBRChTREVJU1IpICYgU0RFX0RESV9I T1RQTFVHX0lDUChwb3J0KTsKPiA+ICt9Cj4gPiArCj4gPiArc3RhdGljIGJvb2wgaWNsX3RjX3Bv cnRfY29ubmVjdGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlCj4gPiAqZGV2X3ByaXYsCj4gPiAr CQkJCSAgc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydAo+ID4gKmludGVsX2RpZ19wb3J0KQo+ID4g K3sKPiA+ICsJZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kaWdfcG9ydC0+YmFzZS5wb3J0Owo+ID4g KwllbnVtIHRjX3BvcnQgdGNfcG9ydCA9IGludGVsX3BvcnRfdG9fdGMoZGV2X3ByaXYsIHBvcnQp Owo+ID4gKwlib29sIGlzX2xlZ2FjeSwgaXNfdHlwZWMsIGlzX3RidDsKPiA+ICsJdTMyIGRwc3A7 Cj4gPiArCj4gPiArCWlzX2xlZ2FjeSA9IEk5MTVfUkVBRChTREVJU1IpICYKPiA+IFNERV9UQ19I T1RQTFVHX0lDUCh0Y19wb3J0KTsKPiA+ICsKPiA+ICsJLyoKPiA+ICsJICogVGhlIHNwZWMgc2F5 cyB3ZSBzaG91bGRuJ3QgYmUgdXNpbmcgdGhlIElTUiBiaXRzIGZvcgo+ID4gZGV0ZWN0aW5nCj4g PiArCSAqIGJldHdlZW4gVEMgYW5kIFRCVC4gV2Ugc2hvdWxkIHVzZSBERkxFWERQU1AuCj4gPiAr CSAqLwo+ID4gKwlkcHNwID0gSTkxNV9SRUFEKFBPUlRfVFhfREZMRVhEUFNQKTsKPiAKPiBJIG9u bHkgd29uZGVyIGlmIHdlIHNob3VsZCBiZSByZWFkaW5nIHRoZSBOb3J0aCBERSBldmVuIGlmIGlz X2xlZ2FjeQo+IGlzCj4gdHJ1ZSBhYm92ZSByYXRoZXIgdGhhbiB1c2luZyBhbiBlYXJseSByZXR1 cm4uIEFueXdheToKPiAKPiBSZXZpZXdlZC1ieTogTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1h cmNoaUBpbnRlbC5jb20+Cj4gCj4gTHVjYXMgRGUgTWFyY2hpCj4gCj4gPiArCWlzX3R5cGVjID0g ZHBzcCAmIFRDX0xJVkVfU1RBVEVfVEModGNfcG9ydCk7Cj4gPiArCWlzX3RidCA9IGRwc3AgJiBU Q19MSVZFX1NUQVRFX1RCVCh0Y19wb3J0KTsKPiA+ICsKPiA+ICsJV0FSTl9PTihpc19sZWdhY3kg KyBpc190eXBlYyArIGlzX3RidCA+IDEpOwo+ID4gKwo+ID4gKwlyZXR1cm4gaXNfbGVnYWN5IHx8 IGlzX3R5cGVjIHx8IGlzX3RidDsKPiA+ICt9Cj4gPiArCj4gPiArc3RhdGljIGJvb2wgaWNsX2Rp Z2l0YWxfcG9ydF9jb25uZWN0ZWQoc3RydWN0IGludGVsX2VuY29kZXIKPiA+ICplbmNvZGVyKQo+ ID4gK3sKPiA+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShl bmNvZGVyLQo+ID4gPmJhc2UuZGV2KTsKPiA+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAq ZGlnX3BvcnQgPQo+ID4gZW5jX3RvX2RpZ19wb3J0KCZlbmNvZGVyLT5iYXNlKTsKPiA+ICsKPiA+ ICsJc3dpdGNoIChlbmNvZGVyLT5ocGRfcGluKSB7Cj4gPiArCWNhc2UgSFBEX1BPUlRfQToKPiA+ ICsJY2FzZSBIUERfUE9SVF9COgo+ID4gKwkJcmV0dXJuIGljbF9jb21ib19wb3J0X2Nvbm5lY3Rl ZChkZXZfcHJpdiwKPiA+IGRpZ19wb3J0KTsKPiA+ICsJY2FzZSBIUERfUE9SVF9DOgo+ID4gKwlj YXNlIEhQRF9QT1JUX0Q6Cj4gPiArCWNhc2UgSFBEX1BPUlRfRToKPiA+ICsJY2FzZSBIUERfUE9S VF9GOgo+ID4gKwkJcmV0dXJuIGljbF90Y19wb3J0X2Nvbm5lY3RlZChkZXZfcHJpdiwgZGlnX3Bv cnQpOwo+ID4gKwlkZWZhdWx0Ogo+ID4gKwkJTUlTU0lOR19DQVNFKGVuY29kZXItPmhwZF9waW4p Owo+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gKwl9Cj4gPiArfQo+ID4gKwo+ID4gIC8qCj4gPiAg ICogaW50ZWxfZGlnaXRhbF9wb3J0X2Nvbm5lY3RlZCAtIGlzIHRoZSBzcGVjaWZpZWQgcG9ydCBj b25uZWN0ZWQ/Cj4gPiAgICogQGVuY29kZXI6IGludGVsX2VuY29kZXIKPiA+IEBAIC00NjEzLDgg KzQ2NjQsMTAgQEAgYm9vbCBpbnRlbF9kaWdpdGFsX3BvcnRfY29ubmVjdGVkKHN0cnVjdAo+ID4g aW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiA+ICAJCXJldHVybiBiZHdfZGlnaXRhbF9wb3J0X2Nv bm5lY3RlZChlbmNvZGVyKTsKPiA+ICAJZWxzZSBpZiAoSVNfR0VOOV9MUChkZXZfcHJpdikpCj4g PiAgCQlyZXR1cm4gYnh0X2RpZ2l0YWxfcG9ydF9jb25uZWN0ZWQoZW5jb2Rlcik7Cj4gPiAtCWVs c2UKPiA+ICsJZWxzZSBpZiAoSVNfR0VOOV9CQyhkZXZfcHJpdikgfHwgSVNfR0VOMTAoZGV2X3By aXYpKQo+ID4gIAkJcmV0dXJuIHNwdF9kaWdpdGFsX3BvcnRfY29ubmVjdGVkKGVuY29kZXIpOwo+ ID4gKwllbHNlCj4gPiArCQlyZXR1cm4gaWNsX2RpZ2l0YWxfcG9ydF9jb25uZWN0ZWQoZW5jb2Rl cik7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyBzdHJ1Y3QgZWRpZCAqCj4gPiAtLSAKPiA+IDIu MTcuMQo+ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==