intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: vathsala nagaraju <vathsala.nagaraju@intel.com>
To: dhinakaran.pandiyan@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH] drm/i915/psr: Limit psr2 to skl+
Date: Thu, 26 Jul 2018 11:32:37 +0530	[thread overview]
Message-ID: <1532584957-8174-1-git-send-email-vathsala.nagaraju@intel.com> (raw)

From: Vathsala Nagaraju <vathsala.nagaraju@intel.com>

PSR2 is supported from skl+.
So Limiting it to skl+.

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 4bd5768..cbbdfd2 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -387,7 +387,7 @@ static void hsw_activate_psr1(struct intel_dp *intel_dp)
 	I915_WRITE(EDP_PSR_CTL, val);
 }
 
-static void hsw_activate_psr2(struct intel_dp *intel_dp)
+static void skl_activate_psr2(struct intel_dp *intel_dp)
 {
 	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
 	struct drm_device *dev = dig_port->base.base.dev;
@@ -516,7 +516,9 @@ void intel_psr_compute_config(struct intel_dp *intel_dp,
 	}
 
 	crtc_state->has_psr = true;
-	crtc_state->has_psr2 = intel_psr2_config_valid(intel_dp, crtc_state);
+	if (INTEL_GEN(dev_priv) >= 9)
+		crtc_state->has_psr2 = intel_psr2_config_valid(intel_dp,
+							       crtc_state);
 	DRM_DEBUG_KMS("Enabling PSR%s\n", crtc_state->has_psr2 ? "2" : "");
 }
 
@@ -534,7 +536,7 @@ static void intel_psr_activate(struct intel_dp *intel_dp)
 
 	/* psr1 and psr2 are mutually exclusive.*/
 	if (dev_priv->psr.psr2_enabled)
-		hsw_activate_psr2(intel_dp);
+		skl_activate_psr2(intel_dp);
 	else
 		hsw_activate_psr1(intel_dp);
 
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2018-07-26  6:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26  6:02 vathsala nagaraju [this message]
2018-07-26  6:32 ` ✗ Fi.CI.BAT: failure for drm/i915/psr: Limit psr2 to skl+ Patchwork
2018-07-26  6:47 ` [PATCH] " Dhinakaran Pandiyan
2018-07-26 23:56   ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532584957-8174-1-git-send-email-vathsala.nagaraju@intel.com \
    --to=vathsala.nagaraju@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).