From: Paulo Zanoni <paulo.r.zanoni@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: kill intel_display_power_well_is_enabled()
Date: Wed, 08 Aug 2018 15:58:53 -0700 [thread overview]
Message-ID: <1533769133.2740.16.camel@intel.com> (raw)
In-Reply-To: <20180808222253.2288.15323@emeril.freedesktop.org>
Em Qua, 2018-08-08 às 22:22 +0000, Patchwork escreveu:
> == Series Details ==
>
> Series: series starting with [1/4] drm/i915: kill
> intel_display_power_well_is_enabled()
> URL : https://patchwork.freedesktop.org/series/47908/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> 94cddb6f9752 drm/i915: kill intel_display_power_well_is_enabled()
> dfb09a8944b0 drm/i915: BUG() if we can't lookup_power_well()
> -:31: WARNING:AVOID_BUG: Avoid crashing the kernel - try using
> WARN_ON & recovery code rather than BUG() or BUG_ON()
> #31: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:1124:
> + BUG();
See the commit message of patch 2, Mr. Robot. I don't think it's worth
adding checking code in the callers, and replacing the current null
pointer dereference with a BUG() is an improvement IMHO.
If anybody disagrees with this, please say so.
>
> total: 0 errors, 1 warnings, 0 checks, 9 lines checked
> e5298551c379 drm/i915: use for_each_power_well in lookup_power_well()
> 942f90859025 drm/i915: move lookup_power_well() up
> -:40: WARNING:AVOID_BUG: Avoid crashing the kernel - try using
> WARN_ON & recovery code rather than BUG() or BUG_ON()
> #40: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:683:
> + BUG();
>
> total: 0 errors, 1 warnings, 0 checks, 50 lines checked
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-08-08 22:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 22:16 [PATCH 1/4] drm/i915: kill intel_display_power_well_is_enabled() Paulo Zanoni
2018-08-08 22:16 ` [PATCH 2/4] drm/i915: BUG() if we can't lookup_power_well() Paulo Zanoni
2018-08-08 22:16 ` [PATCH 3/4] drm/i915: use for_each_power_well in lookup_power_well() Paulo Zanoni
2018-08-08 22:50 ` Souza, Jose
2018-08-08 22:16 ` [PATCH 4/4] drm/i915: move lookup_power_well() up Paulo Zanoni
2018-08-08 22:22 ` [PATCH 1/4] drm/i915: kill intel_display_power_well_is_enabled() Souza, Jose
2018-08-08 22:55 ` Paulo Zanoni
2018-08-08 22:22 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] " Patchwork
2018-08-08 22:58 ` Paulo Zanoni [this message]
2018-08-09 6:29 ` Michal Wajdeczko
2018-08-09 17:15 ` Paulo Zanoni
2018-08-08 22:38 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-09 1:16 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-15 20:27 ` [PATCH 1/4] " Imre Deak
2018-08-17 23:41 ` Paulo Zanoni
2018-08-20 23:11 ` Paulo Zanoni
2018-08-21 11:12 ` Imre Deak
2018-08-21 19:54 ` Paulo Zanoni
2018-08-22 10:21 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533769133.2740.16.camel@intel.com \
--to=paulo.r.zanoni@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).