intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Uma Shankar <uma.shankar@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: dcastagna@chromium.org, seanpaul@chromium.org,
	ville.syrjala@intel.com, harry.wentland@amd.com,
	maarten.lankhorst@intel.com
Subject: [RFC v4 8/8] drm/i915: Load plane color luts from atomic flip
Date: Fri, 17 Aug 2018 19:48:51 +0530	[thread overview]
Message-ID: <1534515531-20599-9-git-send-email-uma.shankar@intel.com> (raw)
In-Reply-To: <1534515531-20599-1-git-send-email-uma.shankar@intel.com>

Load plane color luts as part of atomic plane updates.
This will be done only if the plane color luts are changed.

v4: Rebase

Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
 drivers/gpu/drm/i915/intel_atomic_plane.c | 4 ++++
 drivers/gpu/drm/i915/intel_color.c        | 8 ++++++++
 drivers/gpu/drm/i915/intel_drv.h          | 1 +
 3 files changed, 13 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c b/drivers/gpu/drm/i915/intel_atomic_plane.c
index dcba645..abc9051 100644
--- a/drivers/gpu/drm/i915/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/intel_atomic_plane.c
@@ -224,6 +224,10 @@ static void intel_plane_atomic_update(struct drm_plane *plane,
 		intel_atomic_get_new_plane_state(state, intel_plane);
 	struct drm_crtc *crtc = new_plane_state->base.crtc ?: old_state->crtc;
 
+	if (new_plane_state->base.color_mgmt_changed) {
+		intel_color_load_plane_luts(&new_plane_state->base);
+	}
+
 	if (new_plane_state->base.visible) {
 		const struct intel_crtc_state *new_crtc_state =
 			intel_atomic_get_new_crtc_state(state, to_intel_crtc(crtc));
diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
index 2b5c0cd..de28d6b 100644
--- a/drivers/gpu/drm/i915/intel_color.c
+++ b/drivers/gpu/drm/i915/intel_color.c
@@ -666,6 +666,14 @@ void intel_color_load_luts(struct drm_crtc_state *crtc_state)
 	dev_priv->display.load_luts(crtc_state);
 }
 
+void intel_color_load_plane_luts(const struct drm_plane_state *plane_state)
+{
+	struct drm_device *dev = plane_state->plane->dev;
+	struct drm_i915_private *dev_priv = to_i915(dev);
+
+	dev_priv->display.load_plane_luts(plane_state);
+}
+
 int intel_color_check(struct drm_crtc *crtc,
 		      struct drm_crtc_state *crtc_state)
 {
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 3850a5b..fea772b 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -2179,6 +2179,7 @@ int intel_plane_atomic_check_with_state(const struct intel_crtc_state *old_crtc_
 void intel_color_set_csc(struct drm_crtc_state *crtc_state);
 void intel_color_load_luts(struct drm_crtc_state *crtc_state);
 void intel_plane_color_init(struct drm_plane *plane);
+void intel_color_load_plane_luts(const struct drm_plane_state *plane_state);
 
 /* intel_lspcon.c */
 bool lspcon_init(struct intel_digital_port *intel_dig_port);
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-08-17 14:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17 14:18 [RFC v4 0/8] Add Plane Color Properties Uma Shankar
2018-08-17 14:12 ` ✗ Fi.CI.CHECKPATCH: warning for Add Plane Color Properties (rev4) Patchwork
2018-08-17 14:18 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-08-17 14:18 ` [RFC v4 1/8] drm: Add Enhanced Gamma LUT precision structure Uma Shankar
2018-08-21  9:30   ` Alexandru-Cosmin Gheorghe
2018-08-23  5:20     ` Shankar, Uma
2018-08-17 14:18 ` [RFC v4 2/8] drm: Add Plane Degamma properties Uma Shankar
2018-08-21  9:38   ` Alexandru-Cosmin Gheorghe
2018-08-17 14:18 ` [RFC v4 3/8] drm: Add Plane CTM property Uma Shankar
2018-08-21  9:40   ` Alexandru-Cosmin Gheorghe
2018-08-22  8:40   ` Lankhorst, Maarten
2018-08-22  9:53     ` [Intel-gfx] " Ville Syrjälä
2018-08-22 11:11       ` Brian Starkey
2018-08-22 12:51         ` [Intel-gfx] " Lankhorst, Maarten
2018-08-22 13:06         ` Ville Syrjälä
2018-08-23  5:18           ` Shankar, Uma
2018-08-17 14:18 ` [RFC v4 4/8] drm: Add Plane Gamma properties Uma Shankar
2018-08-21  9:42   ` Alexandru-Cosmin Gheorghe
2018-08-17 14:18 ` [RFC v4 5/8] drm: Define helper function for plane color enabling Uma Shankar
2018-08-21  9:46   ` Alexandru-Cosmin Gheorghe
2018-08-17 14:18 ` [RFC v4 6/8] drm/i915: Enable plane color features Uma Shankar
2018-08-17 14:18 ` [RFC v4 7/8] drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms Uma Shankar
2018-08-21  9:56   ` Alexandru-Cosmin Gheorghe
2018-08-23  5:22     ` Shankar, Uma
2018-08-17 14:18 ` Uma Shankar [this message]
2018-08-17 14:30 ` ✓ Fi.CI.BAT: success for Add Plane Color Properties (rev4) Patchwork
2018-08-17 16:36 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1534515531-20599-9-git-send-email-uma.shankar@intel.com \
    --to=uma.shankar@intel.com \
    --cc=dcastagna@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@intel.com \
    --cc=seanpaul@chromium.org \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).