* [PATCH v4] drm/i915/psr: Add PSR mode/revision to debugfs
@ 2018-08-22 17:23 Azhar Shaikh
2018-08-22 18:32 ` Dhinakaran Pandiyan
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Azhar Shaikh @ 2018-08-22 17:23 UTC (permalink / raw)
To: intel-gfx; +Cc: dhinakaran.pandiyan
Log the PSR mode/revision (PSR1 or PSR2) in the debugfs file
i915_edp_psr_status.
Suggested-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
---
Changes in v4:
- Fix the rebase error in v3 of adding typecast to bool
- in i915_edp_psr_status(), which is not needed
Changes in v3:
- rebased
Changes in v2:
- Fix checkpatch warning.
- Add Reviewed-by: from v1
drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 26b7e5276b15..544ec5cdfe9f 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2708,6 +2708,8 @@ static int i915_edp_psr_status(struct seq_file *m, void *data)
intel_runtime_pm_get(dev_priv);
mutex_lock(&dev_priv->psr.lock);
+ seq_printf(m, "PSR mode: %s\n",
+ dev_priv->psr.psr2_enabled ? "PSR2" : "PSR1");
seq_printf(m, "Enabled: %s\n", yesno(dev_priv->psr.enabled));
seq_printf(m, "Busy frontbuffer bits: 0x%03x\n",
dev_priv->psr.busy_frontbuffer_bits);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v4] drm/i915/psr: Add PSR mode/revision to debugfs
2018-08-22 17:23 [PATCH v4] drm/i915/psr: Add PSR mode/revision to debugfs Azhar Shaikh
@ 2018-08-22 18:32 ` Dhinakaran Pandiyan
2018-08-22 23:50 ` Dhinakaran Pandiyan
2018-08-22 22:23 ` ✓ Fi.CI.BAT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev4) Patchwork
2018-08-22 23:11 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Dhinakaran Pandiyan @ 2018-08-22 18:32 UTC (permalink / raw)
To: Azhar Shaikh, intel-gfx
On Wed, 2018-08-22 at 10:23 -0700, Azhar Shaikh wrote:
> Log the PSR mode/revision (PSR1 or PSR2) in the debugfs file
> i915_edp_psr_status.
>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Suggested-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
> ---
> Changes in v4:
> - Fix the rebase error in v3 of adding typecast to bool
> - in i915_edp_psr_status(), which is not needed
>
> Changes in v3:
> - rebased
>
> Changes in v2:
> - Fix checkpatch warning.
> - Add Reviewed-by: from v1
>
> drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index 26b7e5276b15..544ec5cdfe9f 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2708,6 +2708,8 @@ static int i915_edp_psr_status(struct seq_file
> *m, void *data)
> intel_runtime_pm_get(dev_priv);
>
> mutex_lock(&dev_priv->psr.lock);
> + seq_printf(m, "PSR mode: %s\n",
> + dev_priv->psr.psr2_enabled ? "PSR2" : "PSR1");
> seq_printf(m, "Enabled: %s\n", yesno(dev_priv-
> >psr.enabled));
> seq_printf(m, "Busy frontbuffer bits: 0x%03x\n",
> dev_priv->psr.busy_frontbuffer_bits);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4] drm/i915/psr: Add PSR mode/revision to debugfs
2018-08-22 18:32 ` Dhinakaran Pandiyan
@ 2018-08-22 23:50 ` Dhinakaran Pandiyan
0 siblings, 0 replies; 5+ messages in thread
From: Dhinakaran Pandiyan @ 2018-08-22 23:50 UTC (permalink / raw)
To: Azhar Shaikh, intel-gfx
On Wed, 2018-08-22 at 11:32 -0700, Dhinakaran Pandiyan wrote:
>
> On Wed, 2018-08-22 at 10:23 -0700, Azhar Shaikh wrote:
> > Log the PSR mode/revision (PSR1 or PSR2) in the debugfs file
> > i915_edp_psr_status.
> >
>
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> > Suggested-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
Thanks for writing this patch, I've pushed it.
-DK
> > ---
> > Changes in v4:
> > - Fix the rebase error in v3 of adding typecast to bool
> > - in i915_edp_psr_status(), which is not needed
> >
> > Changes in v3:
> > - rebased
> >
> > Changes in v2:
> > - Fix checkpatch warning.
> > - Add Reviewed-by: from v1
> >
> > drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> > b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 26b7e5276b15..544ec5cdfe9f 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -2708,6 +2708,8 @@ static int i915_edp_psr_status(struct
> > seq_file
> > *m, void *data)
> > intel_runtime_pm_get(dev_priv);
> >
> > mutex_lock(&dev_priv->psr.lock);
> > + seq_printf(m, "PSR mode: %s\n",
> > + dev_priv->psr.psr2_enabled ? "PSR2" : "PSR1");
> > seq_printf(m, "Enabled: %s\n", yesno(dev_priv-
> > > psr.enabled));
> >
> > seq_printf(m, "Busy frontbuffer bits: 0x%03x\n",
> > dev_priv->psr.busy_frontbuffer_bits);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev4)
2018-08-22 17:23 [PATCH v4] drm/i915/psr: Add PSR mode/revision to debugfs Azhar Shaikh
2018-08-22 18:32 ` Dhinakaran Pandiyan
@ 2018-08-22 22:23 ` Patchwork
2018-08-22 23:11 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-08-22 22:23 UTC (permalink / raw)
To: Azhar Shaikh; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Add PSR mode/revision to debugfs (rev4)
URL : https://patchwork.freedesktop.org/series/47902/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4697 -> Patchwork_9996 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47902/revisions/4/mbox/
== Known issues ==
Here are the changes found in Patchwork_9996 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
{fi-byt-clapper}: PASS -> INCOMPLETE (fdo#102657)
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-FAIL (fdo#102614)
{igt@pm_rpm@module-reload}:
fi-cnl-psr: PASS -> WARN (fdo#107602)
==== Possible fixes ====
igt@debugfs_test@read_all_entries:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
igt@drv_selftest@live_coherency:
fi-gdg-551: DMESG-FAIL (fdo#107164) -> PASS
igt@drv_selftest@live_hangcheck:
fi-bxt-j4205: DMESG-FAIL (fdo#106560) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-skl-guc: FAIL (fdo#103191) -> PASS
fi-bxt-dsi: INCOMPLETE (fdo#103927) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102657 https://bugs.freedesktop.org/show_bug.cgi?id=102657
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
== Participating hosts (54 -> 47) ==
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u
== Build changes ==
* Linux: CI_DRM_4697 -> Patchwork_9996
CI_DRM_4697: b68c36de381756889dffa2c8de3206c8bf9a66d2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4608: 94ebd21177feedf03e8f6dd1e73dca1a6ec7a0ac @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9996: ad40f970820c5021aaf10dab23fd53301a42c49c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ad40f970820c drm/i915/psr: Add PSR mode/revision to debugfs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9996/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev4)
2018-08-22 17:23 [PATCH v4] drm/i915/psr: Add PSR mode/revision to debugfs Azhar Shaikh
2018-08-22 18:32 ` Dhinakaran Pandiyan
2018-08-22 22:23 ` ✓ Fi.CI.BAT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev4) Patchwork
@ 2018-08-22 23:11 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-08-22 23:11 UTC (permalink / raw)
To: Azhar Shaikh; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Add PSR mode/revision to debugfs (rev4)
URL : https://patchwork.freedesktop.org/series/47902/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4697_full -> Patchwork_9996_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_9996_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-glk: PASS -> INCOMPLETE (k.org#198133, fdo#106886, fdo#103359)
igt@gem_ctx_isolation@vcs1-s3:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: INCOMPLETE (fdo#106023, fdo#103665) -> PASS
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4697 -> Patchwork_9996
CI_DRM_4697: b68c36de381756889dffa2c8de3206c8bf9a66d2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4608: 94ebd21177feedf03e8f6dd1e73dca1a6ec7a0ac @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9996: ad40f970820c5021aaf10dab23fd53301a42c49c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9996/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-22 23:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-22 17:23 [PATCH v4] drm/i915/psr: Add PSR mode/revision to debugfs Azhar Shaikh
2018-08-22 18:32 ` Dhinakaran Pandiyan
2018-08-22 23:50 ` Dhinakaran Pandiyan
2018-08-22 22:23 ` ✓ Fi.CI.BAT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev4) Patchwork
2018-08-22 23:11 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).