From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Spotswood Subject: Re: [PATCH 03/21] drm/i915/guc: Simplify preparation of GuC parameter block Date: Thu, 30 Aug 2018 15:58:27 -0700 Message-ID: <1535669907.3405.10.camel@intel.com> References: <20180829191056.63760-1-michal.wajdeczko@intel.com> <20180829191056.63760-4-michal.wajdeczko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1BE0E6E094 for ; Thu, 30 Aug 2018 22:58:28 +0000 (UTC) In-Reply-To: <20180829191056.63760-4-michal.wajdeczko@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Wajdeczko, Michal" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE4LTA4LTI5IGF0IDEyOjEwIC0wNzAwLCBXYWpkZWN6a28sIE1pY2hhbCB3cm90 ZToKPiBEZWZpbml0aW9uIG9mIHRoZSBwYXJhbWV0ZXJzIGJsb2NrIHBhc3NlZCB0byBHdUMgaXMg YWJvdXQgdG8gY2hhbmdlLgo+IFNsaWdodGx5IHJlZmFjdG9yIGNvZGUgbm93IHRvIG1ha2UgdXBj b21pbmcgcGF0Y2ggc21hbGxlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWwgV2FqZGVjemtv IDxtaWNoYWwud2FqZGVjemtvQGludGVsLmNvbT4KPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29u YXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IENjOiBKb2huIFNwb3Rzd29vZCA8am9obi5h LnNwb3Rzd29vZEBpbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogSm9obiBTcG90c3dvb2QgPGpvaG4u YS5zcG90c3dvb2RAaW50ZWwuY29tPgoKPiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2d1Yy5jIHwgMzggKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4gLS0tLS0tLS0K PiDCoDEgZmlsZSBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmMKPiBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5jCj4gaW5kZXggMjMwYWVhNi4uOTgyYmNjOCAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5jCj4gQEAgLTMyMCwxOSArMzIwLDggQEAgc3RhdGlj IHUzMiBndWNfY3RsX2xvZ19wYXJhbXNfZmxhZ3Moc3RydWN0Cj4gaW50ZWxfZ3VjICpndWMpCj4g wqAJcmV0dXJuIGZsYWdzOwo+IMKgfQo+IMKgCj4gLS8qCj4gLSAqIEluaXRpYWxpc2UgdGhlIEd1 QyBwYXJhbWV0ZXIgYmxvY2sgYmVmb3JlIHN0YXJ0aW5nIHRoZSBmaXJtd2FyZQo+IC0gKiB0cmFu c2Zlci4gVGhlc2UgcGFyYW1ldGVycyBhcmUgcmVhZCBieSB0aGUgZmlybXdhcmUgb24gc3RhcnR1 cAo+IC0gKiBhbmQgY2Fubm90IGJlIGNoYW5nZWQgdGhlcmVhZnRlci4KPiAtICovCj4gLXZvaWQg aW50ZWxfZ3VjX2luaXRfcGFyYW1zKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiArc3RhdGljIHZv aWQgZ3VjX3ByZXBhcmVfcGFyYW1zKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgdTMyICpwYXJhbXMp Cj4gwqB7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBndWNfdG9faTkx NShndWMpOwo+IC0JdTMyIHBhcmFtc1tHVUNfQ1RMX01BWF9EV09SRFNdOwo+IC0JaW50IGk7Cj4g LQo+IC0JbWVtc2V0KHBhcmFtcywgMCwgc2l6ZW9mKHBhcmFtcykpOwo+IC0KPiDCoAkvKgo+IMKg CcKgKiBHdUMgQVJBVCBpbmNyZW1lbnQgaXMgMTAgbnMuIEd1QyBkZWZhdWx0IHNjaGVkdWxlcgo+ IHF1YW50dW0gaXMgb25lCj4gwqAJwqAqIHNlY29uZC4gVGhpcyBBUkFSIGlzIGNhbGN1bGF0ZWQg Ynk6Cj4gQEAgLTM0Nyw5ICszMzYsMTIgQEAgdm9pZCBpbnRlbF9ndWNfaW5pdF9wYXJhbXMoc3Ry dWN0IGludGVsX2d1Ywo+ICpndWMpCj4gwqAJcGFyYW1zW0dVQ19DVExfTE9HX1BBUkFNU13CoMKg PSBndWNfY3RsX2xvZ19wYXJhbXNfZmxhZ3MoZ3VjKTsKPiDCoAlwYXJhbXNbR1VDX0NUTF9ERUJV R10gPSBndWNfY3RsX2RlYnVnX2ZsYWdzKGd1Yyk7Cj4gwqAJcGFyYW1zW0dVQ19DVExfQ1RYSU5G T10gPSBndWNfY3RsX2N0eGluZm9fZmxhZ3MoZ3VjKTsKPiArfQo+IMKgCj4gLQlmb3IgKGkgPSAw OyBpIDwgR1VDX0NUTF9NQVhfRFdPUkRTOyBpKyspCj4gLQkJRFJNX0RFQlVHX0RSSVZFUigicGFy YW1bJTJkXSA9ICUjeFxuIiwgaSwKPiBwYXJhbXNbaV0pOwo+ICtzdGF0aWMgdm9pZCBndWNfd3Jp dGVfcGFyYW1zKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgY29uc3QgdTMyCj4gKnBhcmFtcykKPiAr ewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5MTUoZ3Vj KTsKPiArCWludCBpOwo+IMKgCj4gwqAJLyoKPiDCoAnCoCogQWxsIFNPRlRfU0NSQVRDSCByZWdp c3RlcnMgYXJlIGluIEZPUkNFV0FLRV9CTElUVEVSCj4gZG9tYWluIGFuZAo+IEBAIC0zNjAsMTIg KzM1MiwyOCBAQCB2b2lkIGludGVsX2d1Y19pbml0X3BhcmFtcyhzdHJ1Y3QgaW50ZWxfZ3VjCj4g Kmd1YykKPiDCoAo+IMKgCUk5MTVfV1JJVEUoU09GVF9TQ1JBVENIKDApLCAwKTsKPiDCoAo+IC0J Zm9yIChpID0gMDsgaSA8IEdVQ19DVExfTUFYX0RXT1JEUzsgaSsrKQo+ICsJZm9yIChpID0gMDsg aSA8IEdVQ19DVExfTUFYX0RXT1JEUzsgaSsrKSB7Cj4gKwkJRFJNX0RFQlVHX0RSSVZFUigicGFy YW1bJTJkXSA9ICUjeFxuIiwgaSwKPiBwYXJhbXNbaV0pOwo+IMKgCQlJOTE1X1dSSVRFKFNPRlRf U0NSQVRDSCgxICsgaSksIHBhcmFtc1tpXSk7Cj4gKwl9Cj4gwqAKPiDCoAlpbnRlbF91bmNvcmVf Zm9yY2V3YWtlX3B1dChkZXZfcHJpdiwgRk9SQ0VXQUtFX0JMSVRURVIpOwo+IMKgfQo+IMKgCj4g Ky8qCj4gKyAqIEluaXRpYWxpc2UgdGhlIEd1QyBwYXJhbWV0ZXIgYmxvY2sgYmVmb3JlIHN0YXJ0 aW5nIHRoZSBmaXJtd2FyZQo+ICsgKiB0cmFuc2Zlci4gVGhlc2UgcGFyYW1ldGVycyBhcmUgcmVh ZCBieSB0aGUgZmlybXdhcmUgb24gc3RhcnR1cAo+ICsgKiBhbmQgY2Fubm90IGJlIGNoYW5nZWQg dGhlcmVhZnRlci4KPiArICovCj4gK3ZvaWQgaW50ZWxfZ3VjX2luaXRfcGFyYW1zKHN0cnVjdCBp bnRlbF9ndWMgKmd1YykKPiArewo+ICsJdTMyIHBhcmFtc1tHVUNfQ1RMX01BWF9EV09SRFNdOwo+ ICsKPiArCW1lbXNldChwYXJhbXMsIDAsIHNpemVvZihwYXJhbXMpKTsKPiArCWd1Y19wcmVwYXJl X3BhcmFtcyhndWMsIHBhcmFtcyk7Cj4gKwlndWNfd3JpdGVfcGFyYW1zKGd1YywgcGFyYW1zKTsK PiArfQo+ICsKPiDCoGludCBpbnRlbF9ndWNfc2VuZF9ub3Aoc3RydWN0IGludGVsX2d1YyAqZ3Vj LCBjb25zdCB1MzIgKmFjdGlvbiwgdTMyCj4gbGVuLAo+IMKgCQnCoMKgwqDCoMKgwqDCoHUzMiAq cmVzcG9uc2VfYnVmLCB1MzIgcmVzcG9uc2VfYnVmX3NpemUpCj4gwqB7Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=