From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BAFCC6FA8E for ; Fri, 23 Sep 2022 11:01:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EDE610E8A5; Fri, 23 Sep 2022 11:01:21 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8940D10E852; Fri, 23 Sep 2022 11:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663930859; x=1695466859; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Oh/2jbnJUIYU2lX82cH9xbHClZolpriMoBQA7OEFGQo=; b=YrboYZj6fFA9un1KKDzZEJJtlvTA/WlmKXi7d9inX5fdENNmo4q/gF4Y oyv0JphDSf3TyxXdJk4U4RG/KgSF1PlBNOpvFgJL23PenkBDYJB/jMC5R 5b0+cKugdCXJorZ6tYw1dAWU1Aa8mzTqSPzyECqcGjYXlfpZxQ9wvJNdJ Z+TJ+ESDvAuFFq19suEt6o7El9/FZzPESK3cM0NLg9nTFE/LW/YE6Ro+5 5oIqfu6pVEHE7YGrC4WW/gHfUFCMZ+gdPZABEtY+yCnRLdapn8wSCmG6O P5HKp8cuN3RH+YT9cgwPNaydBV38pMRNem5Pzb9wfhkge9ESH93lZEK2t w==; X-IronPort-AV: E=McAfee;i="6500,9779,10478"; a="300552302" X-IronPort-AV: E=Sophos;i="5.93,339,1654585200"; d="scan'208";a="300552302" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 04:00:58 -0700 X-IronPort-AV: E=Sophos;i="5.93,339,1654585200"; d="scan'208";a="620176090" Received: from ccislaru-mobl.ger.corp.intel.com (HELO [10.213.225.140]) ([10.213.225.140]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 04:00:57 -0700 Message-ID: <161f5a01-e6e0-f249-045f-bc2f9c0f2a1d@linux.intel.com> Date: Fri, 23 Sep 2022 12:00:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: "Das, Nirmoy" , Intel-gfx@lists.freedesktop.org References: <20220630125716.50835-1-tvrtko.ursulin@linux.intel.com> <6f789a18-76be-ebc6-a20a-fa63963e9498@linux.intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <6f789a18-76be-ebc6-a20a-fa63963e9498@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Remove flush_scheduled_work() from live_execlists X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tetsuo Handa , dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 23/09/2022 11:32, Das, Nirmoy wrote: > Reviewed-by: Nirmoy Das Thanks! Pushed now. Should land with 6.2. Regards, Tvrtko > On 6/30/2022 2:57 PM, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> There are ongoing efforts to remove usages of flush_scheduled_work() from >> drivers in order to avoid several cases of potentential problems when >> flushing is done from certain contexts. >> >> Remove the call from the live_execlists selftest. Its purpose was to be >> thorough and sync with the execlists capture state handling, but that is >> not strictly required for the test to function and can be removed. >> >> Signed-off-by: Tvrtko Ursulin >> Cc: Tetsuo Handa >> --- >>   drivers/gpu/drm/i915/gt/selftest_execlists.c | 2 -- >>   1 file changed, 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c >> b/drivers/gpu/drm/i915/gt/selftest_execlists.c >> index 09f8cd2d0e2c..e62d089257ae 100644 >> --- a/drivers/gpu/drm/i915/gt/selftest_execlists.c >> +++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c >> @@ -85,8 +85,6 @@ static int wait_for_reset(struct intel_engine_cs >> *engine, >>               break; >>       } while (time_before(jiffies, timeout)); >> -    flush_scheduled_work(); >> - >>       if (rq->fence.error != -EIO) { >>           pr_err("%s: hanging request %llx:%lld not reset\n", >>                  engine->name,