From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhinakaran Pandiyan Subject: Re: [PATCH v3 2/4] drm/i915/psr: Account for sink CRC raciness on some panels Date: Wed, 12 Jul 2017 02:42:42 -0700 Message-ID: <16304046.mh1DBDDojr@dk> References: <1499811596-14634-1-git-send-email-jim.bride@linux.intel.com> <1499811596-14634-3-git-send-email-jim.bride@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id EED426E3CB for ; Wed, 12 Jul 2017 09:42:43 +0000 (UTC) Received: by mail-pf0-x242.google.com with SMTP id z6so2561732pfk.3 for ; Wed, 12 Jul 2017 02:42:43 -0700 (PDT) In-Reply-To: <1499811596-14634-3-git-send-email-jim.bride@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Cc: "Nikula, Jani" , "intel-gfx@lists.freedesktop.org" , "Zanoni, Paulo R" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlc2RheSwgSnVseSAxMSwgMjAxNyAzOjE5OjU0IFBNIFBEVCBKaW0gQnJpZGUgd3JvdGU6 Cj4gQWNjb3JkaW5nIHRvIHRoZSBlRFAgc3BlYywgd2hlbiB0aGUgY291bnQgZmllbGQgaW4gVEVT VF9TSU5LX01JU0MKPiBpbmNyZW1lbnRzIHRoZW4gdGhlIHNpeCBieXRlcyBvZiBzaW5rIENSQyBp bmZvcm1hdGlvbiBpbiB0aGUgRFBDRAo+IHNob3VsZCBiZSB2YWxpZC4gIFVuZm9ydHVuYXRlbHks IHRoaXMgZG9lc24ndCBzZWVtIHRvIGJlIHRoZSBjYXNlCj4gb24gc29tZSBwYW5lbHMsIGFuZCBh cyBhIHJlc3VsdCB3ZSBnZXQgc29tZSBpbmNvcnJlY3QgYW5kIGluY29uc2lzdGVudAo+IHZhbHVl cyBmcm9tIHRoZSBzaW5rIENSQyBEUENEIGxvY2F0aW9ucyBhdCB0aW1lcy4gIFRoaXMgcHJvYmxl bSBleGhpYml0cwo+IGl0c2VsZiBtb3JlIG9uIGZhc3RlciBwcm9jZXNzb3JzIChyZWxhdGl2ZSBm YWlsdXJlIHJhdGVzIEhTVyA8IFNLTCA8IEtCTC4pCj4gSW4gb3JkZXIgdG8gdHJ5IGFuZCBhY2Nv dW50IGZvciB0aGlzLCB3ZSB0cnkgYSBsb3QgaGFyZGVyIHRvIHJlYWQgdGhlIHNpbmsKPiBDUkMg dW50aWwgd2UgZ2V0IGNvbnNpc3RlbnQgdmFsdWVzIHR3aWNlIGluIGEgcm93IGJlZm9yZSByZXR1 cm5pbmcgd2hhdCB3ZQo+IHJlYWQgYW5kIGRlbGF5IGZvciBhIHRpbWUgYmVmb3JlIHRyeWluZyB0 byByZWFkLiAgV2Ugc3RpbGwgc2VlIHNvbWUKPiBvY2Nhc2lvbmFsIGZhaWx1cmVzLCBidXQgcmVh ZGluZyB0aGUgc2luayBDUkMgaXMgbXVjaCBtb3JlIHJlbGlhYmxlLAo+IHBhcnRpY3VsYXJseSBv biBTS0wgYW5kIEtCTCwgd2l0aCB0aGVzZSBjaGFuZ2VzIHRoYW4gd2l0aG91dC4KCldoYXQncyB0 aGUgZ29hbCBoZXJlPyBJcyB0aGlzIHJldHJ5IGxvb3AgYmVpbmcgYWRkZWQgdG8gZGVhbCB3aXRo IGFuIElHVCAKZmFpbHVyZT8gQSBiaXQgb2YgY29udGV4dCBhcyB0byBob3cgdGhpcyBpcyByZWxh dGVkIHRvIFBTUiB3aWxsIGJlIGhlbHBmdWwuCgo+IAo+IHYyOiAqIFJlZHVjZSBudW1iZXIgb2Yg cmV0cmllcyB3aGVuIHJlYWRpbmcgdGhlIHNpbmsgQ1JDIChKYW5pKQo+ICAgICAqIFJlZmFjdG9y IHRvIG1pbmltaXplIGNoYW5nZXMgdG8gdGhlIGNvZGUgKEphbmkpCj4gICAgICogUmViYXNlCj4g Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBDYzogUGF1bG8g WmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5p Lm5pa3VsYUBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52 aXZpQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKaW0gQnJpZGUgPGppbS5icmlkZUBsaW51 eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCA0 MAo+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0gMSBmaWxlIGNoYW5n ZWQsIDM2IGluc2VydGlvbnMoKyksCj4gNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHAuYyBpbmRleCAyZDQyZDA5Li42OWM4MTMwYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHAuYwo+IEBAIC0zOTA2LDYgKzM5MDYsMTQgQEAgaW50IGludGVsX2RwX3NpbmtfY3JjKHN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHU4Cj4gKmNyYykgdTggYnVmOwo+ICAJaW50IGNvdW50 LCByZXQ7Cj4gIAlpbnQgYXR0ZW1wdHMgPSA2Owo+ICsJdTggb2xkX2NyY1s2XTsKPiArCj4gKwlp ZiAoY3JjICE9IE5VTEwpIHsKCldoeSBpcyB0aGlzIG5lZWRlZD8KCj4gKwkJbWVtc2V0KGNyYywg MCwgNik7Cj4gKwkJbWVtc2V0KG9sZF9jcmMsIDB4ZmYsIDYpOwoKSSBkb24ndCBrbm93IG11Y2gg YWJvdXQgY3JjIHZhbHVlcywgaXMgMHhmZiBhIGtub3duIGludmFsaWQgdmFsdWU/Cgo+ICsJfSBl bHNlIHsKPiArCQlyZXR1cm4gLUVOT01FTTsKPiArCX0KPiAKPiAgCXJldCA9IGludGVsX2RwX3Np bmtfY3JjX3N0YXJ0KGludGVsX2RwKTsKPiAgCWlmIChyZXQpCj4gQEAgLTM5MjksMTEgKzM5Mzcs MzUgQEAgaW50IGludGVsX2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHU4 Cj4gKmNyYykgZ290byBzdG9wOwo+ICAJfQo+IAo+IC0JaWYgKGRybV9kcF9kcGNkX3JlYWQoJmlu dGVsX2RwLT5hdXgsIERQX1RFU1RfQ1JDX1JfQ1IsIGNyYywgNikgPCAwKSB7Cj4gLQkJcmV0ID0g LUVJTzsKPiAtCQlnb3RvIHN0b3A7Cj4gLQl9Cj4gKwlhdHRlbXB0cyA9IDY7Cj4gKwo+ICsJLyoK PiArCSAqIFNvbWV0aW1lcyBpdCB0YWtlcyBhIHdoaWxlIGZvciB0aGUgInJlYWwiIENSQyB2YWx1 ZXMgdG8gbGFuZCBpbgo+ICsJICogdGhlIERQQ0QsIHNvIHRyeSBzZXZlcmFsIHRpbWVzIHVudGls IHdlIGdldCB0d28gcmVhZHMgaW4gYSByb3cKPiArCSAqIHRoYXQgYXJlIHRoZSBzYW1lLiAgSWYg d2UncmUgYW4gZURQIHBhbmVsLCBkZWxheSBiZXR3ZWVuIHJlYWRzCj4gKwkgKiBmb3IgYSB3aGls ZSBzaW5jZSB0aGUgdmFsdWVzIHRha2UgYSBiaXQgbG9uZ2VyIHRvIHByb3BhZ2F0ZS4KPiArCSAq Lwo+ICsJZG8gewo+ICsJCWludGVsX3dhaXRfZm9yX3ZibGFuayhkZXZfcHJpdiwgaW50ZWxfY3J0 Yy0+cGlwZSk7CgpXaHkgd2FpdCBmb3IgYSB2YmxhbmsgaWYgdGhlIGlkZWEgaXMgdG8gY2hlY2sg Zm9yIGNvbnNpc3RlbnQgY3JjIHZhbHVlcyBmb3IgCnRoZSBzYW1lIGZyYW1lIChJJ20gYXNzdW1p bmcgdGhhdCBpcyB0aGUgaWRlYSkgPyAKCj4gKwkJaWYgKGlzX2VkcChpbnRlbF9kcCkpCj4gKwkJ CXVzbGVlcF9yYW5nZSgyMDAwMCwgMjUwMDApOwo+ICsKPiArCQlpZiAoZHJtX2RwX2RwY2RfcmVh ZCgmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9DUkNfUl9DUiwKPiArCQkJCSAgICAgY3JjLCA2KSA8 IDApIHsKPiArCQkJcmV0ID0gLUVJTzsKPiArCQkJZ290byBzdG9wOwo+ICsJCX0KPiArCj4gKwkJ aWYgKG1lbWNtcChvbGRfY3JjLCBjcmMsIDYpID09IDApIHsKPiArCQkJcmV0ID0gMDsKPiArCQkJ Z290byBzdG9wOwo+ICsJCX0gZWxzZSB7Cj4gKwkJCW1lbWNweShvbGRfY3JjLCBjcmMsIDYpOwo+ ICsJCX0KPiArCX0gd2hpbGUgKC0tYXR0ZW1wdHMpOwo+IAo+ICsJRFJNX0RFQlVHX0tNUygiRmFp bGVkIHRvIGdldCBDUkMgYWZ0ZXIgNiBhdHRlbXB0cy5cbiIpOwo+ICsJcmV0ID0gLUVUSU1FRE9V VDsKPiAgc3RvcDoKPiAgCWludGVsX2RwX3NpbmtfY3JjX3N0b3AoaW50ZWxfZHApOwo+ICAJcmV0 dXJuIHJldDsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK