From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clint Taylor Subject: Re: [PATCH 2/2] drm/i915/icl: Fix PLL mapping sanitization for DP ports Date: Thu, 8 Nov 2018 16:19:37 -0800 Message-ID: <16347aca-a191-8949-ae65-77eec1144ac5@intel.com> References: <20181107200836.10191-1-imre.deak@intel.com> <20181107200836.10191-2-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 406626E70D for ; Fri, 9 Nov 2018 00:19:04 +0000 (UTC) In-Reply-To: <20181107200836.10191-2-imre.deak@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxMS8wNy8yMDE4IDEyOjA4IFBNLCBJbXJlIERlYWsgd3JvdGU6Cj4gV2Ugc2hvdWxkbid0 IGNvbnNpZGVyIGFuIGVuY29kZXIgaW5hY3RpdmUgaWYgaXQgZG9lc24ndCBoYXZlIGEgQ1JUQwo+ IGxpbmtlZCwgYnV0IGhhcyB2aXJ0dWFsIE1TVCBlbmNvZGVycyB3aXRoIGEgY3J0YyBsaW5rZWQu IEZpeCB0aGlzLgo+Cj4gQWxzbyB3ZSBzaG91bGQgbm90IHNhbml0aXplIHRoZSBtYXBwaW5nIGZv ciBNU1QgZW5jb2RlcnMsIGFzIGl0J3MgYWx3YXlzCj4gdGhlaXIgcHJpbWFyeSBlbmNvZGVyICh3 aGljaCBjb3VsZCBiZSBldmVuIGluIFNTVCBtb2RlKSB3aG9zZSBhY3RpdmUKPiBzdGF0ZSBkZXRl cm1pbmVzIGlmIHdlIG5lZWQgdGhlIGNsb2NrIGJlaW5nIGVuYWJsZWQgZm9yIHRoZQo+IGNvcnJl c3BvbmRpbmcgcGh5c2ljYWwgcG9ydC4gRml4IHRoaXMgdG9vLgo+Cj4gVGhpcyBmaXhlcyBhdCBs ZWFzdCBhbiBleGlzdGluZyBicmVha2FnZSB3aGVyZSB3ZSBpbmNvcnJlY3RseSBkaXNhYmxlZAo+ IHRoZSBjbG9jayBmb3IgYW4gYWN0aXZlIERQIGVuY29kZXIgd2hlbiBzYW5pdGl6aW5nIGl0cyBN U1QgdmlydHVhbAo+IGVuY29kZXJzLiBOb3Qgc3VyZSBpZiB0aGVyZSBhcmUgQklPU2VzIHRoYXQg ZW5hYmxlIGFuIG91dHB1dCBpbiBNU1QKPiBtb2RlLCBidXQgb3VyIEhXIHJlYWRvdXQgaXMgbW9z dGx5IG1pc3NpbmcgZm9yIGl0IGFueXdheSwgc28ganVzdCB3YXJuCj4gZm9yIHRoYXQgY2FzZS4K Pgo+IEZpeGVzOiA3MDMzMmFjNTM5YzUgKCJkcm0vaTkxNS9pY2wrOiBTYW5pdGl6ZSBwb3J0IHRv IFBMTCBtYXBwaW5nIikKPiBDYzogQW50b25pbyBBcmdlbnppYW5vIDxhbnRvbmlvLmFyZ2Vuemlh bm9AaW50ZWwuY29tPgo+IENjOiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNv bT4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K PiBDYzogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gQ2M6 IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBSZXBvcnRlZC1ieTogQW50 b25pbyBBcmdlbnppYW5vIDxhbnRvbmlvLmFyZ2Vuemlhbm9AaW50ZWwuY29tPgo+IFNpZ25lZC1v ZmYtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIHwgMjcgKysrKysrKysrKysrKysrKysrKysrKysrKy0t Cj4gICAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gaW5kZXggYWJjNTE2OTNlZWM5Li40OTEzYmJkYWM4 NDMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IEBAIC0yODUzLDkgKzI4NTMsMzIg QEAgdm9pZCBpY2xfdW5tYXBfcGxsc190b19wb3J0cyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4g ICB2b2lkIGljbF9zYW5pdGl6ZV9lbmNvZGVyX3BsbF9tYXBwaW5nKHN0cnVjdCBpbnRlbF9lbmNv ZGVyICplbmNvZGVyKQo+ICAgewo+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOwo+IC0JdTMyIHZhbCA9IEk5MTVfUkVBRChE UENMS0FfQ0ZHQ1IwX0lDTCk7Cj4gKwl1MzIgdmFsOwo+ICAgCWVudW0gcG9ydCBwb3J0ID0gZW5j b2Rlci0+cG9ydDsKPiAtCWJvb2wgY2xrX2VuYWJsZWQgPSAhKHZhbCAmIGljbF9kcGNsa2FfY2Zn Y3IwX2Nsa19vZmYoZGV2X3ByaXYsIHBvcnQpKTsKPiArCWJvb2wgY2xrX2VuYWJsZWQ7Cj4gKwo+ ICsJLyoKPiArCSAqIEluIGNhc2Ugb2YgRFAgTVNULCB3ZSBzYW5pdGl6ZSB0aGUgcHJpbWFyeSBl bmNvZGVyIG9ubHksIG5vdCB0aGUKPiArCSAqIHZpcnR1YWwgb25lcy4KPiArCSAqLwo+ICsJaWYg KGVuY29kZXItPnR5cGUgPT0gSU5URUxfT1VUUFVUX0RQX01TVCkKPiArCQlyZXR1cm47Cj4gKwo+ ICsJdmFsID0gSTkxNV9SRUFEKERQQ0xLQV9DRkdDUjBfSUNMKTsKPiArCWNsa19lbmFibGVkID0g ISh2YWwgJiBpY2xfZHBjbGthX2NmZ2NyMF9jbGtfb2ZmKGRldl9wcml2LCBwb3J0KSk7Cj4gKwo+ ICsJaWYgKCFlbmNvZGVyLT5iYXNlLmNydGMgJiYgaW50ZWxfZW5jb2Rlcl9pc19kcChlbmNvZGVy KSkgewo+ICsJCXU4IHBpcGVfbWFzazsKPiArCQlib29sIGlzX21zdDsKPiArCj4gKwkJaW50ZWxf ZGRpX2dldF9lbmNvZGVyX3BpcGVzKGVuY29kZXIsICZwaXBlX21hc2ssICZpc19tc3QpOwo+ICsJ CS8qCj4gKwkJICogSW4gdGhlIHVubGlrZWx5IGNhc2UgdGhhdCBCSU9TIGVuYWJsZXMgRFAgaW4g TVNUIG1vZGUsIGp1c3QKPiArCQkgKiB3YXJuIHNpbmNlIG91ciBNU1QgSFcgcmVhZG91dCBpcyBp bmNvbXBsZXRlLgo+ICsJCSAqLwo+ICsJCWlmIChXQVJOX09OKGlzX21zdCkpCj4gKwkJCXJldHVy bjsKPiArCX0KPiAgIAo+ICAgCWlmIChjbGtfZW5hYmxlZCA9PSAhIWVuY29kZXItPmJhc2UuY3J0 YykKPiAgIAkJcmV0dXJuOwpGaXhlcyB0aGUgbURQIGxvY2sgdXAgaXNzdWUuCgpSZXZpZXdlZC1i eTogQ2xpbnQgVGF5bG9yIDxDbGludG9uLkEuVGF5bG9yQGludGVsLmNvbT4KVGVzdGVkLWJ5OiBD bGludCBUYXlsb3IgPENsaW50b24uQS5UYXlsb3JAaW50ZWwuY29tPgoKLUNsaW50CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK