From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Farnsworth Subject: Re: [PATCH igt] intel_infoframes: Add support for decoding HDMI VICs Date: Wed, 14 Aug 2013 10:54:17 +0100 Message-ID: <1671526.IZpRXsBCGM@f17simon> References: <1376435954-15415-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1476023970==" Return-path: Received: from claranet-outbound-smtp01.uk.clara.net (claranet-outbound-smtp01.uk.clara.net [195.8.89.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 91EB1439A9 for ; Wed, 14 Aug 2013 02:54:24 -0700 (PDT) In-Reply-To: <1376435954-15415-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1476023970== Content-Type: multipart/signed; boundary="nextPart6589073.dznUVhF9am"; micalg="pgp-sha1"; protocol="application/pgp-signature" --nextPart6589073.dznUVhF9am Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Reviewed-by: Simon Farnsworth On Wednesday 14 August 2013 00:19:14 Damien Lespiau wrote: > The HDMI vendor infoframe can contain a HDMI VIC (as of HDMI 1.4, only > used for 4k formats). > > Signed-off-by: Damien Lespiau > --- > tools/intel_infoframes.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/tools/intel_infoframes.c b/tools/intel_infoframes.c > index 09fdcb9..b6d289f 100644 > --- a/tools/intel_infoframes.c > +++ b/tools/intel_infoframes.c > @@ -184,8 +184,13 @@ typedef union { > uint8_t Rsvd0 :5; > uint8_t video_format :3; > > - uint8_t Rsvd1 :4; > - uint8_t s3d_structure :4; > + union { > + uint8_t vic; > + struct { > + uint8_t Rsvd1 :4; > + uint8_t s3d_structure :4; > + } s3d; > + } pb5; > > uint8_t Rsvd2 :4; > uint8_t s3d_ext_data :4; > @@ -467,13 +472,26 @@ static const char *s3d_structure_to_string(int format) > > static void dump_vendor_hdmi(DipInfoFrame *frame) > { > + int vic_present = frame->vendor.video_format & 0x1; > int s3d_present = frame->vendor.video_format & 0x2; > > printf("- video format: 0x%03x %s\n", frame->vendor.video_format, > s3d_present ? "(3D)" : ""); > - if (s3d_present) > + > + if (vic_present && s3d_present) { > + printf("Error: HDMI VIC and S3D bits set. Only one of those " > + " at a time is valid\n"); > + return; > + } > + > + if (vic_present) > + printf("- HDMI VIC: %d\n", frame->vendor.pb5.vic); > + else if (s3d_present) { > + int s3d_structure = frame->vendor.pb5.s3d.s3d_structure; > + > printf("- 3D Format: %s\n", > - s3d_structure_to_string(frame->vendor.s3d_structure)); > + s3d_structure_to_string(s3d_structure)); > + } > } > > static void dump_vendor_info(Transcoder transcoder) > -- Simon Farnsworth Software Engineer ONELAN Ltd http://www.onelan.com --nextPart6589073.dznUVhF9am Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQEcBAABAgAGBQJSC1PJAAoJELb1E1yQPsc0COwH/ij3jHXVuh92QlhHkhs1LJoi yqOvUuBPXpIS+aQMJfoXT87x62V1QFe2dHNg5Lq0Wg4J3breDWHdWoo1RsuSVl5h wePfzUDgwqrIQTuV9U8g2qipNwfXFdXCAz2Sqhs4X4+zZBrVHEn6uTN6IFuaCtHz cxrjXSWzs+sOgYEy2FFJWbRuLavCbeq+6a96A3Fr9a76pLZmd7QiOMkczJQJU7oe CfuP+MTCVUUpmxcDfiursabqJKOhiQQjkjKmp0egfgEU10NeCmtUSHJ6WXpQKBfy 5eQk/VKb/BKCun5JqZlj4P1fJslVHdicrcJCylABO+alrsjslWD+fDEhlJf6quM= =akTW -----END PGP SIGNATURE----- --nextPart6589073.dznUVhF9am-- --===============1476023970== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1476023970==--