From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback Date: Tue, 10 Jul 2018 14:22:52 +0300 Message-ID: <16830133.3PzqpUzUj4@avalon> References: <20180702110729.8171-1-mahesh1.kumar@intel.com> <20180702110729.8171-3-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180702110729.8171-3-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Mahesh Kumar List-Id: intel-gfx@lists.freedesktop.org SGkgTWFoZXNoLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBNb25kYXksIDIgSnVseSAy MDE4IDE0OjA3OjIxIEVFU1QgTWFoZXNoIEt1bWFyIHdyb3RlOgo+IFRoaXMgcGF0Y2ggaW50cm9k dWNlIGEgY2FsbGJhY2sgZnVuY3Rpb24gImdldF9jcmNfc291cmNlcyIgd2hpY2gKPiB3aWxsIGJl IGNhbGxlZCBkdXJpbmcgcmVhZCBvZiBjb250cm9sIG5vZGUuIEl0IGlzIGFuIG9wdGlvbmFsCj4g Y2FsbGJhY2sgZnVuY3Rpb24gYW5kIGlmIGRyaXZlciBpbXBsZW1lbnRzIHRoaXMgY2FsbGJhY2ss IGRyaXZlcgo+IHNob3VsZCBwcmludCBsaXN0IG9mIGF2YWlsYWJsZSBDUkMgc291cmNlcyBpbiBz ZXFfZmlsZSBwcml2aWRlZAo+IGFzIGFuIGlucHV0IHRvIHRoZSBjYWxsYmFjay4KClRoZSBjb21t aXQgbWVzc2FnZSBzZWVtcyB0byBiZSBvdXRkYXRlZCwgdGhlIGNhbGxiYWNrIGRvZXNuJ3QgdGFr ZSBhIHNlcV9maWxlIAphbnltb3JlLgoKPiBDaGFuZ2VzIFNpbmNlIFYxOiAoRGFuaWVsKQo+ICAt IHJldHVybiBjb25zdCBwb2ludGVyIHRvIGFuIGFycmF5IG9mIGNyYyBzb3VyY2VzIGxpc3QKPiAg LSBkbyB2YWxpZGF0aW9uIG9mIHNvdXJjZXMgaW4gQ1JDLWNvcmUKPiAKPiBTaWduZWQtb2ZmLWJ5 OiBNYWhlc2ggS3VtYXIgPG1haGVzaDEua3VtYXJAaW50ZWwuY29tPgo+IENjOiBkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gUmV2aWV3ZWQtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxt YWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9kcm1fZGVidWdmc19jcmMuYyB8IDIwICsrKysrKysrKysrKysrKysrKystCj4gIGluY2x1ZGUv ZHJtL2RybV9jcnRjLmggICAgICAgICAgICB8IDE2ICsrKysrKysrKysrKysrKysKPiAgMiBmaWxl cyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGVidWdmc19jcmMuYwo+IGIvZHJpdmVycy9ncHUvZHJt L2RybV9kZWJ1Z2ZzX2NyYy5jIGluZGV4IGM2YTcyNWI3OWFjNi4uZjRkNzY1MjhkMjRjIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGVidWdmc19jcmMuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZGVidWdmc19jcmMuYwo+IEBAIC02Nyw5ICs2NywyNyBAQAo+ICBzdGF0 aWMgaW50IGNyY19jb250cm9sX3Nob3coc3RydWN0IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+ ICB7Cj4gIAlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBtLT5wcml2YXRlOwo+ICsJc2l6ZV90IGNv dW50OwoKQ291bnQgaXQgb25seSB1c2VkIHdpdGhpbiB0aGUgaWYgKCkge30gYmxvY2ssIHlvdSBj YW4gZGVjbGFyZSBpdCB0aGVyZS4KCj4gKwo+ICsJaWYgKGNydGMtPmZ1bmNzLT5nZXRfY3JjX3Nv dXJjZXMpIHsKPiArCQljb25zdCBjaGFyICpjb25zdCAqc291cmNlcyA9IGNydGMtPmZ1bmNzLT5n ZXRfY3JjX3NvdXJjZXMoY3J0YywKPiArCQkJCQkJCQkJJmNvdW50KTsKPiArCQlzaXplX3QgdmFs dWVzX2NudDsKPiArCQlpbnQgaTsKCkkgb25seSB0YWtlcyBwb3NpdGl2ZSB2YWx1ZXMsIGl0IGNh biBiZSBhbiB1bnNpZ25lZCBpbnQuCgo+ICsKPiArCQlpZiAoY291bnQgPD0gMCB8fCAhc291cmNl cykKCmNvdW50IGlzIGEgc2l6ZV90LCBpdCBjYW4ndCBiZSBuZWdhdGl2ZS4KClRoZSAuZ2V0X2Ny Y19zb3VyY2VzKCkgZG9jdW1lbnRhdGlvbiBkb2Vzbid0IGNsZWFybHkgc3BlY2lmeSB3aGV0aGVy IHNvdXJjZXMgCnNob3VsZCBhbHdheXMgYmUgTlVMTCB3aGVuIGNvdW50IGlzIHplcm8uIEkgYWR2 aXNlIHVwZGF0aW5nIHRoZSBkb2N1bWVudGF0aW9uLCAKYW5kIHBvc3NpYmx5IHVwZGF0aW5nIHRo aXMgY2hlY2sgYWNjb3JkaW5nbHkuCgo+ICsJCQlnb3RvIG91dDsKPiArCj4gKwkJc2VxX3B1dHMo bSwgIlsiKTsKPiArCQlmb3IgKGkgPSAwOyBpIDwgY291bnQ7IGkrKykKPiArCQkJaWYgKCFjcnRj LT5mdW5jcy0+dmVyaWZ5X2NyY19zb3VyY2UoY3J0Yywgc291cmNlc1tpXSwKPiArCQkJCQkJCSAg ICAmdmFsdWVzX2NudCkpCgpJIGFzc3VtZSB0aGF0IHlvdSB2ZXJpZnkgc291cmNlcyBvbmUgYnkg b25lIGhlcmUgdG8gYXZvaWQgaGF2aW5nIHRvIGNyZWF0ZSBhIApsaXN0IG9mIHNvdXJjZXMgZHlu YW1pY2FsbHkgaW4gdGhlIC5nZXRfY3JjX3NvdXJjZXMoKSBjYWxsYmFjayA/IElmIHNvLCBJIAp0 aGluayB0aGUgLmdldF9jcmNfc291cmNlcygpIGNhbGxiYWNrIHNob3VsZCBkb2N1bWVudCB0aGF0 LgoKWW91IHNob3VsZCBhbHNvIGRvY3VtZW50IHRoYXQgLnZlcmlmeV9jcmNfc291cmNlKCkgaXMg cmVxdWlyZWQgd2hlbiAKZ2V0X2NyY19zb3VyY2VzKCkgaXMgcHJvdmlkZWQuCgo+ICsJCQkJc2Vx X3ByaW50ZihtLCAiJXMgIiwgc291cmNlc1tpXSk7Cj4gKwkJc2VxX3B1dHMobSwgIl0gIik7CgpU aGlzIGFzc3VtZXMgdGhhdCBzb3VyY2UgbmFtZXMgY2FuJ3QgaW5jbHVkZSBhIHNwYWNlLiBJc24n dCB0aGF0IHRvbyAKcmVzdHJpY3RpdmUgPyBTaG91bGRuJ3QgYSBkaWZmZXJlbnQgc2VwYXJhdG9y IGJlIHVzZWQgPyBIb3cgYWJvdXQgb25lIHNvdXJjZSAKbmFtZSBwZXIgbGluZSA/CgpBZGRpdGlv bmFsbHksIHNob3VsZG4ndCB0aGUgYWN0aXZlIHNvdXJjZSBiZSBtYXJrZWQgPwoKPiArCX0KPiAK PiArb3V0Ogo+ICAJc2VxX3ByaW50ZihtLCAiJXNcbiIsIGNydGMtPmNyYy5zb3VyY2UpOwo+IC0K PiAgCXJldHVybiAwOwo+ICB9Cj4gCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9jcnRj LmggYi9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4gaW5kZXggMWE2ZGNiZjkxNzQ0Li5mZmFlYzEz OGFlZWUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2NydGMuaAo+ICsrKyBiL2luY2x1 ZGUvZHJtL2RybV9jcnRjLmgKPiBAQCAtNjc2LDYgKzY3NiwyMiBAQCBzdHJ1Y3QgZHJtX2NydGNf ZnVuY3Mgewo+ICAJICovCj4gIAlpbnQgKCp2ZXJpZnlfY3JjX3NvdXJjZSkoc3RydWN0IGRybV9j cnRjICpjcnRjLCBjb25zdCBjaGFyICpzb3VyY2UsCj4gIAkJCQkgc2l6ZV90ICp2YWx1ZXNfY250 KTsKPiArCS8qKgo+ICsJICogQGdldF9jcmNfc291cmNlczoKPiArCSAqCj4gKwkgKiBEcml2ZXIg Y2FsbGJhY2sgZm9yIGdldHRpbmcgYSBsaXN0IG9mIGFsbCB0aGUgYXZhaWxhYmxlIHNvdXJjZXMg Zm9yCj4gKwkgKiBDUkMgZ2VuZXJhdGlvbi4KPiArCSAqCj4gKwkgKiBUaGlzIGNhbGxiYWNrIGlz IG9wdGlvbmFsIGlmIHRoZSBkcml2ZXIgZG9lcyBub3Qgc3VwcG9ydCBleHBvcnRpbmcgb2YKPiAr CSAqIHBvc3NpYmxlIENSQyBzb3VyY2VzIGxpc3QuIENSQy1jb3JlIGRvZXMgdGhlIHZlcmlmaWNh dGlvbiBvZiBzb3VyY2VzLgo+ICsJICoKPiArCSAqIFJFVFVSTlM6Cj4gKwkgKgo+ICsJICogYSBj b25zdGFudCBjaGFyYWN0ZXIgcG9pbnRlciB0byB0aGUgbGlzdCBvZiBhbGwgdGhlIGF2YWlsYWJs ZSBDUkMKPiArCSAqIHNvdXJjZXMKPiArCSAqLwo+ICsJY29uc3QgY2hhciAqY29uc3QgKigqZ2V0 X2NyY19zb3VyY2VzKShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gKwkJCQkJICAgICAgc2l6ZV90 ICpjb3VudCk7Cj4gCj4gIAkvKioKPiAgCSAqIEBhdG9taWNfcHJpbnRfc3RhdGU6CgotLSAKUmVn YXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg==