From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77D1CC77B7C for ; Wed, 31 May 2023 08:46:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D24B410E496; Wed, 31 May 2023 08:46:06 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [131.252.210.167]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F19A10E1B8; Wed, 31 May 2023 08:46:05 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id 8B11AA03D2; Wed, 31 May 2023 08:46:05 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Patchwork To: "Thomas Zimmermann" Date: Wed, 31 May 2023 08:46:05 -0000 Message-ID: <168552276556.17618.9723111988225066364@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20230530151228.22979-1-tzimmermann@suse.de> In-Reply-To: <20230530151228.22979-1-tzimmermann@suse.de> Subject: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLkNIRUNLUEFUQ0g6IHdhcm5pbmcg?= =?utf-8?q?for_drm/fbdev=3A_Remove_DRM=27s_helpers_for_fbdev_I/O_=28rev5?= =?utf-8?q?=29?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: intel-gfx@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" == Series Details == Series: drm/fbdev: Remove DRM's helpers for fbdev I/O (rev5) URL : https://patchwork.freedesktop.org/series/117671/ State : warning == Summary == Error: dim checkpatch failed c2b77e5dfd8d fbdev: Add Kconfig options to select different fb_ops helpers ff5e482b5d47 fbdev: Add initializer macros for struct fb_ops -:50: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #50: FILE: include/linux/fb.h:557: +#define FB_DEFAULT_IO_OPS \ + __FB_DEFAULT_IO_OPS_RDWR, \ + __FB_DEFAULT_IO_OPS_DRAW, \ + __FB_DEFAULT_IO_OPS_MMAP -:82: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #82: FILE: include/linux/fb.h:590: +#define FB_DEFAULT_SYS_OPS \ + __FB_DEFAULT_SYS_OPS_RDWR, \ + __FB_DEFAULT_SYS_OPS_DRAW, \ + __FB_DEFAULT_SYS_OPS_MMAP -:114: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__damage_area' - possible side-effects? #114: FILE: include/linux/fb.h:670: +#define __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, __mode) \ + static void __prefix ## _defio_fillrect(struct fb_info *info, \ + const struct fb_fillrect *rect) \ + { \ + __mode ## _fillrect(info, rect); \ + __damage_area(info, rect->dx, rect->dy, rect->width, rect->height); \ + } \ + static void __prefix ## _defio_copyarea(struct fb_info *info, \ + const struct fb_copyarea *area) \ + { \ + __mode ## _copyarea(info, area); \ + __damage_area(info, area->dx, area->dy, area->width, area->height); \ + } \ + static void __prefix ## _defio_imageblit(struct fb_info *info, \ + const struct fb_image *image) \ + { \ + __mode ## _imageblit(info, image); \ + __damage_area(info, image->dx, image->dy, image->width, image->height); \ + } -:134: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #134: FILE: include/linux/fb.h:690: +#define FB_GEN_DEFAULT_DEFERRED_IO_OPS(__prefix, __damage_range, __damage_area) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, io) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, cfb) -:134: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects? #134: FILE: include/linux/fb.h:690: +#define FB_GEN_DEFAULT_DEFERRED_IO_OPS(__prefix, __damage_range, __damage_area) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, io) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, cfb) -:138: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #138: FILE: include/linux/fb.h:694: +#define FB_GEN_DEFAULT_DEFERRED_SYS_OPS(__prefix, __damage_range, __damage_area) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, sys) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, sys) -:138: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects? #138: FILE: include/linux/fb.h:694: +#define FB_GEN_DEFAULT_DEFERRED_SYS_OPS(__prefix, __damage_range, __damage_area) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, sys) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, sys) -:158: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #158: FILE: include/linux/fb.h:714: +#define FB_DEFAULT_DEFERRED_OPS(__prefix) \ + __FB_DEFAULT_DEFERRED_OPS_RDWR(__prefix), \ + __FB_DEFAULT_DEFERRED_OPS_DRAW(__prefix), \ + __FB_DEFAULT_DEFERRED_OPS_MMAP(__prefix) -:158: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects? #158: FILE: include/linux/fb.h:714: +#define FB_DEFAULT_DEFERRED_OPS(__prefix) \ + __FB_DEFAULT_DEFERRED_OPS_RDWR(__prefix), \ + __FB_DEFAULT_DEFERRED_OPS_DRAW(__prefix), \ + __FB_DEFAULT_DEFERRED_OPS_MMAP(__prefix) total: 5 errors, 0 warnings, 4 checks, 133 lines checked e14669fc8202 drm/armada: Use regular fbdev I/O helpers f150181e6d5f drm/exynos: Use regular fbdev I/O helpers 96df051db90b drm/gma500: Use regular fbdev I/O helpers b80040be5a32 drm/radeon: Use regular fbdev I/O helpers 830521199632 drm/fbdev-dma: Use regular fbdev I/O helpers 1a2c3c860665 drm/omapdrm: Use regular fbdev I/O helpers f9bbb729d14a drm/tegra: Use regular fbdev I/O helpers 578b9365edb4 drm/fb-helper: Export helpers for marking damage areas 4ac0e8af7214 drm/msm: Use regular fbdev I/O helpers 8d46b2319aff drm/fbdev-generic: Implement dedicated fbdev I/O helpers 0ed42c8fdeca drm/i915: Implement dedicated fbdev I/O helpers