Re: [PATCH v6 1/1] Documentation: drm: describing drm properties exposed by various drivers

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sagar,

Thank you for the patch.

On Tuesday 11 March 2014 16:07:35 sagar.a.kamble@intel.com wrote:
> From: Sagar Kamble <sagar.a.kamble@intel.com>
> 
> Started documenting drm properties for drm drivers. This patch provides
> information about properties in drm, i915, psb and cdv/gma-500. Information
> about other properties can be added on top of these.
> 
> v2: Added description of drm properties in armada, exynos, i2c/ch7006,
> noveau, omap, qxl, radeon, rcar-du
> 
> v3: Removed "Property Object" column since it is implementation related.
> Property type column refined.[Ville's review comments]
> 
> v4: Removed whitespace warnings and minor nits. [Randy's review comments]
> 
> v5: Restructured output for ENUM properties
> 
> v6: Review comments on formatting the table. [Laurent's review comments]
> 
> Cc: Rob Landley <rob@landley.net>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: David Herrmann <dh.herrmann@gmail.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Cc: Sagar Kamble <sagar.a.kamble@intel.com>
> Cc: "Purushothaman, Vijay A" <vijay.a.purushothaman@intel.com>
> Cc: linux-doc@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> 
> Signed-off-by: Sagar Kamble <sagar.a.kamble@intel.com>
> ---
>  Documentation/DocBook/drm.tmpl | 848 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 848 insertions(+)
> 
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index ed1d6d2..ae5e606 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -2317,6 +2317,854 @@ void intel_crt_init(struct drm_device *dev)
>        pointer to the target object, a pointer to the previously created
> property and an initial instance value.
>      </para>
> +    <sect2>
> +      <para>
> +       The following table gives description of drm properties exposed by
> various
> +       modules/drivers.
> +      </para>
> +    </sect2>

I should have expressed myself a bit more clearly in my previous e-mail. What 
I meant was to include both the paragraph and the table in the sect2. The 
section should also have a title. Something like

<sect2>
  <title>Existing Properties</title>
  <para>
   The following table gives description of drm properties exposed by various
   modules/drivers.
  </para>
  <table>
  ...
  </table>
</sect2>

Feel free to change the title and/or text.

-- 
Regards,

Laurent Pinchart