From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 5/5] drm/atomic-helpers: make mode_set hooks optional Date: Sun, 22 Feb 2015 20:17:04 +0200 Message-ID: <1702272.0DLRK3sWoy@avalon> References: <1424604260-25134-1-git-send-email-daniel.vetter@ffwll.ch> <1424604260-25134-5-git-send-email-daniel.vetter@ffwll.ch> <3330807.tW96iQzFTQ@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <3330807.tW96iQzFTQ@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: dri-devel@lists.freedesktop.org Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org SGkgRGFuaWVsLAoKT24gU3VuZGF5IDIyIEZlYnJ1YXJ5IDIwMTUgMTk6NTM6MjMgTGF1cmVudCBQ aW5jaGFydCB3cm90ZToKPiBPbiBTdW5kYXkgMjIgRmVicnVhcnkgMjAxNSAxMjoyNDoyMCBEYW5p ZWwgVmV0dGVyIHdyb3RlOgo+ID4gV2l0aCBydW50aW1lIFBNIHRoZSBodyBtaWdodCBzdGlsbCBi ZSBvZmYgd2hpbGUgZG9pbmcgdGhlIC0+bW9kZV9zZXQKPiA+IGNhbGxiYWNrcyAtIHJ1bnRpbWUg UE0gZ2V0L3B1dCBzaG91bGQgb25seSBoYXBwZW4gaW4gdGhlCj4gPiBlbmFibGUvZGlzYWJsZSBo b29rcyB0byBwcm9wZXJseSBzdXBwb3J0IERQTVMuIFdoaWNoIGVzc2VudGlhbGx5IG1ha2VzCj4g PiB0aGVzZSBjYWxsYmFja3MgdXNlbGVzcyBmb3IgZHJpdmVycyBzdXBwb3J0IHJ1bnRpbWUgUE0s IHNvIG1ha2UgdGhlbQo+ID4gb3B0aW9uYWwuIEFnYWluIG1vdGl2YXRlZCBieSBkaXNjdXNzaW9u cyB3aXRoIExhdXJlbnQuCj4gPiAKPiA+IENjOiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBp bmNoYXJ0K3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IERhbmll bCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IAo+IEkgdGhpbmsgd2Ugc2hvdWxk IGdvIG9uZSBzdGVwIGZ1cnRoZXIgYW5kIHJlbW92ZSAubW9kZV9zZXQoKSBjb21wbGV0ZWx5IGZv cgo+IGRyaXZlcnMgY29udmVydGVkIHRvIGF0b21pYyB1cGRhdGVzLiBUaGVyZSBhcmUgdHdvIGNh c2VzIHRvIGNvbnNpZGVyOgo+IAo+IC0gRHJpdmVycyB0aGF0IGltcGxlbWVudCBydW50aW1lIFBN IGNhbid0IHVzZSB0aGUgLm1vZGVfc2V0KCkgY2FsbGJhY2sgZm9yCj4gdGhlIHJlYXNvbiBleHBs YWluZWQgYWJvdmUuIFRob3NlIGRyaXZlcnMgd2lsbCB0aHVzIG5vdCBpbXBsZW1lbnQKPiAubW9k ZV9zZXQoKSBhbmQgd2lsbCBwZXJmb3JtIG1vZGUgc2V0dGluZyByZWxhdGVkIGhhcmR3YXJlIGNv bmZpZ3VyYXRpb24gaW4KPiAuZW5hYmxlKCkuCj4gCj4gLSBEcml2ZXJzIHRoYXQgZG9uJ3QgaW1w bGVtZW50IHJ1bnRpbWUgUE0gKHdlIHByb2JhYmx5IHdhbnQgdG8gZGlzY291cmFnZQo+IHRoaXMg Z2xvYmFsbHksIGJ1dCB0aGF0J3MgYSBkaWZmZXJlbnQgdG9waWMpIGNhbiB1c2UgdGhlIC5tb2Rl X3NldCgpCj4gY2FsbGJhY2tzLCBidXQgdGhleSBjb3VsZCBlcXVhbGx5IHdlbGwgcGVyZm9ybSBt b2RlIHNldHRpbmcgaW4gLmVuYWJsZSgpIGFzCj4gdGhlIHJ1bnRpbWUgUE0tIGVuYWJsZWQgZHJp dmVycywgd2l0aG91dCBhbnkgZHJhd2JhY2suCj4gCj4gVG8gaW5jcmVhc2UgY29uc2lzdGVuY3ks IEkgdGh1cyBiZWxpZXZlIHdlIHNob3VsZCBnZXQgcmlkIG9mIC5tb2RlX3NldCgpCj4gY29tcGxl dGVseSBmb3IgZHJpdmVycyBjb252ZXJ0ZWQgdG8gYXRvbWljIHVwZGF0ZXMuCgpPbiBzZWNvbmQg dGhvdWdodCwgSSd2ZSBjb25mdXNlZCAubW9kZV9zZXQoKSBhbmQgLm1vZGVfc2V0X25vZmIoKS4g Lm1vZGVfc2V0KCkgCnN0aWxsIG1ha2VzIHNlbnNlIGZvciBlbmNvZGVycywgYnV0IHRoZSBhYm92 ZSByZWFzb25pbmcgc2hvdWxkIGFwcGx5IGluIG15IApvcGluaW9uIGZvciB0aGUgQ1JUQyAubW9k ZV9zZXRfbm9mYigpLgoKPiBIb3dldmVyLCB0aGlzIHBhdGNoIGlzIGdvb2QgYXMgYSBmaXJzdCBz dGVwLCBzbyBpZiB5b3Ugd2FudCB0byBhcHBseSBpdAo+IGFscmVhZHksCj4gCj4gQWNrZWQtYnk6 IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiAK PiA+IC0tLQo+ID4gCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgfCA1 ICsrKy0tCj4gPiAgaW5jbHVkZS9kcm0vZHJtX2NydGNfaGVscGVyLmggICAgICAgfCAzICsrLQo+ ID4gIDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiA+ IGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgaW5kZXggOWZkMzQ2NmJmMjc3 Li41ZTEwYmNiN2Q5OGQKPiA+IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9h dG9taWNfaGVscGVyLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBl ci5jCj4gPiBAQCAtNzIzLDcgKzcyMyw3IEBAIGNydGNfc2V0X21vZGUoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwgc3RydWN0Cj4gPiBkcm1fYXRvbWljX3N0YXRlICpvbGRfc3RhdGUpCj4gPiAKPiA+ ICAJCWZ1bmNzID0gY3J0Yy0+aGVscGVyX3ByaXZhdGU7Cj4gPiAKPiA+IC0JCWlmIChjcnRjLT5z dGF0ZS0+ZW5hYmxlKSB7Cj4gPiArCQlpZiAoY3J0Yy0+c3RhdGUtPmVuYWJsZSAmJiBmdW5jcy0+ bW9kZV9zZXRfbm9mYikgewo+ID4gCj4gPiAgCQkJRFJNX0RFQlVHX0FUT01JQygibW9kZXNldCBv biBbQ1JUQzolZF1cbiIsCj4gPiAgCQkJCj4gPiAgCQkJCQkgY3J0Yy0+YmFzZS5pZCk7Cj4gPiAK PiA+IEBAIC03NTksNyArNzU5LDggQEAgY3J0Y19zZXRfbW9kZShzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LCBzdHJ1Y3QKPiA+IGRybV9hdG9taWNfc3RhdGUgKm9sZF9zdGF0ZSkgKiBFYWNoIGVuY29k ZXIgaGFzIGF0IG1vc3Qgb25lIGNvbm5lY3Rvcgo+ID4gKHNpbmNlIHdlIGFsd2F5cyBzdGVhbCAq IGl0IGF3YXkpLCBzbyB3ZSB3b24ndCBjYWxsIGNhbGwgbW9kZV9zZXQgaG9va3MKPiA+IHR3aWNl Lgo+ID4gCj4gPiAgCQkgKi8KPiA+IAo+ID4gLQkJZnVuY3MtPm1vZGVfc2V0KGVuY29kZXIsIG1v ZGUsIGFkanVzdGVkX21vZGUpOwo+ID4gKwkJaWYgKGZ1bmNzLT5tb2RlX3NldCkKPiA+ICsJCQlm dW5jcy0+bW9kZV9zZXQoZW5jb2RlciwgbW9kZSwgYWRqdXN0ZWRfbW9kZSk7Cj4gPiAKPiA+ICAJ CWlmIChlbmNvZGVyLT5icmlkZ2UgJiYgZW5jb2Rlci0+YnJpZGdlLT5mdW5jcy0+bW9kZV9zZXQp Cj4gPiAgCQkKPiA+ICAJCQllbmNvZGVyLT5icmlkZ2UtPmZ1bmNzLT5tb2RlX3NldChlbmNvZGVy LT5icmlkZ2UsCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fY3J0Y19oZWxw ZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9jcnRjX2hlbHBlci5oCj4gPiBpbmRleCBjMjUwYTIyYjM5 YWIuLjkyZDUxMzViNTVkMiAxMDA2NDQKPiA+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9jcnRjX2hl bHBlci5oCj4gPiArKysgYi9pbmNsdWRlL2RybS9kcm1fY3J0Y19oZWxwZXIuaAo+ID4gQEAgLTg5 LDYgKzg5LDcgQEAgc3RydWN0IGRybV9jcnRjX2hlbHBlcl9mdW5jcyB7Cj4gPiAKPiA+ICAJaW50 ICgqbW9kZV9zZXQpKHN0cnVjdCBkcm1fY3J0YyAqY3J0Yywgc3RydWN0IGRybV9kaXNwbGF5X21v ZGUgKm1vZGUsCj4gPiAgCQo+ID4gIAkJCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICphZGp1c3Rl ZF9tb2RlLCBpbnQgeCwgaW50IHksCj4gPiAgCQkJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqb2xk X2ZiKTsKPiA+IAo+ID4gKwkvKiBBY3R1YWxseSBzZXQgdGhlIG1vZGUgZm9yIGF0b21pYyBoZWxw ZXJzLCBvcHRpb25hbCAqLwo+ID4gCj4gPiAgCXZvaWQgKCptb2RlX3NldF9ub2ZiKShzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMpOwo+ID4gIAkKPiA+ICAJLyogTW92ZSB0aGUgY3J0YyBvbiB0aGUgY3Vy cmVudCBmYiB0byB0aGUgZ2l2ZW4gcG9zaXRpb24gKm9wdGlvbmFsKiAKKi8KPiA+IAo+ID4gQEAg LTExOSw3ICsxMjAsNyBAQCBzdHJ1Y3QgZHJtX2NydGNfaGVscGVyX2Z1bmNzIHsKPiA+IAo+ID4g ICAqIEBtb2RlX2ZpeHVwOiB0cnkgdG8gZml4dXAgcHJvcG9zZWQgbW9kZSBmb3IgdGhpcyBjb25u ZWN0b3IKPiA+ICAgKiBAcHJlcGFyZTogcGFydCBvZiB0aGUgZGlzYWJsZSBzZXF1ZW5jZSwgY2Fs bGVkIGJlZm9yZSB0aGUgQ1JUQyBtb2Rlc2V0Cj4gPiAgICogQGNvbW1pdDogY2FsbGVkIGFmdGVy IHRoZSBDUlRDIG1vZGVzZXQKPiA+IAo+ID4gLSAqIEBtb2RlX3NldDogc2V0IHRoaXMgbW9kZQo+ ID4gKyAqIEBtb2RlX3NldDogc2V0IHRoaXMgbW9kZSwgb3B0aW9uYWwgZm9yIGF0b21pYyBoZWxw ZXJzCj4gPiAKPiA+ICAgKiBAZ2V0X2NydGM6IHJldHVybiBDUlRDIHRoYXQgdGhlIGVuY29kZXIg aXMgY3VycmVudGx5IGF0dGFjaGVkIHRvCj4gPiAgICogQGRldGVjdDogY29ubmVjdGlvbiBzdGF0 dXMgZGV0ZWN0aW9uCj4gPiAgICogQGRpc2FibGU6IGRpc2FibGUgZW5jb2RlciB3aGVuIG5vdCBp biB1c2UgKG92ZXJyaWRlcyBEUE1TIG9mZikKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFy dAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK