[PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance control capability

[PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance control capability

[Aaron Ma]

The VESA AUX backlight failed to be enabled becaused luminance_set is
false always.
Fix it by using luminance support control capabitliy.

Fixes: e13af5166a359 ("drm/i915/backlight: Use drm helper to initialize edp backlight")
Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 41228478b21c7..0a3a3f6a5f9d8 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -546,7 +546,7 @@ static int intel_dp_aux_vesa_setup_backlight(struct intel_connector *connector,
 				     luminance_range->max_luminance,
 				     panel->vbt.backlight.pwm_freq_hz,
 				     intel_dp->edp_dpcd, &current_level, &current_mode,
-				     false);
+				     panel->backlight.edp.vesa.luminance_control_support);
 	if (ret < 0)
 		return ret;
 
-- 
2.43.0

RE: [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance control capability

[Kandpal, Suraj]

> Subject: [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance
> control capability
> 
> The VESA AUX backlight failed to be enabled becaused luminance_set is false
> always.
> Fix it by using luminance support control capabitliy.
> 
> Fixes: e13af5166a359 ("drm/i915/backlight: Use drm helper to initialize edp
> backlight")
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>

LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 41228478b21c7..0a3a3f6a5f9d8 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -546,7 +546,7 @@ static int intel_dp_aux_vesa_setup_backlight(struct
> intel_connector *connector,
>  				     luminance_range->max_luminance,
>  				     panel->vbt.backlight.pwm_freq_hz,
>  				     intel_dp->edp_dpcd, &current_level,
> &current_mode,
> -				     false);
> +				     panel-
> >backlight.edp.vesa.luminance_control_support);
>  	if (ret < 0)
>  		return ret;
> 
> --
> 2.43.0

✓ i915.CI.BAT: success for drm/i915/backlight: Honor VESA eDP backlight luminance control capability

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5253 bytes --]

== Series Details ==

Series: drm/i915/backlight: Honor VESA eDP backlight luminance control capability
URL   : https://patchwork.freedesktop.org/series/153394/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_17056 -> Patchwork_153394v1
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/index.html

Participating hosts (44 -> 43)
------------------------------

  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in Patchwork_153394v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live:
    - bat-jsl-1:          [PASS][1] -> [DMESG-FAIL][2] ([i915#13774]) +1 other test dmesg-fail
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17056/bat-jsl-1/igt@i915_selftest@live.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/bat-jsl-1/igt@i915_selftest@live.html
    - bat-dg2-11:         [PASS][3] -> [ABORT][4] ([i915#12061])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17056/bat-dg2-11/igt@i915_selftest@live.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/bat-dg2-11/igt@i915_selftest@live.html

  * igt@i915_selftest@live@guc_multi_lrc:
    - bat-dg2-11:         [PASS][5] -> [ABORT][6] ([i915#14201])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17056/bat-dg2-11/igt@i915_selftest@live@guc_multi_lrc.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/bat-dg2-11/igt@i915_selftest@live@guc_multi_lrc.html

  * igt@i915_selftest@live@workarounds:
    - bat-arls-5:         [PASS][7] -> [DMESG-FAIL][8] ([i915#12061]) +1 other test dmesg-fail
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17056/bat-arls-5/igt@i915_selftest@live@workarounds.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/bat-arls-5/igt@i915_selftest@live@workarounds.html
    - bat-dg2-9:          [PASS][9] -> [DMESG-FAIL][10] ([i915#12061]) +1 other test dmesg-fail
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17056/bat-dg2-9/igt@i915_selftest@live@workarounds.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/bat-dg2-9/igt@i915_selftest@live@workarounds.html
    - bat-dg2-11:         [PASS][11] -> [DMESG-FAIL][12] ([i915#12061])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17056/bat-dg2-11/igt@i915_selftest@live@workarounds.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/bat-dg2-11/igt@i915_selftest@live@workarounds.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@workarounds:
    - bat-arlh-3:         [DMESG-FAIL][13] ([i915#12061]) -> [PASS][14] +1 other test pass
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17056/bat-arlh-3/igt@i915_selftest@live@workarounds.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/bat-arlh-3/igt@i915_selftest@live@workarounds.html
    - bat-dg2-14:         [DMESG-FAIL][15] ([i915#12061]) -> [PASS][16] +1 other test pass
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17056/bat-dg2-14/igt@i915_selftest@live@workarounds.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/bat-dg2-14/igt@i915_selftest@live@workarounds.html
    - bat-arls-6:         [DMESG-FAIL][17] ([i915#12061]) -> [PASS][18] +1 other test pass
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17056/bat-arls-6/igt@i915_selftest@live@workarounds.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/bat-arls-6/igt@i915_selftest@live@workarounds.html

  
#### Warnings ####

  * igt@i915_selftest@live:
    - bat-atsm-1:         [DMESG-FAIL][19] ([i915#12061] / [i915#13929]) -> [DMESG-FAIL][20] ([i915#12061] / [i915#14204])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17056/bat-atsm-1/igt@i915_selftest@live.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/bat-atsm-1/igt@i915_selftest@live.html

  * igt@i915_selftest@live@mman:
    - bat-atsm-1:         [DMESG-FAIL][21] ([i915#13929]) -> [DMESG-FAIL][22] ([i915#14204])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17056/bat-atsm-1/igt@i915_selftest@live@mman.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/bat-atsm-1/igt@i915_selftest@live@mman.html

  
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#13774]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13774
  [i915#13929]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13929
  [i915#14201]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14201
  [i915#14204]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14204


Build changes
-------------

  * Linux: CI_DRM_17056 -> Patchwork_153394v1

  CI-20190529: 20190529
  CI_DRM_17056: 2bb5a1149bde0ca35d4b411de142ba6d136c6f9d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8504: 8504
  Patchwork_153394v1: 2bb5a1149bde0ca35d4b411de142ba6d136c6f9d @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153394v1/index.html

[-- Attachment #2: Type: text/html, Size: 6748 bytes --]

RE: [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance control capability

[Kandpal, Suraj]

> Subject: RE: [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance
> control capability
> 
> > Subject: [PATCH] drm/i915/backlight: Honor VESA eDP backlight
> > luminance control capability
> >
> > The VESA AUX backlight failed to be enabled becaused luminance_set is
> > false always.

Fix the typo on 'because' here. Also fix the grammar before merging this
to something like "AUX backlight fails to enable because ..." 

On an unrelated note @Nikula, Jani the commits that this patch sits on exists in
Drm-misc-next but not drm-intel-next. These said commits were merged I think a month or two back.
Now do we proceed merging these in drm-misc-next or get a pull of them in drm-intel-next

Regards,
Suraj Kandpal

> > Fix it by using luminance support control capabitliy.
> >
> > Fixes: e13af5166a359 ("drm/i915/backlight: Use drm helper to
> > initialize edp
> > backlight")
> > Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> 
> LGTM,
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
> 
> > ---
> >  drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > index 41228478b21c7..0a3a3f6a5f9d8 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > @@ -546,7 +546,7 @@ static int
> > intel_dp_aux_vesa_setup_backlight(struct
> > intel_connector *connector,
> >  				     luminance_range->max_luminance,
> >  				     panel->vbt.backlight.pwm_freq_hz,
> >  				     intel_dp->edp_dpcd, &current_level,
> &current_mode,
> > -				     false);
> > +				     panel-
> > >backlight.edp.vesa.luminance_control_support);
> >  	if (ret < 0)
> >  		return ret;
> >
> > --
> > 2.43.0