Re: [RFC 16/28] drm/i915: Compartmentalize i915_ggtt_probe_hw

Chris Wilson
2019-06-14T10:24:08Z

Quoting Tvrtko Ursulin (2019-06-14 10:35:57)
>
> On 13/06/2019 15:03, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2019-06-13 14:35:27)
> >> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>
> >> Having made start to better code compartmentalization by introducing
> >> struct intel_gt, continue the theme elsewhere in code by making functions
> >> take parameters take what logically makes most sense for them instead of
> >> the global struct drm_i915_private.
> >
> > Is that a can of worms I see? :)
> >
> > While you are here, care to pull in the gmch probe so we can drop the
> > frankenstein approach.
>
> What exactly do you mean? Pull in what from where to where?

intel_gtt.ko is the other half of i915_gem_gtt.c
-Chris