From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v1 5/6] drm/i915: Do not do fb src adjustments for NV12 Date: Thu, 12 Apr 2018 13:10:55 +0200 Message-ID: <186dbdbd-60c8-c866-e975-f4c63706502d@linux.intel.com> References: <1523437770-14596-1-git-send-email-vidya.srinivas@intel.com> <1523437770-14596-6-git-send-email-vidya.srinivas@intel.com> <0cf05da7-27a1-4a01-c3ef-7ba8c18bf84b@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 619486E145 for ; Thu, 12 Apr 2018 11:10:58 +0000 (UTC) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Srinivas, Vidya" , Intel Graphics Development , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= List-Id: intel-gfx@lists.freedesktop.org T3AgMTItMDQtMTggb20gMTI6MDcgc2NocmVlZiBTcmluaXZhcywgVmlkeWE6Cj4KPj4gLS0tLS1P cmlnaW5hbCBNZXNzYWdlLS0tLS0KPj4gRnJvbTogTWFhcnRlbiBMYW5raG9yc3QgW21haWx0bzpt YWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb21dCj4+IFNlbnQ6IFdlZG5lc2RheSwgQXBy aWwgMTEsIDIwMTggNDowOCBQTQo+PiBUbzogU3Jpbml2YXMsIFZpZHlhIDx2aWR5YS5zcmluaXZh c0BpbnRlbC5jb20+OyBpbnRlbC1nZngtCj4+IHRyeWJvdEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK Pj4gQ2M6IEthbWF0aCwgU3VuaWwgPHN1bmlsLmthbWF0aEBpbnRlbC5jb20+OyBTYWFyaW5lbiwg SmFuaQo+PiA8amFuaS5zYWFyaW5lbkBpbnRlbC5jb20+Cj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0gg djEgNS82XSBkcm0vaTkxNTogRG8gbm90IGRvIGZiIHNyYyBhZGp1c3RtZW50cyBmb3IKPj4gTlYx Mgo+Pgo+PiBPcCAxMS0wNC0xOCBvbSAxMTowOSBzY2hyZWVmIFZpZHlhIFNyaW5pdmFzOgo+Pj4g V2Ugc2tpcCBzcmMgdHJ1bmN0aW9uL2FkanVzdG1lbnRzIGZvcgo+Pj4gTlYxMiBjYXNlIGFuZCBo YW5kbGUgdGhlIHNpemVzIGRpcmVjdGx5Lgo+Pj4gV2l0aG91dCB0aGlzLCBwaXBlIGZpZm8gdW5k ZXJydW5zIGFyZSBzZWVuIG9uIEFQTC9LQkwuCj4+Pgo+Pj4gQ3JlZGl0cy10bzogTWFhcnRlbiBM YW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4+IFNpZ25lZC1v ZmYtYnk6IFZpZHlhIFNyaW5pdmFzIDx2aWR5YS5zcmluaXZhc0BpbnRlbC5jb20+Cj4+PiAtLS0K Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA4OAo+Pj4gKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfc3ByaXRlLmMgIHwgMTAgKysrLQo+Pj4gIDIgZmlsZXMgY2hhbmdlZCwgOTIgaW5zZXJ0 aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+Pj4gaW5kZXggZWJiM2Y4ZS4uZTRjZjdhNiAxMDA2NDQKPj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+PiBAQCAtMTI5NTEsNiArMTI5NTEsODYgQEAgc2ts X21heF9zY2FsZShzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YywKPj4+IH0KPj4+Cj4+PiAg c3RhdGljIGludAo+Pj4gK2ludGVsX3ByaW1hcnlfcGxhbmVfc3RhdGUoc3RydWN0IGRybV9wbGFu ZV9zdGF0ZSAqcGxhbmVfc3RhdGUsCj4+PiArCQkJICBjb25zdCBzdHJ1Y3QgZHJtX2NydGNfc3Rh dGUgKmNydGNfc3RhdGUsCj4+PiArCQkJICBpbnQgbWluX3NjYWxlLCBpbnQgbWF4X3NjYWxlLAo+ Pj4gKwkJCSAgYm9vbCBjYW5fcG9zaXRpb24sIGJvb2wgY2FuX3VwZGF0ZV9kaXNhYmxlZCkgewo+ Pj4gKwlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lX3N0YXRlLT5mYjsKPj4+ICsJ c3RydWN0IGRybV9yZWN0ICpzcmMgPSAmcGxhbmVfc3RhdGUtPnNyYzsKPj4+ICsJc3RydWN0IGRy bV9yZWN0ICpkc3QgPSAmcGxhbmVfc3RhdGUtPmRzdDsKPj4+ICsJdW5zaWduZWQgaW50IHJvdGF0 aW9uID0gcGxhbmVfc3RhdGUtPnJvdGF0aW9uOwo+Pj4gKwlzdHJ1Y3QgZHJtX3JlY3QgY2xpcCA9 IHt9Owo+Pj4gKwlpbnQgaHNjYWxlLCB2c2NhbGU7Cj4+PiArCj4+PiArCVdBUk5fT04ocGxhbmVf c3RhdGUtPmNydGMgJiYgcGxhbmVfc3RhdGUtPmNydGMgIT0gY3J0Y19zdGF0ZS0KPj4+IGNydGMp Owo+Pj4gKwo+Pj4gKwkqc3JjID0gZHJtX3BsYW5lX3N0YXRlX3NyYyhwbGFuZV9zdGF0ZSk7Cj4+ PiArCSpkc3QgPSBkcm1fcGxhbmVfc3RhdGVfZGVzdChwbGFuZV9zdGF0ZSk7Cj4+PiArCj4+PiAr CWlmICghZmIpIHsKPj4+ICsJCXBsYW5lX3N0YXRlLT52aXNpYmxlID0gZmFsc2U7Cj4+PiArCQly ZXR1cm4gMDsKPj4+ICsJfQo+Pj4gKwo+Pj4gKwkvKiBjcnRjIHNob3VsZCBvbmx5IGJlIE5VTEwg d2hlbiBkaXNhYmxpbmcgKGkuZS4sICFmYikgKi8KPj4+ICsJaWYgKFdBUk5fT04oIXBsYW5lX3N0 YXRlLT5jcnRjKSkgewo+Pj4gKwkJcGxhbmVfc3RhdGUtPnZpc2libGUgPSBmYWxzZTsKPj4+ICsJ CXJldHVybiAwOwo+Pj4gKwl9Cj4+PiArCj4+PiArCWlmICghY3J0Y19zdGF0ZS0+ZW5hYmxlICYm ICFjYW5fdXBkYXRlX2Rpc2FibGVkKSB7Cj4+PiArCQlEUk1fREVCVUdfS01TKCJDYW5ub3QgdXBk YXRlIHBsYW5lIG9mIGEgZGlzYWJsZWQKPj4gQ1JUQy5cbiIpOwo+Pj4gKwkJcmV0dXJuIC1FSU5W QUw7Cj4+PiArCX0KPj4+ICsKPj4+ICsJZHJtX3JlY3Rfcm90YXRlKHNyYywgZmItPndpZHRoIDw8 IDE2LCBmYi0+aGVpZ2h0IDw8IDE2LCByb3RhdGlvbik7Cj4+PiArCj4+PiArCS8qIENoZWNrIHNj YWxpbmcgKi8KPj4+ICsJaHNjYWxlID0gZHJtX3JlY3RfY2FsY19oc2NhbGUoc3JjLCBkc3QsIG1p bl9zY2FsZSwgbWF4X3NjYWxlKTsKPj4+ICsJdnNjYWxlID0gZHJtX3JlY3RfY2FsY192c2NhbGUo c3JjLCBkc3QsIG1pbl9zY2FsZSwgbWF4X3NjYWxlKTsKPj4+ICsJaWYgKGhzY2FsZSA8IDAgfHwg dnNjYWxlIDwgMCkgewo+Pj4gKwkJRFJNX0RFQlVHX0tNUygiSW52YWxpZCBzY2FsaW5nIG9mIHBs YW5lXG4iKTsKPj4+ICsJCWRybV9yZWN0X2RlYnVnX3ByaW50KCJzcmM6ICIsICZwbGFuZV9zdGF0 ZS0+c3JjLCB0cnVlKTsKPj4+ICsJCWRybV9yZWN0X2RlYnVnX3ByaW50KCJkc3Q6ICIsICZwbGFu ZV9zdGF0ZS0+ZHN0LCBmYWxzZSk7Cj4+PiArCQlyZXR1cm4gLUVSQU5HRTsKPj4+ICsJfQo+Pj4g Kwo+Pj4gKwlpZiAoY3J0Y19zdGF0ZS0+ZW5hYmxlKQo+Pj4gKwkJZHJtX21vZGVfZ2V0X2h2X3Rp bWluZygmY3J0Y19zdGF0ZS0+bW9kZSwgJmNsaXAueDIsCj4+ICZjbGlwLnkyKTsKPj4+ICsKPj4+ ICsJaWYgKGZiLT5mb3JtYXQtPmZvcm1hdCA9PSBEUk1fRk9STUFUX05WMTIpIHsKPj4+ICsJCXBs YW5lX3N0YXRlLT52aXNpYmxlID0gdHJ1ZTsKPj4+ICsJCWdvdG8gc2tpcF9jbGlwOwo+Pj4gKwl9 Cj4+PiArCj4+PiArCXBsYW5lX3N0YXRlLT52aXNpYmxlID0KPj4+ICsJCWRybV9yZWN0X2NsaXBf c2NhbGVkKHNyYywgZHN0LCAmY2xpcCwgaHNjYWxlLCB2c2NhbGUpOwo+PiBUaGUgcmVhbCBwcm9i bGVtIGlzIHRoYXQgaXQgbmVlZHMgdG8gYmUgYSBtdWx0aXBsZSBvZiA0LiBJIHRoaW5rIHRoZSBj bGlwcGluZwo+PiBoZXJlIGlzIGhhcm1sZXNzLCB3ZSBzaG91bGQganVzdCBhZGp1c3QgaW50ZWxf Y2hlY2tfc3ByaXRlX3BsYW5lIGZvciA+PSBTS0wuCj4+IFRoaXMgd2lsbCBtYWtlIGl0IHNvIHdl IGRvbid0IGhhdmUgdG8gZHVwbGljYXRlIGl0cyBjaGVja3MuCj4+Cj4+IEZvciBOVjEyIHdlIHN0 aWxsIHdhbnQgdG8gY2FsbCBjbGlwX3JlY3Rfc2NhbGVkLCBidXQgdGhlbiBhZGp1c3QgYWxsCj4+ IGNvb3JkaW5hdGVzIGJ5IGRpdmlkaW5nIGJ5IDQgb24gYmVmb3JlIHRoZSBjaGVjaywgYW5kIG11 bHRpcGx5aW5nIHdpdGggNAo+PiBhZnRlcj8KPj4KPiBUaGFuayB5b3UuIEhhdmUgbWFkZSB0aGUg Y2hhbmdlcyBpbiBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvMjE2Njgy Lwo+IFdpdGggdGhpcywgSSBkaWQgbm90IHNlZSBhbnkgdW5kZXJydW5zLiBGb3Igbm93LCBoYXZl IGEgV0Egb25seSB3aGVuIHdlIHBhc3MgMTZ4MTYKPiBCZWNhdXNlLCB3aXRoIHRoYXQgaXQgZnVy dGhlciBjbGlwcyBkb3duIGFuZCBnZXRzIHJlamVjdGVkIGluIHNrbF91cGRhdGVfc2NhbGVyIGFz IGl0IGlzCj4gTGVzcyB0aGFuIDE2LiBJZiB3ZSBpbmNyZWFzZSBvdXIgYnVmZmVyIGluIGlndCwg dGhlbiB0aGlzIGlzc3VlIHdvbnQgYmUgdGhlcmUuCj4gUGxlYXNlIGhhdmUgYSBjaGVjay4gSW5p dGlhbGx5LCBJIHRyaWVkIHRoZSAvNCBiZWZvcmUgdGhlIGFkanVzdG1lbnRzIGFuZCAqNCBsYXRl ciwgdGhhdCB3b3VsZG7igJl0IHdvcmsKPiBXZSBuZWVkIHRvIGhhdmUgdGhlIDE2LjE2IHZhbHVl cyBtdWx0aXBsaWVyIG9mIDQuIFNvLCBqdXN0IHB1dCBpdCB0b3dhcmRzIHRoZSBlbmQgb2YgYm90 aCBwbGFuZSBjaGVja3MuCQpXZWxsLCB0aGlzIGlzIGFubm95aW5nLgoKSXQgc2VlbXMgd2UgbmV2 ZXIgcmVqZWN0ZWQgc3VicGl4ZWwgcHJlY2lzaW9uIGJlZm9yZSwgYW5kIHJlc29ydGVkIHRvIGNs aXBwaW5nIGluc3RlYWQgb2YgcmVqZWN0aW5nLgpDb3VsZCB3ZSBiZSBtb3JlIHN0cmljdCBhYm91 dCB0aGlzIHdpdGhvdXQgYnJlYWtpbmcgZXhpc3RpbmcgdXNlcnNwYWNlPwoKfk1hYXJ0ZW4KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==