From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH] drm/i915: Make sample_c messages go faster on Haswell. Date: Mon, 05 Jan 2015 23:03:31 -0800 Message-ID: <1877286.PUpbg76clx@vakarian> References: <1420071780-1075-1-git-send-email-kenneth@whitecape.org> <3671367.kHmeu4clag@vakarian> <1420526376.2355.77.camel@xhh-u64> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1129371816==" Return-path: In-Reply-To: <1420526376.2355.77.camel@xhh-u64> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Xiang, Haihao" Cc: intel-gfx@lists.freedesktop.org, "libva@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org --===============1129371816== Content-Type: multipart/signed; boundary="nextPart2333321.A9RdKh6Dkn"; micalg="pgp-sha256"; protocol="application/pgp-signature" --nextPart2333321.A9RdKh6Dkn Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" On Tuesday, January 06, 2015 02:39:36 PM Xiang, Haihao wrote: > On Mon, 2015-01-05 at 21:54 -0800, Kenneth Graunke wrote: > > On Tuesday, January 06, 2015 01:11:53 PM Xiang, Haihao wrote: > > >=20 > > > Hi Kenneth, > > >=20 > > > How did you test OSD ? I can't reproduce the issue you mentioned,= OSD > > > works well for me when using mplayer-vaapi with the latest > > > libva/libva-intel-driver master branch. > > >=20 > > > I tried your patch, what surprised me is OSD still works well aft= er > > > applying your patch. It seems your patch didn't disable the palet= te. > > >=20 > > > Thanks > > > Haihao > >=20 > > I ran: > >=20 > > mplayer -osdlevel 3 -vo vaapi big_buck_bunny_720p_stereo.ogg > >=20 > > For me, the OSD text is solid green, with hard edges. >=20 > The OSD text is white for me when using mplayer -osdlevel 3 -vo vaapi= > xxx. If possible, could you update your mplayer ? Huh. I'm using the Arch Linux package of mplayer-vaapi 36265-13, which seems to be the most recent subversion commit ID. I've never see= n white text on my Haswell system - it seems to be consistently dark gree= n. > > If you use "-vo gl" or "-vo xv", the OSD is solid white text with a= black > > border around it. I presume that it's supposed to be white with va= api as > > well, but I guess I'm not entirely sure. > >=20 > > It's possible that the optimization doesn't affect the palette as l= ong as > > you never use sample_c with the paletted textures. >=20 > I verified the palette takes effect in the following way: >=20 > 1. Only support P8A8 format in the driver >=20 > 2. ran the above command and I saw white OSD text >=20 > 3. Only support P4A4 format in the driver and don't use > 3DSTATE_SAMPLER_PALETTE_LOAD0 to load the value to the texture palett= e, > so the palette keeps unchanged.=20 >=20 > 4. ran the above command and I saw black OSD text. >=20 > 5. Load the right value to the texture palette and ran the above comm= and > again, I saw white OSD text. >=20 > Hence I think sample_c with the paletted textures is used in the driv= er. That sounds like the palette is actually working, then. Great :) I doubt that libva would use sample_c - sampling with a shadow comparis= on? It looks like it just uses sample and sample+killpix. I'm pretty sure the sample_c optimization just uses the palette memory = as storage for some stuff, so it's quite possible it just works if you're only using sample and sample+killpix. =2D-Ken --nextPart2333321.A9RdKh6Dkn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJUq4jDAAoJEFtb2gcdScw4Rs8QAJsGR4Pg0SFH0Mhf+zAf9XFg ZhTZRmmwRdKkhqpXYg6bgRE911sAtYpaBGea+s5DXgZ3gPQ6qJWoyom86ZOsN1Hq gMO9Y6KkpdU277dbeWcNqVnbOiVotmRZ3Uox88qRyUZ3YJptRDOuHIusmUephY+C 7ffMaG5kw9B3IKh55EAPsO3sdIqucQIVrSP6sEmawVcaYbaYx5nIKi773fMXFQwa gDv9+VuM1xIy33yQB1/vIeNnUsYGjgPsu2d5rt/1QcUXQHcXfGEjjYbsNJRF3h0U g9tby/a4DmnJLR5ZNxxTxezRim610CFq3BHeEt4IDi8399K1Cv+oLuzOy8UoY/7t ETQ/ZYFYchzQ8taDpIQjVshvDa3HZUSvthG4a5YJV8Ya95tnGn9S9iUqTDUK7N/Y XUtRGvDgpLShpfDcgezXzen3bd5kakT2IQK8MSkMhxmaJC+hyBtiAGRp1ks/Houo VewsiTiA9GX/4F35knvfu2faDDYzFgX9mTjgTH+8fkja8x6el/pRE6m3CT66Plux GIIVShRR76gHAjxnX+HKPRCoYP3dtopVTOckGnMHejr2DriTlTmYVWm+sm0vX4gK ZwX44V3vEiXKBppft1tzByd9n/thgxOCOm2pj3KdarhNspXUX+kIIP8RGeAXPetI F/P8QtZ0ksvw3ktXeJFw =GWmr -----END PGP SIGNATURE----- --nextPart2333321.A9RdKh6Dkn-- --===============1129371816== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1129371816==--