Re: [PATCH 7/8] drm/i915: Add NV12 as supported format for sprite plane

Srinivas, Vidya
2017-07-07T05:12:14Z

> -----Original Message-----
> From: Taylor, Clinton A
> Sent: Friday, July 7, 2017 4:20 AM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 7/8] drm/i915: Add NV12 as supported
> format for sprite plane
>
>
>
> On 06/19/2017 11:10 PM, Vidya Srinivas wrote:
> > From: Chandra Konduru <chandra.konduru@intel.com>
> >
> > This patch adds NV12 to list of supported formats for sprite plane.
> >
> > v2: Rebased (me)
> >
> > v3: Review comments by Ville addressed
> > - Removed skl_plane_formats_with_nv12 and added
> > NV12 case in existing skl_plane_formats
> > - Added the 10bpc RGB formats
> >
> > Signed-off-by: Chandra Konduru <chandra.konduru@intel.com>
> > Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_sprite.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_sprite.c
> > b/drivers/gpu/drm/i915/intel_sprite.c
> > index d4665d2..2a388b6f 100644
> > --- a/drivers/gpu/drm/i915/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/intel_sprite.c
> > @@ -1074,10 +1074,13 @@ int intel_sprite_set_colorkey(struct
> drm_device *dev, void *data,
> > DRM_FORMAT_ARGB8888,
> > DRM_FORMAT_XBGR8888,
> > DRM_FORMAT_XRGB8888,
> > + DRM_FORMAT_XBGR2101010,
> > + DRM_FORMAT_ABGR2101010,
>
> Why are we adding 10 bit RGB formats with the NV12 series patches?
> Trying to set XR30 or AB30 results in error returned even though the modes
> are advertised for the planes.

Thank you. I will address the review comments and re-send the patches after rebasing.

Regards
Vidya
>
> -Clint
>
> > DRM_FORMAT_YUYV,
> > DRM_FORMAT_YVYU,
> > DRM_FORMAT_UYVY,
> > DRM_FORMAT_VYUY,
> > + DRM_FORMAT_NV12,
> > };
> >
> > struct intel_plane *