Re: [PATCH 8/8] drm/i915: Add NV12 support to intel_framebuffer_init

Srinivas, Vidya
2017-07-07T05:10:55Z

> -----Original Message-----
> From: Taylor, Clinton A
> Sent: Friday, July 7, 2017 4:26 AM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 8/8] drm/i915: Add NV12 support to
> intel_framebuffer_init
>
>
>
> On 06/19/2017 11:10 PM, Vidya Srinivas wrote:
> > From: Chandra Konduru <chandra.konduru@intel.com>
> >
> > This patch adds NV12 as supported format to intel_framebuffer_init and
> > performs various checks.
> >
> > v2:
> > -Fix an issue in checks added (Chandra Konduru)
> >
> > v3: rebased (me)
> >
> > v4: Review comments by Ville addressed
> > Added platform check for NV12 in intel_framebuffer_init
> > Removed offset checks for NV12 case
> >
> > Signed-off-by: Chandra Konduru <chandra.konduru@intel.com>
> > Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index 83b20fd..56fd9ae 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -14765,6 +14765,10 @@ static int intel_framebuffer_init(struct
> intel_framebuffer *intel_fb,
> > goto err;
> > }
> > break;
> > + case DRM_FORMAT_NV12:
> > + if (INTEL_GEN(dev_priv) >= 9)
> > + break;
> > + goto err;
> This NV12 support only correctly works on SKL. Plane color space conversion
> is different on GLK and later platforms causing the colors to display
> incorrectly. Ville's plane color space property patch series in review will fix
> this issue.
>
Thank you. I will address the review comments and re-send the patches after rebasing.
> Tested-by: Clinton Taylor <clinton.a.taylor@intel.com>
> Reviewed-by: Clinton Taylor <clinton.a.taylor@intel.com>
>
> -Clint
>
> > default:
> > DRM_DEBUG_KMS("unsupported pixel format: %s\n",
> > drm_get_format_name(mode_cmd-
> >pixel_format, &format_name));