From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme Date: Sun, 01 May 2016 18:04:53 -0700 Message-ID: <1925265.fAiRrqykug@eiger> References: <1461232428-17482-1-git-send-email-eric.engestrom@imgtec.com> <20160428181305.GD8368@imgtec.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1773334110==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: mesa-dev-bounces@lists.freedesktop.org Sender: "mesa-dev" To: mesa-dev@lists.freedesktop.org Cc: "intel-gfx@lists.freedesktop.org" , Emil Velikov List-Id: intel-gfx@lists.freedesktop.org --===============1773334110== Content-Type: multipart/signed; boundary="nextPart21516178.bXM1ndzg5r"; micalg="pgp-sha256"; protocol="application/pgp-signature" --nextPart21516178.bXM1ndzg5r Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > On 28 April 2016 at 19:13, Eric Engestrom wrote: > > On Mon, Apr 25, 2016 at 05:08:18PM +0100, Emil Velikov wrote: > >> On 21 April 2016 at 11:24, Eric Engestrom wrote: > >> > Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all the > >> > VK_PROTOTYPES to VK_NO_PROTOTYPES > >> > This brings the Intel header in line with the rest of the Vulkan code. > >> > > >> > Signed-off-by: Eric Engestrom > >> Reviewed-by: Emil Velikov > >> > >> > --- > >> > > >> > This might break code that was using the old guard scheme (not sure how > >> > that could've worked anyway). > >> > What the policy on this? > >> > > >> > v2: rebase on top of 3caf2e89aa1711e80db80d2056e0a44663d9c7d2 > >> > ("anv: fix build without Wayland platform"). Should've done that the > >> > first time around, sorry :] > >> > > >> > include/vulkan/vulkan_intel.h | 2 +- > >> > src/intel/vulkan/anv_private.h | 1 - > >> > 2 files changed, 1 insertion(+), 2 deletions(-) > >> > > >> > diff --git a/include/vulkan/vulkan_intel.h b/include/vulkan/ vulkan_intel.h > >> > index 1f77128..8ede61b 100644 > >> > --- a/include/vulkan/vulkan_intel.h > >> > +++ b/include/vulkan/vulkan_intel.h > >> > @@ -44,7 +44,7 @@ typedef struct VkDmaBufImageCreateInfo_ > >> > > >> > typedef VkResult (VKAPI_PTR *PFN_vkCreateDmaBufImageINTEL)(VkDevice device, const VkDmaBufImageCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDeviceMemory* pMem, VkImage* pImage); > >> > > >> > -#ifdef VK_PROTOTYPES > >> > +#ifndef VK_NO_PROTOTYPES > >> > > >> Would be great to hear from the Intel guys, if there is a another > >> Cannonical repo where this change should land first ? > > > > CC'ing intel-gfx even though this isn't X-related, because I don't know > > of any other way to contact you guys :] > > > Adding the anv authors. > > Jason, Chad, is there a canonical place where changes to > vulkan_intel.h should land first ? Eric has a nice fix which we want > in mesa. > > Thanks > Emil I'm pretty sure Mesa is the only repository where this lives. --nextPart21516178.bXM1ndzg5r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXJqe1AAoJEFtb2gcdScw4DekP/0l8XTFjDzfixAQmnJ+rQuMO bJQyuAg9YWwqHblI2dtPVlckQ2hf0pbQxXpFuG2DXrPsXGg2ni3c7JWq0FOFAIFP huiWykSqZfirW5itqhA0+GfDLpnzerdejjfvJQSIC35Dzpbmtk2wEUanXoG8XNFz YUbcI2n30fnM9PgfCQgxSmr+GbuaXul9LYREFgIWwk8I/GQEAQc/s+GAEAF86Mdo dpsnOD2MgmkacSCvDgTnokTnskIk4+8Chsmm76wnReymZIgE3G5OuoNLYrt2LUqs OFUd/ytY5Qsa/5fbL3qJ3AnvpEk1BDsw3p5aC2S91jBVHnWXwpjPexM7PYHXvCgj /X7U419yZMG5ULcvbV9QAmlxvnSLFBUBcodPIemPFmOzxn/LzBi3QdhdcdVPok3+ dTaueZWlJgbSQQDu3HEoOJfKoacbVZ3HlqasMRsxysUPzA2aF5iqr1cQLw3htEae XS38oersLqIMnezRDFdvs8/aEAIHJ2inT21H7bChjHIRQeDLWcX7LkvaKofXVHQG //gSX6z3SFgaVXVqF0KGeoLgzIcsxtjlNn1ciLu70DxsrRUJ08O6T/rV/0gLMQVz 7EieeohizCcNX/lEYZmnQiL7sarCcCCUq6xtqew52AfLQVyX+UOAeqHLIjsn0Sfo 8m86zEn+vz4P+UaWN7UF =POab -----END PGP SIGNATURE----- --nextPart21516178.bXM1ndzg5r-- --===============1773334110== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbWVzYS1kZXYg bWFpbGluZyBsaXN0Cm1lc2EtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL21lc2EtZGV2Cg== --===============1773334110==--