From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm: Use idr_init_base(1) when using id==0 for invalid Date: Tue, 13 Feb 2018 14:48:24 +0100 Message-ID: <199ee3c2-dbb8-574e-1671-76d79332d638@amd.com> References: <20180212145533.30046-1-chris@chris-wilson.co.uk> <20180212171420.GT5453@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180212171420.GT5453@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Dave Airlie List-Id: intel-gfx@lists.freedesktop.org QW0gMTIuMDIuMjAxOCB1bSAxODoxNCBzY2hyaWViIFZpbGxlIFN5cmrDpGzDpDoKPiBPbiBNb24s IEZlYiAxMiwgMjAxOCBhdCAwMjo1NTozM1BNICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+ IFVzZSB0aGUgbmV3IGlkcl9pbml0X2Jhc2UoKSBmdW5jdGlvbiB0byBjcmVhdGUgYW4gSURSIHRo YXQga25vd3MgaWQ9PTAKPj4gaXMgbmV2ZXIgYWxsb2NhdGVkIGFzIGl0IG1hcHMgdG8gYW4gaW52 YWxpZCBpZGVudGlmaWVyLiBCeSBrbm93aW5nIHRoYXQKPj4gaWQ9PTAgaXMgaW52YWxpZCwgdGhl IElEUiBjYW4gc3RhcnQgZnJvbSBpZD0xIGluc3RlYWQgYXZvaWRpbmcgdGhlIGlzc3VlCj4+IG9m IGhhdmluZyB0byBzdGFydCBlYWNoIGxvb2t1cCBmcm9tIHRoZSB6ZXJvdGggbGVhZiBhcyBpZD09 MCBpcyBhbHdheXMKPj4gdW51c2VkIChhbmQgdGh1cyB0aGUgdHJlZS1vZi1iaXRtYXBzIGluZGlj YXRlIHRoYXQgaXMgdGhlIGZpcnN0Cj4+IGF2YWlsYWJsZSkuCj4+Cj4+IFJlZmVyZW5jZXM6IDZj ZTcxMWYyNzUwMCAoImlkcjogTWFrZSAxLWJhc2VkIElEUnMgbW9yZSBlZmZpY2llbnQiKQo+PiBT aWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4g Q2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4+IENjOiBDaHJpc3Rp YW4gS29uaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPj4gQ2M6IERhdmUgQWlybGllIDxh aXJsaWVkQHJlZGhhdC5jb20+Cj4gWWVwLCBsb29rcyBsaWtlIGFsbCBvZiB0aGVzZSBwYXNzIHN0 YXJ0PT0xIHRvIGlkcl9hbGxvYygpLgo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKQWNrZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcg PGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4gYXMgd2VsbC4KClByb2JhYmx5IGdvaW5nIHRvIGRv IHRoaXMgZm9yIHRoZSBjb21tYW5kIHN1Ym1pc3Npb24gY29udGV4dCBoYW5kbGVzIGluIAphbWRn cHUgYXMgd2VsbC4KClRoYW5rcywKQ2hyaXN0aWFuLgoKPgo+IExvb2tzIGxpa2UgYXQgbGVhc3Qg dGlsZV9pZHIgYW5kIGNydGNfaWRyIGNvdWxkIHVzZSB0aGlzIGFzIHdlbGwsCj4gYWx0aG91Z2gg SSBzdXBwb3NlIHRoZXkncmUgbm90IGhpdCBuZWFybHkgYXMgaGFyZCBhcyB0aGUgZ2VtIHN0dWZm Lgo+IEFsc28gc29tZW9uZSBzaG91bGQgcmVhbGx5IHMvY3J0Y19pZHIvb2JqX2lkX2lkci8gb3Ig c29tZXRoaW5nCj4gYWxvbmcgdGhvc2UgbGluZXMuCj4KPj4gLS0tCj4+IE5vdGUgdGhpcyByZXF1 aXJlcyA0LjE2LXJjMS4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9nZW0uYyAgICAg fCA0ICsrLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYyB8IDIgKy0KPj4gICAy IGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPj4KPj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2dlbS5jCj4+IGluZGV4IDAxZjhkOTQ4MTIxMS4uNDk3NWJhOWE3YmM4IDEwMDY0NAo+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f Z2VtLmMKPj4gQEAgLTk4LDcgKzk4LDcgQEAgZHJtX2dlbV9pbml0KHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpCj4+ICAgCXN0cnVjdCBkcm1fdm1hX29mZnNldF9tYW5hZ2VyICp2bWFfb2Zmc2V0X21h bmFnZXI7Cj4+ICAgCj4+ICAgCW11dGV4X2luaXQoJmRldi0+b2JqZWN0X25hbWVfbG9jayk7Cj4+ IC0JaWRyX2luaXQoJmRldi0+b2JqZWN0X25hbWVfaWRyKTsKPj4gKwlpZHJfaW5pdF9iYXNlKCZk ZXYtPm9iamVjdF9uYW1lX2lkciwgMSk7Cj4+ICAgCj4+ICAgCXZtYV9vZmZzZXRfbWFuYWdlciA9 IGt6YWxsb2Moc2l6ZW9mKCp2bWFfb2Zmc2V0X21hbmFnZXIpLCBHRlBfS0VSTkVMKTsKPj4gICAJ aWYgKCF2bWFfb2Zmc2V0X21hbmFnZXIpIHsKPj4gQEAgLTc3Niw3ICs3NzYsNyBAQCBkcm1fZ2Vt X29wZW5faW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPj4gICB2b2lk Cj4+ICAgZHJtX2dlbV9vcGVuKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fZmls ZSAqZmlsZV9wcml2YXRlKQo+PiAgIHsKPj4gLQlpZHJfaW5pdCgmZmlsZV9wcml2YXRlLT5vYmpl Y3RfaWRyKTsKPj4gKwlpZHJfaW5pdF9iYXNlKCZmaWxlX3ByaXZhdGUtPm9iamVjdF9pZHIsIDEp Owo+PiAgIAlzcGluX2xvY2tfaW5pdCgmZmlsZV9wcml2YXRlLT50YWJsZV9sb2NrKTsKPj4gICB9 Cj4+ICAgCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jCj4+IGluZGV4IDBiN2IwZDFhZDJkNS4uZDRmNGNl NDg0NTI5IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYwo+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYwo+PiBAQCAtNTQ2LDcgKzU0Niw3IEBA IHN0YXRpYyBpbnQgZHJtX3N5bmNvYmpfZXhwb3J0X3N5bmNfZmlsZShzdHJ1Y3QgZHJtX2ZpbGUg KmZpbGVfcHJpdmF0ZSwKPj4gICB2b2lkCj4+ICAgZHJtX3N5bmNvYmpfb3BlbihzdHJ1Y3QgZHJt X2ZpbGUgKmZpbGVfcHJpdmF0ZSkKPj4gICB7Cj4+IC0JaWRyX2luaXQoJmZpbGVfcHJpdmF0ZS0+ c3luY29ial9pZHIpOwo+PiArCWlkcl9pbml0X2Jhc2UoJmZpbGVfcHJpdmF0ZS0+c3luY29ial9p ZHIsIDEpOwo+PiAgIAlzcGluX2xvY2tfaW5pdCgmZmlsZV9wcml2YXRlLT5zeW5jb2JqX3RhYmxl X2xvY2spOwo+PiAgIH0KPj4gICAKPj4gLS0gCj4+IDIuMTYuMQo+Pgo+PiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBkcmktZGV2ZWwgbWFpbGluZyBs aXN0Cj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=