From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/3] drm/i915: Move the irq wait queue initialisation into the ring init Date: Thu, 14 Apr 2011 07:58:02 +0100 Message-ID: <1bdc18$k7dkft@fmsmga002.fm.intel.com> References: <1302683305-19417-1-git-send-email-chris@chris-wilson.co.uk> <1302683305-19417-3-git-send-email-chris@chris-wilson.co.uk> <20110414062019.GA10182@lundgren.kumite> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 89EB89F51B for ; Wed, 13 Apr 2011 23:58:05 -0700 (PDT) In-Reply-To: <20110414062019.GA10182@lundgren.kumite> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 13 Apr 2011 23:20:19 -0700, Ben Widawsky wrote: > I don't really understand why we went from DRM_INIT_WAITQUEUE to > init_waitqueue_head, but I'm okay with it. Because I share upstream's opinion that we really should not have an OS agnostic middlelayer (that is nothing more than SHOUTING at times like this), and gradually wean ourselves off it whenever I get the chance. -Chris -- Chris Wilson, Intel Open Source Technology Centre