From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/3] drm/i915: Attach a fb to the load-detect pipe Date: Wed, 20 Apr 2011 10:25:37 +0100 Message-ID: <1bdc18$k9qq24@fmsmga002.fm.intel.com> References: <1303245123-27172-1-git-send-email-chris@chris-wilson.co.uk> <1303245123-27172-3-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 943219EAFC for ; Wed, 20 Apr 2011 02:25:40 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 19 Apr 2011 14:26:04 -0700, Keith Packard wrote: > On Tue, 19 Apr 2011 21:32:02 +0100, Chris Wilson wrote: > > > We need to ensure that we feed valid memory into the display plane > > attached to the pipe when switching the pipe on. Otherwise, the display > > engine may read through an invalid PTE and so throw an PGTBL_ER > > exception. > > This seems to rewrite most of the load detection code, but doesn't > justify that rewrite in comments (either commit or in-line). You'll need > to break this up so that we can actually see what is changing. I created a fresh series of patches that hopefully clarifies what needs to be corrected in intel_get_load_detect_pipe(). It was meant to be attached here, but I failed to drive git send-email correctly. :( -Chris -- Chris Wilson, Intel Open Source Technology Centre