From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F03AAC4332F for ; Mon, 13 Sep 2021 05:31:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA5BA60F9B for ; Mon, 13 Sep 2021 05:31:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AA5BA60F9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C40D589CD3; Mon, 13 Sep 2021 05:31:55 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F5CC89CD3; Mon, 13 Sep 2021 05:31:54 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10105"; a="221240747" X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="221240747" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2021 22:31:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="451433212" Received: from irsmsx606.ger.corp.intel.com ([163.33.146.139]) by orsmga002.jf.intel.com with ESMTP; 12 Sep 2021 22:31:52 -0700 Received: from bgsmsx604.gar.corp.intel.com (10.67.234.6) by IRSMSX606.ger.corp.intel.com (163.33.146.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 13 Sep 2021 06:31:51 +0100 Received: from bgsmsx604.gar.corp.intel.com ([10.67.234.6]) by BGSMSX604.gar.corp.intel.com ([10.67.234.6]) with mapi id 15.01.2242.012; Mon, 13 Sep 2021 11:01:50 +0530 From: "Shankar, Uma" To: "Nikula, Jani" , "intel-gfx@lists.freedesktop.org" CC: "dri-devel@lists.freedesktop.org" , "ville.syrjala@linux.intel.com" , "Nikula, Jani" Thread-Topic: [PATCH v2 1/6] drm/displayid: re-align data block macros Thread-Index: AQHXnnMAa5BQecbV1Eqpk4y2zQAWGquhhC2w Date: Mon, 13 Sep 2021 05:31:49 +0000 Message-ID: <1e6e31e240cd48888c3fcd08db20c523@intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.223.10.1] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v2 1/6] drm/displayid: re-align data block macros X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > -----Original Message----- > From: dri-devel On Behalf Of Ja= ni Nikula > Sent: Tuesday, August 31, 2021 7:48 PM > To: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; ville.syrjala@linux.intel.com; Nikul= a, Jani > > Subject: [PATCH v2 1/6] drm/displayid: re-align data block macros >=20 > Make the values easier to read. Also add DisplayID Structure version and = revision > information (this is different from the spec version). Looks ok to me. Reviewed-by: Uma Shankar > Signed-off-by: Jani Nikula > --- > include/drm/drm_displayid.h | 57 +++++++++++++++++++------------------ > 1 file changed, 29 insertions(+), 28 deletions(-) >=20 > diff --git a/include/drm/drm_displayid.h b/include/drm/drm_displayid.h in= dex > ec64d141f578..0ed9445b5482 100644 > --- a/include/drm/drm_displayid.h > +++ b/include/drm/drm_displayid.h > @@ -26,35 +26,36 @@ >=20 > struct edid; >=20 > -#define DATA_BLOCK_PRODUCT_ID 0x00 > -#define DATA_BLOCK_DISPLAY_PARAMETERS 0x01 -#define > DATA_BLOCK_COLOR_CHARACTERISTICS 0x02 -#define > DATA_BLOCK_TYPE_1_DETAILED_TIMING 0x03 -#define > DATA_BLOCK_TYPE_2_DETAILED_TIMING 0x04 -#define > DATA_BLOCK_TYPE_3_SHORT_TIMING 0x05 -#define > DATA_BLOCK_TYPE_4_DMT_TIMING 0x06 -#define DATA_BLOCK_VESA_TIMING > 0x07 -#define DATA_BLOCK_CEA_TIMING 0x08 -#define > DATA_BLOCK_VIDEO_TIMING_RANGE 0x09 -#define > DATA_BLOCK_PRODUCT_SERIAL_NUMBER 0x0a -#define > DATA_BLOCK_GP_ASCII_STRING 0x0b -#define > DATA_BLOCK_DISPLAY_DEVICE_DATA 0x0c -#define > DATA_BLOCK_INTERFACE_POWER_SEQUENCING 0x0d -#define > DATA_BLOCK_TRANSFER_CHARACTERISTICS 0x0e -#define > DATA_BLOCK_DISPLAY_INTERFACE 0x0f -#define > DATA_BLOCK_STEREO_DISPLAY_INTERFACE 0x10 -#define > DATA_BLOCK_TILED_DISPLAY 0x12 -#define DATA_BLOCK_CTA 0x81 > +/* DisplayID Structure v1r2 Data Blocks */ > +#define DATA_BLOCK_PRODUCT_ID 0x00 > +#define DATA_BLOCK_DISPLAY_PARAMETERS 0x01 > +#define DATA_BLOCK_COLOR_CHARACTERISTICS 0x02 > +#define DATA_BLOCK_TYPE_1_DETAILED_TIMING 0x03 > +#define DATA_BLOCK_TYPE_2_DETAILED_TIMING 0x04 > +#define DATA_BLOCK_TYPE_3_SHORT_TIMING 0x05 > +#define DATA_BLOCK_TYPE_4_DMT_TIMING 0x06 > +#define DATA_BLOCK_VESA_TIMING 0x07 > +#define DATA_BLOCK_CEA_TIMING 0x08 > +#define DATA_BLOCK_VIDEO_TIMING_RANGE 0x09 > +#define DATA_BLOCK_PRODUCT_SERIAL_NUMBER 0x0a > +#define DATA_BLOCK_GP_ASCII_STRING 0x0b > +#define DATA_BLOCK_DISPLAY_DEVICE_DATA 0x0c > +#define DATA_BLOCK_INTERFACE_POWER_SEQUENCING 0x0d > +#define DATA_BLOCK_TRANSFER_CHARACTERISTICS 0x0e > +#define DATA_BLOCK_DISPLAY_INTERFACE 0x0f > +#define DATA_BLOCK_STEREO_DISPLAY_INTERFACE 0x10 > +#define DATA_BLOCK_TILED_DISPLAY 0x12 > +#define DATA_BLOCK_VENDOR_SPECIFIC 0x7f > +#define DATA_BLOCK_CTA 0x81 >=20 > -#define DATA_BLOCK_VENDOR_SPECIFIC 0x7f > - > -#define PRODUCT_TYPE_EXTENSION 0 > -#define PRODUCT_TYPE_TEST 1 > -#define PRODUCT_TYPE_PANEL 2 > -#define PRODUCT_TYPE_MONITOR 3 > -#define PRODUCT_TYPE_TV 4 > -#define PRODUCT_TYPE_REPEATER 5 > -#define PRODUCT_TYPE_DIRECT_DRIVE 6 > +/* DisplayID Structure v1r2 Product Type */ > +#define PRODUCT_TYPE_EXTENSION 0 > +#define PRODUCT_TYPE_TEST 1 > +#define PRODUCT_TYPE_PANEL 2 > +#define PRODUCT_TYPE_MONITOR 3 > +#define PRODUCT_TYPE_TV 4 > +#define PRODUCT_TYPE_REPEATER 5 > +#define PRODUCT_TYPE_DIRECT_DRIVE 6 >=20 > struct displayid_header { > u8 rev; > -- > 2.30.2