From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 6/8] drm/i915/tracepoints: Rename i915_gem_request_notify
Date: Mon, 20 Feb 2017 15:58:12 +0000 [thread overview]
Message-ID: <1f01bb49-b212-d44b-9abb-d628d7cd0c1b@linux.intel.com> (raw)
In-Reply-To: <20170130194426.GT24154@nuc-i3427.alporthouse.com>
On 30/01/2017 19:44, Chris Wilson wrote:
> On Mon, Jan 30, 2017 at 06:07:29PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> i915_gem_ring_notify is more appropriate since we do not have
>> the request information at this point, but it is simply a
>> signal from the engine that some request has been completed.
>>
>> v2:
>> * Always trace and log if there were any waiters.
> Agreed, I'd sketched that change, well to always emit the tracepoint when
> the interrupt fired. Whether it was in vain is icing on the cake - I've
> some sketches of keeping the user-interrupt alive until the following rq
> to short-circuit some ping-ponging or irq enable state.
Shall we progress this series or leave it for some future convenient time?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-20 15:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 12:01 [RFC 0/8] Tracepoints cleanup and improvements for requests Tvrtko Ursulin
2017-01-27 12:01 ` [RFC 1/8] drm/i915/tracepoints: Tidy request event class Tvrtko Ursulin
2017-01-27 12:01 ` [RFC 2/8] drm/i915/tracepoints: Adjust i915_gem_ring_dispatch Tvrtko Ursulin
2017-01-27 12:37 ` Chris Wilson
2017-01-30 18:05 ` [PATCH v2 " Tvrtko Ursulin
2017-01-27 12:01 ` [RFC 3/8] drm/i915/tracepoints: Tidy i915_gem_request_wait_begin Tvrtko Ursulin
2017-01-27 12:14 ` Chris Wilson
2017-01-30 18:06 ` [PATCH v2 " Tvrtko Ursulin
2017-01-27 12:01 ` [RFC 4/8] drm/i915/tracepoints: Remove unused i915_gem_request_complete Tvrtko Ursulin
2017-01-27 12:46 ` Chris Wilson
2017-01-27 12:01 ` [RFC 5/8] drm/i915/tracepoints: Add request submit and execute tracepoints Tvrtko Ursulin
2017-01-27 12:01 ` [RFC 6/8] drm/i915/tracepoints: Rename i915_gem_request_notify Tvrtko Ursulin
2017-01-27 12:20 ` Chris Wilson
2017-01-27 13:56 ` Tvrtko Ursulin
2017-01-30 18:07 ` [PATCH v2 " Tvrtko Ursulin
2017-01-30 19:44 ` Chris Wilson
2017-02-20 15:58 ` Tvrtko Ursulin [this message]
2017-02-20 16:07 ` Chris Wilson
2017-02-20 17:13 ` Tvrtko Ursulin
2017-01-27 12:01 ` [RFC 7/8] drm/i915/tracepoints: Add backend level request in and out tracepoints Tvrtko Ursulin
2017-01-27 12:27 ` Chris Wilson
2017-01-27 13:59 ` Tvrtko Ursulin
2017-01-27 14:07 ` Chris Wilson
2017-01-27 14:18 ` Tvrtko Ursulin
2017-01-27 14:29 ` Chris Wilson
2017-01-30 18:08 ` [PATCH v2 " Tvrtko Ursulin
2017-01-27 12:01 ` [RFC 8/8] drm/i915/tracepoints: Add hw_id to context tracepoints Tvrtko Ursulin
2017-01-27 13:32 ` ✗ Fi.CI.BAT: failure for Tracepoints cleanup and improvements for requests Patchwork
2017-01-30 23:24 ` ✓ Fi.CI.BAT: success for Tracepoints cleanup and improvements for requests (rev5) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f01bb49-b212-d44b-9abb-d628d7cd0c1b@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox