From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 6/6] drm/i915: Clean up gen2 DPLL readout Date: Tue, 19 Mar 2019 13:34:31 +0000 Message-ID: <1f079235-794d-45ec-e57d-688c5ce4ef3a@linux.intel.com> References: <20190318165633.28924-1-ville.syrjala@linux.intel.com> <20190318165633.28924-6-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F42F89468 for ; Tue, 19 Mar 2019 13:34:33 +0000 (UTC) In-Reply-To: <20190318165633.28924-6-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzAzLzIwMTkgMTY6NTYsIFZpbGxlIFN5cmphbGEgd3JvdGU6Cj4gRnJvbTogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBUaGUgY3VycmVu dCBnZW4yIERQTEwgcmVhZG91dCBjb2RlOgo+ICogYXNzdW1lcyBpODQ1L2k4NjUgaGF2ZSBMVkRT IHdoaWNoIGlzIG5vdCB0cnVlCj4gKiBhc3N1bWVzIG9ubHkgcGlwZSBCIGNhbiBkcml2ZSBMVkRT ICh0cnVlLCBidXQgbWFrZXMKPiAgICB0aGUgY29kZSBhcHBlYXIgYSBiaXQgbWFnaWNhbCkKPiAq IGhhcmQgdG8gcGFyc2UgaW4gZ2VuZXJhbAo+IAo+IENsZWFuIGl0IHVwIGJ5IGNoZWNraW5nIGZv ciBpODV4ICh0aGUgb25seSBnZW4yIHBsYXRmb3JtCj4gd2l0aCBMVkRTKSBhbmQgcmV1c2luZyBp bnRlbF9sdmRzX3BvcnRfZW5hYmxlZCgpLgo+IAo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtv LnVyc3VsaW5AbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzD pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxMCArKysrKystLS0tCj4gICAxIGZpbGUgY2hhbmdl ZCwgNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiBpbmRleCAyYmE2MTE4MTc0NmQuLjlmMzFkOTRmYzA0YiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTA4MDksNyArMTA4MDksNiBA QCBzdGF0aWMgdm9pZCBpOXh4X2NydGNfY2xvY2tfZ2V0KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRj LAo+ICAgewo+ICAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKPiAg IAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gLQlp bnQgcGlwZSA9IHBpcGVfY29uZmlnLT5jcHVfdHJhbnNjb2RlcjsKPiAgIAl1MzIgZHBsbCA9IHBp cGVfY29uZmlnLT5kcGxsX2h3X3N0YXRlLmRwbGw7Cj4gICAJdTMyIGZwOwo+ICAgCXN0cnVjdCBk cGxsIGNsb2NrOwo+IEBAIC0xMDg1OCwxMCArMTA4NTcsMTMgQEAgc3RhdGljIHZvaWQgaTl4eF9j cnRjX2Nsb2NrX2dldChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgIAkJZWxzZQo+ICAgCQkJ cG9ydF9jbG9jayA9IGk5eHhfY2FsY19kcGxsX3BhcmFtcyhyZWZjbGssICZjbG9jayk7Cj4gICAJ fSBlbHNlIHsKPiAtCQl1MzIgbHZkcyA9IElTX0k4MzAoZGV2X3ByaXYpID8gMCA6IEk5MTVfUkVB RChMVkRTKTsKPiAtCQlib29sIGlzX2x2ZHMgPSAocGlwZSA9PSAxKSAmJiAobHZkcyAmIExWRFNf UE9SVF9FTik7Cj4gKwkJZW51bSBwaXBlIGx2ZHNfcGlwZTsKPiArCj4gKwkJaWYgKElTX0k4NVgo ZGV2X3ByaXYpICYmCj4gKwkJICAgIGludGVsX2x2ZHNfcG9ydF9lbmFibGVkKGRldl9wcml2LCBM VkRTLCAmbHZkc19waXBlKSAmJgo+ICsJCSAgICBsdmRzX3BpcGUgPT0gY3J0Yy0+cGlwZSkgewo+ ICsJCQl1MzIgbHZkcyA9IEk5MTVfUkVBRChMVkRTKTsKPiAgIAo+IC0JCWlmIChpc19sdmRzKSB7 Cj4gICAJCQljbG9jay5wMSA9IGZmcygoZHBsbCAmIERQTExfRlBBMDFfUDFfUE9TVF9ESVZfTUFT S19JODMwX0xWRFMpID4+Cj4gICAJCQkJICAgICAgIERQTExfRlBBMDFfUDFfUE9TVF9ESVZfU0hJ RlQpOwo+ICAgCj4gCgpJIGRlZmVyIHRvIGRvbWFpbiBleHBlcnRzIG9uIHRoaXMgb25lLgoKUmVn YXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n Zng=