From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH v2 7/7] drm/i915: fix gtt space allocated
	for tiled objects
Date: Tue, 08 Jan 2013 09:59:26 +0000
Message-ID: <1f4a33$5k1ho3@AZSMGA002.ch.intel.com>
References: <1357588059-6631-1-git-send-email-imre.deak@intel.com>
	<1357588059-6631-8-git-send-email-imre.deak@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id AE242E6090
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  8 Jan 2013 01:59:44 -0800 (PST)
In-Reply-To: <1357588059-6631-8-git-send-email-imre.deak@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon,  7 Jan 2013 21:47:39 +0200, Imre Deak <imre.deak@intel.com> wrote:
> @@ -361,13 +363,15 @@ i915_gem_set_tiling(struct drm_device *dev, void *data,
>  		obj->map_and_fenceable =
>  			obj->gtt_space == NULL ||
>  			(obj->gtt_offset + obj->base.size <= dev_priv->mm.gtt_mappable_end &&
> -			 i915_gem_object_fence_ok(obj, args->tiling_mode));
> +			 i915_gem_object_fence_ok(obj, args->tiling_mode,
> +						  args->stride));

This is a big problem as this will now cause stalls where the code
expects none.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre