From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Gupta, Anshuman" <anshuman.gupta@intel.com>
Subject: Re: [PATCH v5 3/9] drm/i915/tgl: Add power well to
 enable DC3CO state
Date: Tue, 27 Aug 2019 18:31:31 +0530
Message-ID: <1f9c178c-6ef6-e77f-c643-5504a10aa977@intel.com>
References: <20190809183223.12031-1-anshuman.gupta@intel.com>
 <20190809183223.12031-4-anshuman.gupta@intel.com>
 <20190813144634.GA21986@ideak-desk.fi.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9DA8089683
 for <intel-gfx@lists.freedesktop.org>; Tue, 27 Aug 2019 13:01:46 +0000 (UTC)
In-Reply-To: <20190813144634.GA21986@ideak-desk.fi.intel.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: imre.deak@intel.com
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

CgpPbiA4LzEzLzIwMTkgODoxNiBQTSwgSW1yZSBEZWFrIHdyb3RlOgo+IE9uIFNhdCwgQXVnIDEw
LCAyMDE5IGF0IDEyOjAyOjE3QU0gKzA1MzAsIEFuc2h1bWFuIEd1cHRhIHdyb3RlOgo+PiAiREMz
Q08gT2ZmIiBwb3dlciB3ZWxsIGluaGVyaXRzIGl0cyBwb3dlciBkb21haW5zIGZyb20KPj4gIkRD
IE9mZiIgcG93ZXIgd2VsbCwgdGhlc2UgcG93ZXIgZG9tYWlucyB3aWxsIGRpc2FsbG93Cj4+IERD
M0NPIHdoZW4gYW55IGV4dGVybmFsIGRpc3BsYXlzIGFyZSBjb25uZWN0ZWQgYW5kIGF0Cj4+IHRp
bWUgb2YgbW9kZXNldCBhbmQgYXV4IHByb2dyYW1taW5nLgo+PiBSZW5hbWluZyAiREMgT2ZmIiBw
b3dlciB3ZWxsIHRvICJEQzUgT2ZmIiBwb3dlciB3ZWxsLgo+Pgo+PiB2MjogY29tbWl0IGxvZyBp
bXByb3ZlbWVudC4KPj4gdjM6IFVzZWQgaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIgdG8gd2FpdCBm
b3IgREMzQ08gZXhpdC4gW0ltcmVdCj4+ICAgICAgVXNlZCBnZW45X3NldF9kY19zdGF0ZSgpIHRv
IGFsbG93L2Rpc2FsbG93IERDM0NPLiBbSW1yZV0KPj4gICAgICBNb3ZlZCB0cmFuc2NvZGVyIHBz
cjIgZXhpdCBsaW5lIGVuYWJsZW1lbnQgZnJvbSB0Z2xfYWxsb3dfZGMzY28oKQo+PiAgICAgIHRv
IGEgYXBwcm9wcmlhdGUgcGxhY2UgaGFzd2VsbF9jcnRjX2VuYWJsZSgpLiBbSW1yZV0KPj4gICAg
ICBDaGFuZ2VkIHRoZSBEQzNDTyBwb3dlciB3ZWxsIGVuYWJsZWQgY2FsbCBiYWNrIGxvZ2ljIGFz
Cj4+ICAgICAgcmVjb21tZW5kZWQgaW4gcmV2aWV3IGNvbW1lbnRzLiBbSW1yZV0KPj4gdjQ6IFVz
ZWQgd2FpdF9mb3JfdXMoKSBpbnN0ZWFkIG9mIGludGVsX3dhaXRfZm9yX3JlZygpLiBbSW1yZSAo
SVJDKV0KPj4gdjU6IHVzaW5nIHVkZWxheSgpIGluc3RlYWQgb2Ygd2FpdGluZyBmb3IgREMzQ08g
ZXhpdCBzdGF0dXMuCj4+Cj4+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29t
Pgo+PiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+PiBDYzogQW5pbWVzaCBN
YW5uYSA8YW5pbWVzaC5tYW5uYUBpbnRlbC5jb20+Cj4+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJp
Z28udml2aUBpbnRlbC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IEFuc2h1bWFuIEd1cHRhIDxhbnNo
dW1hbi5ndXB0YUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIC4uLi9kcm0vaTkxNS9kaXNwbGF5L2lu
dGVsX2Rpc3BsYXlfcG93ZXIuYyAgICB8IDY5ICsrKysrKysrKysrKysrKysrKy0KPj4gICAxIGZp
bGUgY2hhbmdlZCwgNjcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAt
LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheV9wb3dlci5j
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5X3Bvd2VyLmMKPj4g
aW5kZXggZTJlZjIwMmFlZWVmLi5jOWU5MmQ0OGNkYWIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheV9wb3dlci5jCj4+ICsrKyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheV9wb3dlci5jCj4+IEBAIC03OTEs
NyArNzkxLDI2IEBAIHN0YXRpYyB2b2lkIGdlbjlfc2V0X2RjX3N0YXRlKHN0cnVjdCBkcm1faTkx
NV9wcml2YXRlICpkZXZfcHJpdiwgdTMyIHN0YXRlKQo+PiAgIAlkZXZfcHJpdi0+Y3NyLmRjX3N0
YXRlID0gdmFsICYgbWFzazsKPj4gICB9Cj4+ICAgCj4+IC1zdGF0aWMgdm9pZCBieHRfZW5hYmxl
X2RjOShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICtzdGF0aWMgdm9pZCB0
Z2xfYWxsb3dfZGMzY28oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiArewo+
PiArCWdlbjlfc2V0X2RjX3N0YXRlKGRldl9wcml2LCBEQ19TVEFURV9FTl9EQzNDTyk7Cj4+ICt9
Cj4+ICsKPj4gK3N0YXRpYyB2b2lkIHRnbF9kaXNhbGxvd19kYzNjbyhzdHJ1Y3QgZHJtX2k5MTVf
cHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICt7Cj4+ICsJdTMyIHZhbDsKPj4gKwo+PiArCXZhbCA9IEk5
MTVfUkVBRChEQ19TVEFURV9FTik7Cj4+ICsJdmFsICY9IH5EQ19TVEFURV9EQzNDT19TVEFUVVM7
Cj4+ICsJSTkxNV9XUklURShEQ19TVEFURV9FTiwgdmFsKTsKPj4gKwlnZW45X3NldF9kY19zdGF0
ZShkZXZfcHJpdiwgRENfU1RBVEVfRElTQUJMRSk7Cj4+ICsJLyoKPj4gKwkgKiBEZWxheSBvZiAy
MDB1cyBEQzNDTyBFeGl0IHRpbWUgQi5TcGVjIDQ5MTk2Cj4+ICsJICovCj4+ICsJdWRlbGF5KDIw
MCk7Cj4+ICt9Cj4+ICsKPj4gK3ZvaWQgYnh0X2VuYWJsZV9kYzkoc3RydWN0IGRybV9pOTE1X3By
aXZhdGUgKmRldl9wcml2KQo+PiAgIHsKPj4gICAJYXNzZXJ0X2Nhbl9lbmFibGVfZGM5KGRldl9w
cml2KTsKPj4gICAKPj4gQEAgLTEwMDcsNiArMTAyNiwzMyBAQCBzdGF0aWMgdm9pZCBnZW45X2Rj
X29mZl9wb3dlcl93ZWxsX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2
LAo+PiAgIAkJZ2VuOV9lbmFibGVfZGM1KGRldl9wcml2KTsKPj4gICB9Cj4+ICAgCj4+ICtzdGF0
aWMgdm9pZCB0Z2xfZGMzY29fcG93ZXJfd2VsbF9lbmFibGUoc3RydWN0IGRybV9pOTE1X3ByaXZh
dGUgKmRldl9wcml2LAo+PiArCQkJCQlzdHJ1Y3QgaTkxNV9wb3dlcl93ZWxsICpwb3dlcl93ZWxs
KQo+IAo+IFNob3VsZCBiZSBjYWxsZWQgZGMzY29fb2ZmIHBvd2VyIHdlbGwuCj4gCj4+ICt7Cj4+
ICsJdGdsX2Rpc2FsbG93X2RjM2NvKGRldl9wcml2KTsKPj4gK30KPj4gKwo+PiArc3RhdGljIHZv
aWQgdGdsX2RjM2NvX3Bvd2VyX3dlbGxfZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq
ZGV2X3ByaXYsCj4+ICsJCQkJCSBzdHJ1Y3QgaTkxNV9wb3dlcl93ZWxsICpwb3dlcl93ZWxsKQo+
PiArewo+PiArCWlmICghZGV2X3ByaXYtPnBzci5zaW5rX3BzcjJfc3VwcG9ydCkKPj4gKwkJcmV0
dXJuOwo+IAo+IFdlIGNvdWxkIGVuZCB1cCBlbmFibGluZyBEQzNDTyB3aGlsZSBQU1IyIGlzIGRp
c2FibGVkIGFmdGVyIGRpc2FibGluZwo+IGEgUFNSMiBjYXBhYmxlIG91dHB1dCwgd2hpY2ggaXMg
YWdhaW5zdCB0aGUgc3BlYy4KPiAKPiBJJ20gdGhpbmtpbmcgbm93IHRoYXQgd2Ugc2hvdWxkIGhh
dmUgYSBzaW5nbGUgZGNfb2ZmIHBvd2VyIHdlbGwgYW5kIGEKPiBuZXcgaW50ZXJmYWNlIHNldHRp
bmcgdGhlIG1heCBhbGxvd2VkIERDIHN0YXRlIChEQzNDTywgREM1LzYpLgpIaSBJbXJlLAoKQ291
bGQgeW91IHBsZWFzZSBjb21tZW50IGlmIGJlbG93IHBhcnQgb2YgbmV3IEFQSSBjb2RlIApzZXRf
bWF4X2RjX3N0YXRlKCkgaXMgb2s/IHdpdGggcmVzcGVjdCB0byBvdXIgREMzQ08gZGVzaWduIHN5
bmMuCgpzdGF0aWMgdm9pZCBzZXRfdGFyZ2V0X2RjX3N0YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdikKewogICAgICAgICBnZW45X2RjX29mZl9wb3dlcl93ZWxsX2Rpc2FibGUo
ZGV2X3ByaXYsIE5VTEwpOwp9Cgp2b2lkIHNldF9tYXhfZGNfc3RhdGUoc3RydWN0IGRybV9pOTE1
X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgc3RhdGUpCnsKICAgICAgICAgYm9vbCBkY19vZmZfZW5h
YmxlZDsKICAgICAgICAgc3RydWN0IGk5MTVfcG93ZXJfZG9tYWlucyAqcG93ZXJfZG9tYWlucyA9
IAomZGV2X3ByaXYtPnBvd2VyX2RvbWFpbnM7Ci8qIG5lZWQgdG8gZGVmaW5lIGFuIGlkIGZvciBE
QyBvZmYgcG93ZXIgd2VsbCAiVEdMX0RJU1BfRENfT0ZGIiovCiAgICAgICAgIGRjX29mZl9lbmFi
bGVkID0gaW50ZWxfZGlzcGxheV9wb3dlcl93ZWxsX2lzX2VuYWJsZWQoZGV2X3ByaXYsIApUR0xf
RElTUF9EQ19PRkYpOwoKICAgICAgICAgbXV0ZXhfbG9jaygmcG93ZXJfZG9tYWlucy0+bG9jayk7
CiAgICAgICAgIGlmIChkY19vZmZfZW5hYmxlZCkgewogICAgICAgICAgICAgICAgIGRldl9wcml2
LT5jc3IubWF4X2RjX3N0YXRlID0gc3RhdGU7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAg
ICAgICAgZGV2X3ByaXYtPmNzci5tYXhfZGNfc3RhdGUgPSBzdGF0ZTsKICAgICAgICAgICAgICAg
ICBzZXRfdGFyZ2V0X2RjX3N0YXRlKGRldl9wcml2KTsKICAgICAgICAgfQogICAgICAgICBtdXRl
eF91bmxvY2soJnBvd2VyX2RvbWFpbnMtPmxvY2spOwp9CmdlbjlfZGNfb2ZmX3Bvd2VyX3dlbGxf
ZGlzYWJsZSB3aWxsIGVuYWJsZSBtYXhfZGNfc3RhdGUgdG8gRENfU1RBVEVfRU4KcmVnaXN0ZXIg
YWNjb3JkaW5nbHkuIFRoZXJlIGNhbiBiZSBvbmx5IGlzc3VlIGFjY29yZGluZyB0byBtZSBoZXJl
IHdoZW4gCiJEQyBvZmYiIHBvd2VyIHdlbGwgaXMgZGlzYWJsZSAodGhpcyB3aWxsIGhhcHBlbiB3
aGVuIHdlIHdhbnQgdG8gc2V0IAptYXhfZGNfc3RhdGUgdG8gZGM1IGluIGRjNV9pZGxlX3RocmVh
ZCkuIEluIHRoYXQgY2FzZSB3ZSBuZWVkIHRvIAptYW51YWxseSBjYWxsIHNldF90YXJnZXRfZGNf
c3RhdGUoKS0+Z2VuOV9kY19vZmZfcG93ZXJfd2VsbF9kaXNhYmxlKCkuCgpUaGFua3MsCkFuc2h1
bWFuIEd1cHRhLgo+IAo+IChSaWdodCBub3cgSSB0aGluayB0aGVyZSBpcyBhbHNvIGEgbWlzc2lu
ZyByZS1lbmFibGluZyBvZiBEQzNDTyB3aGVuCj4gICBkaXNhYmxpbmcgREM1LzYpLgo+IAo+PiAr
Cj4+ICsJaWYgKGRldl9wcml2LT5jc3IuYWxsb3dlZF9kY19tYXNrICYgRENfU1RBVEVfRU5fREMz
Q08pCj4+ICsJCXRnbF9hbGxvd19kYzNjbyhkZXZfcHJpdik7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRp
YyBib29sIHRnbF9kYzNjb19wb3dlcl93ZWxsX2VuYWJsZWQoc3RydWN0IGRybV9pOTE1X3ByaXZh
dGUgKmRldl9wcml2LAo+PiArCQkJCQkgc3RydWN0IGk5MTVfcG93ZXJfd2VsbCAqcG93ZXJfd2Vs
bCkKPj4gK3sKPj4gKwkvKgo+PiArCSAqIENoZWNraW5nIGFsb25lIERDX1NUQVRFX0VOIGlzIG5v
dCBlbm91Z2ggYXMgREM1IHBvd2VyIHdlbGwgYWxzbwo+PiArCSAqIGFsbG93L2Rpc2FsbG93IERD
M0NPIHRvIG1ha2Ugc3VyZSBib3RoIGFyZSBub3QgZW5hYmxlZCBhdCBzYW1lIHRpbWUKPj4gKwkg
Ki8KPj4gKwlyZXR1cm4gKChJOTE1X1JFQUQoRENfU1RBVEVfRU4pICYgRENfU1RBVEVfRU5fREMz
Q08pID09IDAgJiYKPj4gKwkJKEk5MTVfUkVBRChEQ19TVEFURV9FTikgJiBEQ19TVEFURV9FTl9V
UFRPX0RDNV9EQzZfTUFTSykgPT0gMCk7Cj4+ICt9Cj4+ICsKPj4gICBzdGF0aWMgdm9pZCBpOXh4
X3Bvd2VyX3dlbGxfc3luY19od19ub29wKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp
diwKPj4gICAJCQkJCSBzdHJ1Y3QgaTkxNV9wb3dlcl93ZWxsICpwb3dlcl93ZWxsKQo+PiAgIHsK
Pj4gQEAgLTI2MTEsNiArMjY1NywxMiBAQCB2b2lkIGludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KHN0
cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gICAJQklUX1VMTChQT1dFUl9ET01B
SU5fVFJBTlNDT0RFUl9WRFNDX1BXMikgfAlcCj4+ICAgCUJJVF9VTEwoUE9XRVJfRE9NQUlOX0lO
SVQpKQo+PiAgIAo+PiArI2RlZmluZSBUR0xfRElTUExBWV9EQzNDT19PRkZfUE9XRVJfRE9NQUlO
UyAoCQlcCj4+ICsJVEdMX1BXXzJfUE9XRVJfRE9NQUlOUyB8CQkJXAo+PiArCUJJVF9VTEwoUE9X
RVJfRE9NQUlOX01PREVTRVQpIHwJCQlcCj4+ICsJQklUX1VMTChQT1dFUl9ET01BSU5fQVVYX0Ep
IHwJCQlcCj4+ICsJQklUX1VMTChQT1dFUl9ET01BSU5fSU5JVCkpCj4+ICsKPj4gICAjZGVmaW5l
IFRHTF9ESVNQTEFZX0RDX09GRl9QT1dFUl9ET01BSU5TICgJCVwKPj4gICAJVEdMX1BXXzJfUE9X
RVJfRE9NQUlOUyB8CQkJXAo+PiAgIAlCSVRfVUxMKFBPV0VSX0RPTUFJTl9NT0RFU0VUKSB8CQkJ
XAo+PiBAQCAtMjcxNSw2ICsyNzY3LDEzIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaTkxNV9wb3dl
cl93ZWxsX29wcyBnZW45X2RjX29mZl9wb3dlcl93ZWxsX29wcyA9IHsKPj4gICAJLmlzX2VuYWJs
ZWQgPSBnZW45X2RjX29mZl9wb3dlcl93ZWxsX2VuYWJsZWQsCj4+ICAgfTsKPj4gICAKPj4gK3N0
YXRpYyBjb25zdCBzdHJ1Y3QgaTkxNV9wb3dlcl93ZWxsX29wcyB0Z2xfZGMzY29fcG93ZXJfd2Vs
bF9vcHMgPSB7Cj4+ICsJLnN5bmNfaHcgPSBpOXh4X3Bvd2VyX3dlbGxfc3luY19od19ub29wLAo+
PiArCS5lbmFibGUgPSB0Z2xfZGMzY29fcG93ZXJfd2VsbF9lbmFibGUsCj4+ICsJLmRpc2FibGUg
PSB0Z2xfZGMzY29fcG93ZXJfd2VsbF9kaXNhYmxlLAo+PiArCS5pc19lbmFibGVkID0gdGdsX2Rj
M2NvX3Bvd2VyX3dlbGxfZW5hYmxlZCwKPj4gK307Cj4+ICsKPj4gICBzdGF0aWMgY29uc3Qgc3Ry
dWN0IGk5MTVfcG93ZXJfd2VsbF9vcHMgYnh0X2RwaW9fY21uX3Bvd2VyX3dlbGxfb3BzID0gewo+
PiAgIAkuc3luY19odyA9IGk5eHhfcG93ZXJfd2VsbF9zeW5jX2h3X25vb3AsCj4+ICAgCS5lbmFi
bGUgPSBieHRfZHBpb19jbW5fcG93ZXJfd2VsbF9lbmFibGUsCj4+IEBAIC0zNjI2LDExICszNjg1
LDE3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaTkxNV9wb3dlcl93ZWxsX2Rlc2MgdGdsX3Bvd2Vy
X3dlbGxzW10gPSB7Cj4+ICAgCQl9LAo+PiAgIAl9LAo+PiAgIAl7Cj4+IC0JCS5uYW1lID0gIkRD
IG9mZiIsCj4+ICsJCS5uYW1lID0gIkRDNSBvZmYiLAo+PiAgIAkJLmRvbWFpbnMgPSBUR0xfRElT
UExBWV9EQ19PRkZfUE9XRVJfRE9NQUlOUywKPj4gICAJCS5vcHMgPSAmZ2VuOV9kY19vZmZfcG93
ZXJfd2VsbF9vcHMsCj4+ICAgCQkuaWQgPSBESVNQX1BXX0lEX05PTkUsCj4+ICAgCX0sCj4+ICsJ
ewo+PiArCQkubmFtZSA9ICJEQzNDTyBvZmYiLAo+PiArCQkuZG9tYWlucyA9IFRHTF9ESVNQTEFZ
X0RDM0NPX09GRl9QT1dFUl9ET01BSU5TLAo+PiArCQkub3BzID0gJnRnbF9kYzNjb19wb3dlcl93
ZWxsX29wcywKPj4gKwkJLmlkID0gRElTUF9QV19JRF9OT05FLAo+PiArCX0sCj4+ICAgCXsKPj4g
ICAJCS5uYW1lID0gInBvd2VyIHdlbGwgMiIsCj4+ICAgCQkuZG9tYWlucyA9IFRHTF9QV18yX1BP
V0VSX0RPTUFJTlMsCj4+IC0tIAo+PiAyLjIxLjAKPj4KX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA
bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vaW50ZWwtZ2Z4