From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [Intel-gfx] [PATCH] i915: Add native backlight control Date: Thu, 9 Sep 2010 18:14:09 +0100 Message-ID: <20100909171409.GA25746@srcf.ucam.org> References: <1283963539-4039-1-git-send-email-mjg@redhat.com> <1283963539-4039-2-git-send-email-mjg@redhat.com> <8u3s94$gfdh5f@orsmga002.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <8u3s94$gfdh5f@orsmga002.jf.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Chris Wilson Cc: linux-kernel@vger.kernel.org, intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 09, 2010 at 06:09:40PM +0100, Chris Wilson wrote: > On Wed, 8 Sep 2010 12:32:18 -0400, Matthew Garrett wrote: > > Not all systems expose a firmware or platform mechanism for changing the > > backlight intensity on i915, so add native driver support. > > This will conflict with a similar patch I have in drm-intel-next to unify > the various bits of code that were attempting to modify the BLC PWM, each > in their own unique fashion. > > I'll respin this native interface on top of that. Do you want to add a > native RAW interface all in one go, or to base it on the current > backlight_device and then to add the RAW property with this patch set? I don't think providing a native interface in i915 is beneficial without providing the type information - userspace just doesn't have any way to identify the correct device otherwise. -- Matthew Garrett | mjg59@srcf.ucam.org