From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: remove debug fmax
Date: Mon, 1 Nov 2010 16:57:02 -0400
Message-ID: <20101101165702.57e5264c@jbarnes-x201>
References: <20101101162605.6c2c11d7@jbarnes-x201>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cpoproxy2-pub.bluehost.com (cpoproxy2-pub.bluehost.com
	[67.222.39.38])
	by gabe.freedesktop.org (Postfix) with SMTP id 514ED9E88B
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  1 Nov 2010 13:57:07 -0700 (PDT)
Received: from [12.157.84.42] (helo=jbarnes-x201)
	by box514.bluehost.com with esmtpsa (TLSv1:AES128-SHA:128)
	(Exim 4.69) (envelope-from <jbarnes@virtuousgeek.org>)
	id 1PD1RC-0000k4-AH
	for intel-gfx@lists.freedesktop.org; Mon, 01 Nov 2010 14:57:06 -0600
In-Reply-To: <20101101162605.6c2c11d7@jbarnes-x201>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 1 Nov 2010 16:26:05 -0400
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> Accidentally got pushed when we added power monitoring support.  We
> need IPS to modify this value rather than always setting it to the
> max.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c index 4954af2..688b51d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5588,7 +5588,6 @@ void ironlake_enable_drps(struct drm_device
> *dev) fmin = (rgvmodectl & MEMMODE_FMIN_MASK);
>  	fstart = (rgvmodectl & MEMMODE_FSTART_MASK) >>
>  		MEMMODE_FSTART_SHIFT;
> -	fstart = fmax;
>  
>  	vstart = (I915_READ(PXVFREQ_BASE + (fstart * 4)) &
> PXVFREQ_PX_MASK) >> PXVFREQ_PX_SHIFT;

This is necessary but not sufficient.  We also need to clamp the
initial max_delay at fstart and leave fmax alone (patch from Eric on
its way).

-- 
Jesse Barnes, Intel Open Source Technology Center