From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: please revert
 869184a675662bddcdf76c5b95665272facff2b8 ASAP
Date: Mon, 6 Dec 2010 10:04:48 -0800
Message-ID: <20101206100448.64519427@jbarnes-desktop>
References: <AANLkTinQNf5f+E4h5nUunvtRRJ=DiE0GVq2yKEkDNfqj@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com
	[66.147.249.253])
	by gabe.freedesktop.org (Postfix) with SMTP id 4F5789E73D
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  6 Dec 2010 10:11:29 -0800 (PST)
In-Reply-To: <AANLkTinQNf5f+E4h5nUunvtRRJ=DiE0GVq2yKEkDNfqj@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 29 Nov 2010 20:06:23 +1000
Dave Airlie <airlied@gmail.com> wrote:

> On Mon, Nov 29, 2010 at 7:44 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Mon, 29 Nov 2010 16:18:44 +1000, Dave Airlie <airlied@gmail.com> wrote:
> >> This commit breaks the eDP panel on the my HP Elitebook 2540p,
> >> reverting it brings the panel back to life.
> >
> > Happy to test the revert just as soon as I work out what the equivalent
> > commit is in my tree... ;-)
> > -Chris
> 
> oops
> 
> 869184a675662bddcdf76c5b95665272facff2b8
> 
> must have sent the revert commit id locally or something ;-)
> 
> drm/i915/dp: use VBT provided eDP params if available
> 
> Looks like trusting the BIOS is a bad plan, also that commit seems to
> do a lot more than just use some VBT values, probably needs more
> splitting up from jbarnes.

!#$!@!!

One day we'll have reliable eDP mode setting, I promise.  Time to
harass some more people internally about how to get sane values and
whether skipping training is generally safe (assuming we use the right
values that is!).

-- 
Jesse Barnes, Intel Open Source Technology Center