From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/3] drm/i915: Check that the plane points to the pipe's framebuffer before enabling Date: Tue, 19 Apr 2011 13:40:35 -0700 Message-ID: <20110419134035.34314caa@jbarnes-desktop> References: <1303245123-27172-1-git-send-email-chris@chris-wilson.co.uk> <1303245123-27172-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com [66.147.249.253]) by gabe.freedesktop.org (Postfix) with SMTP id CB1709E75B for ; Tue, 19 Apr 2011 13:40:37 -0700 (PDT) In-Reply-To: <1303245123-27172-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 19 Apr 2011 21:32:01 +0100 Chris Wilson wrote: > Knut Petersen reported a GPU hang when he left x11perf running > overnight. The error state quite clearly indicates that plane A was > enabled without being fully setup: > > PGTBL_ER: 0x00000010 > Display A: Invalid GTT PTE > Plane [0]: > CNTR: c1000000 > STRIDE: 00000c80 > SIZE: 03ff04ff > POS: 00000000 > ADDR: 00000000 > > [That GTT offset on his system being pinned for the ringbuffer.] > > This is a simple debugging patch to assert that this cannot be so! > > References: https://bugs.freedesktop.org/show_bug.cgi?id=36246 > Signed-off-by: Chris Wilson > Cc: Jesse Barnes > --- I like it. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center